From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012058.outbound.protection.outlook.com [40.107.200.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84DDA1805E; Thu, 25 Sep 2025 09:48:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.58 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758793696; cv=fail; b=iNUYNWXPOdrDCvu6zhjvIQzhHpxXqzExWWJ6inD8yA2TIG4MRnCPgN1IxrWXC+JLffpsZh1+4CV3kZUi+1MtVuYLXBymwbStzR2uT9mv/GR0uWVY0kQoFV1toYQ6q88b3D9egXp5N5SGlZvkxhw7ZoXuYxXspgb1zSM09V4Cs1E= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758793696; c=relaxed/simple; bh=8LOk9I4neI+oc/2Holb4fz27cE/7OgXFqai1kbzQ4ds=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=PNzJTALuzeUTDjTrDKHmPrwn3Fx1MIYH5cZYrk0cC4ZVDCM2QXPb6bFJigBCjOv/uifl2QPK5WFb/z6FmMHhXJGzbcdFnA3jpO+o8AOqJSgTNnHkg+Ft8ZRQZ2+MDinXAHlF90n/mdf+LpQ1KAc+XZTLSnFd0iAUMYCma0Ru6xM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=x0asmQZ8; arc=fail smtp.client-ip=40.107.200.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="x0asmQZ8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hR34DjjPdCkqS/FIcqhQ3KoZ0ynUmNc2QWHOeRhvZ+uiWil1p5g3eqT7jzJnYNvCG296kHsUwkFxN27VEdwqsRnaRpS6BWUp01dLuOXQJqhTj0JcWY393Akl2GfsUn5ob3LVRq2iYEluqS+fRwoH6DCgT8HScZReTg/K1qniAoUJMeYPlBNOLdYqNOJ5Nysk2LwMeKBYKQWhZYW6b08D3VIrHHN6P899cOIuMF3fePTbmVmBC79nJDMIACWEV86B4Rmh+nVYLdciZzE7gcRAWfCVA+FcCzWp9ZEELZC20+bkPWR0XlzsJPGZh7X57DH80z0fhlzVaavZxygwYY1cfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Czw01h6Gg/UFie8fcKpTsvkLqkjJjlZ2HVp0ZI8McbQ=; b=wh+CWJpVB1PVz5nHwQ0oYsvX6/uRnVy0lC3KWrkk03EBiR2DzzGKEwrtYyOmKQ067zkd5ZmWZAHZcszJqNDUWVwMwGy3kQA+XA4IsWmx/x7M/MfRF7p/hMsjP2ewNI5JsHD8P3+7UXjCsltCZZYnMolscbdi2LEfnJ5yNpD041nRt7IPWDb1qtgWqTXPJbSKMwR+TPyqzfxc2h0/zG+4BeLwqpr/mqgnu10P1CLx3+WfEmXX/jZ+j5OZWVuyAqjaOPDLykO1tR8GrDbsQCcnyNZkZwxuR/YRwYvUUmi5PdNtXDtofevYdqxWC3Dnkoi1r6O1icSU0ds5q+1sREbyMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Czw01h6Gg/UFie8fcKpTsvkLqkjJjlZ2HVp0ZI8McbQ=; b=x0asmQZ8FEvsn9UnrCumDaRQmJmtjYtIYdxk61Q1VcriP8Dkik5rjphQUeGS/zhj2EAQfeu9wjzel/WRp+J+vJoE262GIp14CvIRqst5A7QXRyQZuxie1tWUUeKCYQ49rve/2Is24mb3Cgd69HedFRfFVadm4R2FSmXwX40rfNg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4202.namprd12.prod.outlook.com (2603:10b6:5:219::22) by PH8PR12MB6841.namprd12.prod.outlook.com (2603:10b6:510:1c8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.19; Thu, 25 Sep 2025 09:48:11 +0000 Received: from DM6PR12MB4202.namprd12.prod.outlook.com ([fe80::f943:600c:2558:af79]) by DM6PR12MB4202.namprd12.prod.outlook.com ([fe80::f943:600c:2558:af79%5]) with mapi id 15.20.9137.018; Thu, 25 Sep 2025 09:48:11 +0000 Message-ID: Date: Thu, 25 Sep 2025 10:48:06 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v18 12/20] sfc: get endpoint decoder Content-Language: en-US To: "Cheatham, Benjamin" , alejandro.lucero-palau@amd.com Cc: Martin Habets , Edward Cree , Jonathan Cameron , linux-cxl@vger.kernel.org, netdev@vger.kernel.org, dan.j.williams@intel.com, edward.cree@amd.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, dave.jiang@intel.com References: <20250918091746.2034285-1-alejandro.lucero-palau@amd.com> <20250918091746.2034285-13-alejandro.lucero-palau@amd.com> From: Alejandro Lucero Palau In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0233.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::19) To DM6PR12MB4202.namprd12.prod.outlook.com (2603:10b6:5:219::22) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4202:EE_|PH8PR12MB6841:EE_ X-MS-Office365-Filtering-Correlation-Id: 546a0e7b-71a5-4f5b-ce08-08ddfc18a35d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SXFjODN4MHYvakZ5S2d5VVJQQ2RXSFRqOXhYUGhlekU3dWdFcDd6VVFsNWNT?= =?utf-8?B?bXBQMmlBMkxqbnJVTGtGWFJ3SWM4S29JTEJLaTlJUVo5eWtRRXlVVjRJcGhK?= =?utf-8?B?YjExRGhORkMxbitoZkhxc1BLZHJjS0tHVU55aThrMmJCaFdweHBoL0JxK2ZG?= =?utf-8?B?ZmtCcDExTzhhQjNWaGs0RkdVQTdTS2ptb2Y4N3hZek9LWW83OUlIR3pMNkI4?= =?utf-8?B?bThFMm9sekpuSjVKV0lyMFZCaWhYSDNQMjAxRllXOGZxRjd6SUQrRm1HWUtG?= =?utf-8?B?ZXcwaTBBNGhqTytsS2J4Mm02UVR2MTllUkxTTmZ6ZHBHamFheld0S0dhMlMx?= =?utf-8?B?b1hTcWoxNm02WWFRTld1K1M3SCtHUEZTekFMNlJNRFRWbmFvSk1YU3lyQnZu?= =?utf-8?B?M3lPRGJKN2tqK1BqRWg5Y1FSZ3BvL2tmTE5TbStGMTU1VVpQMzllaWs2Q01N?= =?utf-8?B?MjRNRFpPY08zcHBCWmhmdmQrKzhkdWJ2MHF6eDFGY2puYWJyVlVDZDlRMEUy?= =?utf-8?B?L1Bma1ByWlIvQ1FES2VyOGRNSzl1NXBWRGM4bHVJZGNURUlLd09YSDQvNnoz?= =?utf-8?B?RDhoeTNoaDZ2bUUzK3YvYzBOcm50SEE2aDkrWlZxVGpVaUJGcHcvZGwzRjQ0?= =?utf-8?B?dXNPOWtkcUt2ODBiVjVHWlNvMjd6aU5scEJ6SjNGSE5PY3AvbzFIUjcvMmFL?= =?utf-8?B?ZFZsdEk5a2M2SlRETUlFMVZuMk5JZm1YUGYwRFZtUTc0c3UvbDlNTzlBeTdv?= =?utf-8?B?eDdET0RJa2NnTTQyTHVGSThOeStXa3hvUkdYZ3podVpzRnlubDMrWUcxTHlp?= =?utf-8?B?N2M4YW9uNEhiTldmTkpDb2ZVL2NqUi9xeHNnKzYrR242TjFOTVB4b2k3QlBR?= =?utf-8?B?c1g4UmxIcTFKRWhFWVpQU2g2VjlIbEVETjd2UkVOSXN3aXkxUEYwNVhYNjdC?= =?utf-8?B?cHk0MmN4K3lZK2d5TmNNVEdoRm84c0ZpelFTcVlpMzBTd2t6dUh4Slo3SDlH?= =?utf-8?B?ZC9OeWlkY0pVeEI0bzc3MUtCdlZHZGVSdDNuWDdPNmJYemdob2xXYjh2VmlP?= =?utf-8?B?VmhON1ZoSU8yMU9QZ0xvbndLdHFmckI3N29DZVRnRTkwVXlrVkgrKzhCUjZO?= =?utf-8?B?cExiQnBudnkxcWhYdjR3R0pST1MweGtldjdaZTVmS1dpRVZqejlRVVhiV09w?= =?utf-8?B?cksyOVJyV3hxMnZPMzZBOWtLQlRuZ2ZpcDJBSE1UQndGVUIwZm15MGgxSVhU?= =?utf-8?B?Q1NqQ1g5a1FGaHEyMUxkTWxqalJvSnFkSVFUZkJ5Znl0K2I2NlNCQTBJT1NI?= =?utf-8?B?WWJncUgwTC8xY29VZWdhaGtWTmR4R20xYWVxdEtrZ2IyV2pKeVo1RUJ4MmE0?= =?utf-8?B?OTBvTVRWbjR6T3FJK1Jhb0VWNlFrVWk4Yk9YWm1ZRTBsL205eU1nUzdIVExH?= =?utf-8?B?dUpHY093d3hMRklCYkNzbzRXbk9mYkRmZ0VXT0dMVisySlQ4QUxrQ3RkaWxX?= =?utf-8?B?SVZXbHQxbkRwYTd3SHN2OXhkN0xzeEppMnQyalF6TTJ5STUrVjNRUXNxb3Ni?= =?utf-8?B?RThKeE5MN2RIVFZISmpoZE1LdU9FZFpCcU1hN04ybXE1cWphdW1LZi8xTVdP?= =?utf-8?B?ZTczcFRxQTErLzYvUEx4S09uUVZsVkdOR3pYVXp0eG1LVm5yejBYSHVFMm1a?= =?utf-8?B?SWFHMTVTUEFsdnYzeG9tem9mK0V3STArcUlsVlFzQXZpYXdTc0xCUWNBL2tw?= =?utf-8?B?OGlicUEzWGFvYlljSmRRam51TEUzVnJIOGtKM1o0NlZpUDZYaDkyUU9aV1dn?= =?utf-8?B?U1hMMjVIckZOUDBaN2oyOFhVeGRQY1prRm1MSWluRlBtSTNOQ0NZN3BRUTBI?= =?utf-8?B?REZpdFloNmxQWis0RkNMZ1J0Uk1lUFpHS1prRStNdFIrOFo4OUM3M2tHbTI3?= =?utf-8?Q?ll35vAbcc2M=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4202.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2NCK016TkpzalZaMnJ1c1JGRlB4YURBQWVRR2VsWmthOThzSU1MUDlWdzNy?= =?utf-8?B?QTVKb04wRWNTSThGMGpWSVBkUnc5aGVKTW9teWpGckJmWXU4eVB3UUU0SVMv?= =?utf-8?B?MkZkZzZhdmNtdHdTM0tKbTltVDJtNFhmaFdhcTc2bkVEL29mTmtpTDA5cTFn?= =?utf-8?B?bFVZVUZuUjFudkgvREQ0Mytyd0tkbG8zUTA4eTBibm9BRWZWSVljQ1U3VnVI?= =?utf-8?B?eTFhVUZ1VmZwWXhPalNrbDlnZTNhaWV3NHUrNDVpbm1EL3NKNnlQcWR4Q2ow?= =?utf-8?B?Wm9ZSjRDditxMmhMT1ByemJZem9ZQW9RSmM3Wlovd1B1WkFtSjlFdzEvVjJh?= =?utf-8?B?UWt1eU5RMkNCN3ByT1kvc3BjSmw1U0RyT2g1TVBvdzlDNUNVT2I2amloM2s3?= =?utf-8?B?TExBVzRmakcwellwck1wTUpoK253U296aXE3RFhkQkkrRU1sTTlCQXJsUGcy?= =?utf-8?B?VEZycDBwTnczaHZjRERrbWZ6K2l0Z2R5NDM4dU5lMnA5MGZFWm4vUGlEaWZv?= =?utf-8?B?bjJGWTFVUTE0dFJSN290TTJUbzRkMmxFRVFXbThZMk5yUytTc3BqdmRWYzJq?= =?utf-8?B?YnRJbFI1RWRBU1JneFhIR0dSK0pVUUsrdXFtckVwL2k4ZEw5d25xM2dab2g2?= =?utf-8?B?TmVoYXpqeTJjU0NIczM5ZEg3TEdad0V1d0lzRk1sNmtqQ2JZN0ZZUFZHdDBZ?= =?utf-8?B?MWxRekF5VURLQXhkRnl0VVgzdE5yUVRiWVFPU1FaMjRFbXMvWXV0NkdqT1E2?= =?utf-8?B?T2t4S0tjSEZDTi9WSWlhNU5NU3dLajhMQlZ4OFkyam9nY1IrRWw1TG91NXFt?= =?utf-8?B?Vk9xeWVLcDNFQTFKQWRmUlBaRHlBZGY5WDQ4SDYrK2hNTmZTbUNSMjF4QTd2?= =?utf-8?B?MVRZZG5BNUUyZ1FGd1dZdlJwUHJZTW1YM0hmNnNhMm1WbTY5aWtQL2haejUy?= =?utf-8?B?ZXdnMXZCTVliMFY1cSthdDF3cVQ4VUdYdEFHOFYvRVphMnVOSUkrZjNKdHdO?= =?utf-8?B?UXJuNTEySUhQbTNIcDg5Q3cyYU00T3lnRU4rTFIreDkvMTN1emlCZnR3c2RV?= =?utf-8?B?Vyt4aC9VTUl1L0dCNGx2dkNMTDB0SkE2YXF0K2JDd1BQNHpZVzB5cVdXbzNE?= =?utf-8?B?ai95a1ZyMDUzZFFFeU1KNEdVWFR2Ri82K1AySldXMFIvSVRyQmlxRGVvdmZm?= =?utf-8?B?cjdnR05LNm95U0J6MmFuVnFDdnBESWpWYjJZMjc2MFZtdnNYc2VpdnlUL2ZM?= =?utf-8?B?UWVydHF2TXhON0NrWUVqcHI4bHFWelV1RGhJQ3BKaDhEYkZDTzdTQU1obXJ3?= =?utf-8?B?eDFsME05dm85cjh6UU1uRUZUR09UdmJzc3hjOXdRN0V0SWhLK3lPOFFpKzVp?= =?utf-8?B?emRRWHlEWUFVWVZJYWlWaDdUUjVLTVQ1N3J5eXdKcDh4aTAzUkgyblIwOTFB?= =?utf-8?B?bVZQUUcyRHUzUk1QSGdRcEJGcEh5TXBTRkRLZkw1dk9ybFc4bHNDOTIwbFVH?= =?utf-8?B?Ny9FalM0VHpQRzRMM2pZYnRWU1hmdmFxLytUOGU1U241Z1U5UmMyYW5rdEZ5?= =?utf-8?B?U3g2L0J0SUxMYjlxck1mbGxpZGNTNWFwVEZROTF0cWlkRHBQdkdkR1JFMzBn?= =?utf-8?B?bXY1THdBYmY2MUxPaEFYZVcwU3BWK1diMUFlcWl6UU04VWF6R1VkZHpRZG1a?= =?utf-8?B?NkNRMWdkbEpDL3VuakQzWjd4dU82K2R6QVVYN3N3Tnl1KzNQbHZZb2I0N25J?= =?utf-8?B?TXFpamhWaUs4VStIUVM4NGozc0t1UlJKTmJ4b2NSdEZUcWl6Rk5mc2VLOTFi?= =?utf-8?B?QWZ5eCtSNUx6WXpGVDVUMVB1UG5za3VVMHRqRHRTSlF0QjFyMWg1QlV6d0VU?= =?utf-8?B?d1VVaVh2VXFKRFE3eFRUaXFHbkVvYUR6aCtHcnhrWC9EaFFzYkJQNkN2Z2VR?= =?utf-8?B?ZnRBS0FZaTMzdWFzMlMvWk9CU1lUc3N1a0dGYnd3dkJobjBWdksxREZiblVM?= =?utf-8?B?Z256M2xvcVdRVStBU29uK2JrcmNTc2FXT0NwL2dHMnFTcXUrREtMNWZhdkZR?= =?utf-8?B?TWZHUG1UQzdDa3drM2xuMyttb29RTytHVGJYMmVBRzNoSkU4cmMwMkQrUFcv?= =?utf-8?Q?e8wor+XfODwe0FT5fsdFbWC25?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 546a0e7b-71a5-4f5b-ce08-08ddfc18a35d X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4202.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2025 09:48:10.9546 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /JuVja6d6kM71QQcBWAppOHe6Ua1P6AyG0LPQQNjExtFvjv/Ui6VK2QEcvi9GJ1KMuR5KSXap3xOOkxG+Ggcvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6841 On 9/22/25 22:09, Cheatham, Benjamin wrote: > On 9/18/2025 4:17 AM, alejandro.lucero-palau@amd.com wrote: >> From: Alejandro Lucero >> >> Use cxl api for getting DPA (Device Physical Address) to use through an >> endpoint decoder. >> >> Signed-off-by: Alejandro Lucero >> Reviewed-by: Martin Habets >> Acked-by: Edward Cree >> Reviewed-by: Jonathan Cameron >> --- > With Jonathan's change: > Reviewed-by: Ben Cheatham As commented in Jonathan's review, I'm simplifying the unwinding when errors in v19. Since it is not making any important change, I will add your Reviewed-by tag, but tell me if you do not want to. Thank you