Linux CXL
 help / color / mirror / Atom feed
From: alison.schofield@intel.com
To: Ben Widawsky <ben.widawsky@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>, linux-cxl@vger.kernel.org
Subject: [PATCH v2 0/4] Do not allow set-partition immediate mode
Date: Fri, 25 Feb 2022 12:30:57 -0800	[thread overview]
Message-ID: <cover.1645817416.git.alison.schofield@intel.com> (raw)

From: Alison Schofield <alison.schofield@intel.com>

The v1 to address this issue was a single patch [1] that inserted
a new immediate mode check in the send path where the payload was
available for examining. That was not in the 'validation' function.

Reviewer feedback led to refactoring the send path of userspace mailbox
commands so that validation work can all spawn from one place:
cxl_validate_cmd_from_user().

Hence this set:
Patches 1,2: Refactor existing code. 
Patch 3: Blocks the immediate mode of the set-partition command.
	 Original v1 patch updated per reviewer feedback.
Patch 4: Removes CXL_PMEM exclusive commands restriction.

Changes in v2:
- Refactor the send path of userspace mbox cmds. (Dan, Ben)
- Patch 3 commit log - update the need to block. (Dan)
- Return -EBUSY (not -EINVAL), when blocking immediate mode. (Ben)
- Remove unneeded cast of void (payload_in). (dan)
- s/u64/__le64 in struct cxl_mbox_set_partition_info. (Dan)

[1] https://lore.kernel.org/linux-cxl/20220103202100.784194-1-alison.schofield@intel.com/

Alison Schofield (4):
  cxl/mbox: Move cxl_mem_command construction to helper funcs
  cxl/mbox: Centralize the validation of user commands
  cxl/mbox: Block immediate mode in SET_PARTITION_INFO command
  cxl/pmem: Remove CXL SET_PARTITION_INFO from exclusive_cmds list

 drivers/cxl/core/mbox.c | 308 +++++++++++++++++++++++-----------------
 drivers/cxl/cxlmem.h    |   7 +
 drivers/cxl/pmem.c      |   1 -
 3 files changed, 184 insertions(+), 132 deletions(-)


base-commit: 3e9e1e72c0c24fcbeb8c96f4e886be138f61496f
-- 
2.31.1


             reply	other threads:[~2022-02-25 20:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25 20:30 alison.schofield [this message]
2022-02-25 20:30 ` [PATCH v2 1/4] cxl/mbox: Move cxl_mem_command construction to helper funcs alison.schofield
2022-02-25 21:31   ` Dan Williams
2022-02-25 20:30 ` [PATCH v2 2/4] cxl/mbox: Centralize the validation of user commands alison.schofield
2022-02-25 20:31 ` [PATCH v2 3/4] cxl/mbox: Block immediate mode in SET_PARTITION_INFO command alison.schofield
2022-02-25 20:31 ` [PATCH v2 4/4] cxl/pmem: Remove CXL SET_PARTITION_INFO from exclusive_cmds list alison.schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1645817416.git.alison.schofield@intel.com \
    --to=alison.schofield@intel.com \
    --cc=ben.widawsky@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox