Re: [PATCH 0/7] ndctl: cxl: add monitor support for trace events

[Dave Jiang <dave.jiang@intel.com>]

On 9/14/2022 1:47 PM, Dave Jiang wrote:
> This patch series for ndctl implements the monitor command for the cxl tool.
> The initial implementation will collect CXL trace events emitted by the
> kernel. libtraceevent and libtracefs will be used to parse the trace
> event buffer. The monitor will pend on an epoll fd and wait for new event
> entries to be posted. The output will be in json format. By default the events
> are emitted to stdio, but can also be logged to a file. Each event is converted
> to a JSON object and logged as such. All the fields exported are read by the
> monitor code and added to the JSON object.
>
> ---
>
> Dave Jiang (7):
>        ndctl: cxl: add helper function to parse trace event to json object
>        ndctl: cxl: add helper to parse through all current events
>        ndctl: cxl: add common function to enable event trace
>        ndctl: cxl: add common function to disable event trace
>        ndctl: cxl: add monitor function for event trace events
>        ndctl: cxl: add logging functions for monitor
>        ndctl: cxl: add monitor command to cxl

Missing man page and systemd service. Will add in v2. Also will add 
default log file path when running in daemon mode.


>
>   cxl/builtin.h     |   1 +
>   cxl/cxl.c         |   1 +
>   cxl/event_trace.c | 236 ++++++++++++++++++++++++++++++++++++++++++++++
>   cxl/event_trace.h |  23 +++++
>   cxl/meson.build   |   4 +
>   cxl/monitor.c     | 235 +++++++++++++++++++++++++++++++++++++++++++++
>   meson.build       |   3 +
>   7 files changed, 503 insertions(+)
>   create mode 100644 cxl/event_trace.c
>   create mode 100644 cxl/event_trace.h
>   create mode 100644 cxl/monitor.c
>
> --
>