From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE9352459DD for ; Sun, 28 Dec 2025 13:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766928602; cv=none; b=lO4o+gJkpnYlukMTq7HYmzQXYhO+NKxUqvsET1bpP+TZsMdbnAzQCDcy7FAeMCBAssb+slp4b+VcpFkdtkBu5O0Ea28j7LUYpY5eqooEHj4w674S6O5pnvE5wlgNna2dye85hqVWuiuPp4DClqAFqptqea/75B/0tanAEYVKfCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766928602; c=relaxed/simple; bh=wzDS29pPv16SN5nJL5o+rnuk9lYuas+/v91h2NRmxn8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=seofU4ofHrf70EsLeDZuByr1mJ12xvSlnLJBFMkASsJvGLHy3OJM4bxBNfiC4NuG78gV0dZxJc+w8CGq89JC2Jqy3AckvHkfabeW5berH4GyIntvLjmwR6Rb40UG2bJfE2b7wyAp9+xbUyDGepKP6R/NQn1JI95a6dto1Q6OucI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CBbJP4Wd; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CBbJP4Wd" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-594330147efso10221822e87.2 for ; Sun, 28 Dec 2025 05:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766928597; x=1767533397; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7lWyQqsYJqWc7lm9cTjRQLwXSVE/IuAz3ei2okz3340=; b=CBbJP4Wdvc5B3CtNBGl5G6PisnIwIVLPNh8y4Kkq93W609O9ot7XWQibM0OLU65I/J fZSkQapbMmJM9qylzG59pNAQQCoFbf7eLiNYx/sdrlqO75lpbsXWsTL8/8GFqamEzxFY WA8ACeyUJYEi9eeF+y7nq3g+RuqCjgjKrJwuxJWVEXUajudGQCXirn0V8LI53fholcUn f97854AWZmSeBdJGIM5wG+a+i2oIfMXPbNrMsFtJ8pvQFKK2eeahgADjCIlZM73yW9Bg j4Mn2JayNUGtPg8x6F5e6VX+R08Q7VldGFH44K83MM0RuS7lm/zMLjNaijINZR5KbalO uEYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766928597; x=1767533397; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7lWyQqsYJqWc7lm9cTjRQLwXSVE/IuAz3ei2okz3340=; b=MC5RpkK/YceGrBkZXCCY8VtbxUwDSWe36Y7C6v1krlxeo6zL3DFBd6Of4hk5rxbrno h1qrF+JIgVPyGGZXiOlaeyyoaugi2DPMk+e/DfBLhA/TUEUZj0p5efyVXAYBiIRBcz4p cG0WliH38MHQ9B7CXmipcSxZgw92rr6c5DLxS6QT9aFGNI5JaHGiGGkfgQXVoRo3W5KC RXzlE01VsMt4heYHKA2ZW6kqXOSO83WrIK3qAJoAk4ryLEtyxCo35cKG+oiRIAdWI+K7 RuXfh+1Ux7yy1A4EczW9WmGZ4sREGu8Eadk77rfXxu73CWebMbIlWY2XpX3gl/6C4M/3 isgw== X-Forwarded-Encrypted: i=1; AJvYcCVKiFt4MJx+S/3gruh7mTPt78nC5QaZXb/fBT2uYzU46IqhqKDbWCUiySSgW+D2IMQcQKtNv+gigaI=@vger.kernel.org X-Gm-Message-State: AOJu0YzL5BwjgkopuQ5RqXXAUVEMsl64hpRpebXEUyasxDoOfBSLmNvc DVhiiYtdoJej9VlsamuTaa+1dSYcfsUcD7riAoVe+MnUYWlOnedCMO0f X-Gm-Gg: AY/fxX6FGRVPCInuDkktpIYB4tKxNXatYFg/Ch+EpBtF6pEYSTDd03gqJyU1aF/sHOJ MscgJAzCwQFNzQ8eH3QTZcHs6ngzsHi31JIVUMSpIcA7kwL2RDe5/Tb6KRpPyI4kpnpR7s79+Em fodPGtxubMNxvHir+mBOrNTZHLRlifU8JHEUTttnkWSoLrb4GnYj1enl0R5PSFrGyBtIU1frTP+ 14XuMOWSFZgZi/9A7aOaKLl9Lqleon62KyLBTNF9w3nV+emCPlsdF7SKdm+9ERX1qKl0B99NkPi qoKa2p2aV47wosgJp5bA8AMHa6zzuiMX8RI/ZCkaKjgcbcn/pmCwUOSkNo9eBRBhcf121H2bfsM eg23AklSMa51JjQdFHKVWVXdnDi6oTBq8P/QBInbYX8v/LmgFsM0o9VDAdOrTCfcpualLlCNrcV ob5WtqzNH8nQgZlH0iJMV1bvcaMHyXcWGaJmZgkVS7EQ5X9m0uCEIbE3EcwtP/D7p5v6Q/VdMwX pQfg2Pj X-Google-Smtp-Source: AGHT+IGo/pr+AQ2VNaaG2TyhewLh2BG0nsRAoXdF/d33J1EZZvYOr8FxE2Re2WZCgj4kGCoIAYrr8g== X-Received: by 2002:a05:6512:3b0c:b0:59a:11b2:2c08 with SMTP id 2adb3069b0e04-59a17dd5fb7mr9312428e87.43.1766928596662; Sun, 28 Dec 2025 05:29:56 -0800 (PST) Received: from ?IPV6:2a00:1fa0:425c:b771:d34f:d055:3147:bcd9? ([2a00:1fa0:425c:b771:d34f:d055:3147:bcd9]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59a185d602fsm8238417e87.11.2025.12.28.05.29.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Dec 2025 05:29:55 -0800 (PST) Message-ID: Date: Sun, 28 Dec 2025 16:29:49 +0300 Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 25/28] x86: don't reserve hugetlb memory in setup_arch() To: Mike Rapoport , Andrew Morton Cc: Alex Shi , Alexander Gordeev , Andreas Larsson , Borislav Petkov , Brian Cain , "Christophe Leroy (CS GROUP)" , Catalin Marinas , "David S. Miller" , Dave Hansen , David Hildenbrand , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Jonathan Corbet , "Liam R. Howlett" , Lorenzo Stoakes , Magnus Lindholm , Matt Turner , Max Filippov , Michael Ellerman , Michal Hocko , Michal Simek , Muchun Song , Oscar Salvador , Palmer Dabbelt , Pratyush Yadav , Richard Weinberger , Russell King , Stafford Horne , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Vlastimil Babka , Will Deacon , x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org References: <20251228124001.3624742-1-rppt@kernel.org> <20251228124001.3624742-26-rppt@kernel.org> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: <20251228124001.3624742-26-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/28/25 3:39 PM, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Commit 665eaf313314 ("x86/setup: call hugetlb_bootmem_alloc early") > added an early call to hugetlb_bootmem_alloc() to setup_arch() to allow > HVO style pre-initialization of vmemmap on x86. > > With the ordering of hugetlb reservation vs memory map initiaization > sorted out in core MM this no longer needs to be an architecture specific > quirk. > > Drop the call to hugetlb_bootmem_alloc() from x86::setup_arch(). > > Signed-off-by: Mike Rapoport (Microsoft) > --- > arch/x86/kernel/setup.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index 1b2edd07a3e1..e2318fa9b1bb 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -1191,7 +1191,6 @@ void __init setup_arch(char **cmdline_p) > > if (boot_cpu_has(X86_FEATURE_GBPAGES)) { > hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT); > - hugetlb_bootmem_alloc(); > } You need to drop {} now, no? But seeing that this *if* gets dropped altogether in the next patch, you may as well ignore me... :-) [...] MBR, Sergey