From: alison.schofield@intel.com
To: Ben Widawsky <ben.widawsky@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: [ndctl PATCH v2 5/6] libcxl: add interfaces for SET_PARTITION_INFO mailbox command
Date: Tue, 11 Jan 2022 22:33:33 -0800 [thread overview]
Message-ID: <dae8e094fe9dd897cb16510a86644ad1fab97efe.1641965853.git.alison.schofield@intel.com> (raw)
In-Reply-To: <cover.1641965853.git.alison.schofield@intel.com>
From: Alison Schofield <alison.schofield@intel.com>
Users may want the ability to change the partition layout of a CXL
memory device.
Add interfaces to libcxl to allocate and send a SET_PARTITION_INFO
mailbox as defined in the CXL 2.0 specification.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
cxl/lib/libcxl.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++
cxl/lib/libcxl.sym | 5 +++++
cxl/lib/private.h | 8 ++++++++
cxl/libcxl.h | 5 +++++
4 files changed, 68 insertions(+)
diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c
index 823bcb0..30c8f23 100644
--- a/cxl/lib/libcxl.c
+++ b/cxl/lib/libcxl.c
@@ -1230,6 +1230,21 @@ cxl_cmd_partition_info_get_next_persistent_bytes(struct cxl_cmd *cmd)
cmd_partition_get_capacity_field(cmd, next_persistent_cap);
}
+CXL_EXPORT struct cxl_cmd *cxl_cmd_new_set_partition_info(struct cxl_memdev *memdev,
+ unsigned long long volatile_capacity, int flags)
+{
+ struct cxl_cmd_set_partition_info *set_partition;
+ struct cxl_cmd *cmd;
+
+ cmd = cxl_cmd_new_generic(memdev,
+ CXL_MEM_COMMAND_ID_SET_PARTITION_INFO);
+
+ set_partition = (struct cxl_cmd_set_partition_info *)cmd->send_cmd->in.payload;
+ set_partition->volatile_capacity = cpu_to_le64(volatile_capacity);
+ set_partition->flags = flags;
+ return cmd;
+}
+
CXL_EXPORT int cxl_cmd_submit(struct cxl_cmd *cmd)
{
struct cxl_memdev *memdev = cmd->memdev;
@@ -1428,3 +1443,38 @@ CXL_EXPORT int cxl_memdev_read_label(struct cxl_memdev *memdev, void *buf,
{
return lsa_op(memdev, LSA_OP_GET, buf, length, offset);
}
+
+CXL_EXPORT int cxl_memdev_set_partition_info(struct cxl_memdev *memdev,
+ unsigned long long volatile_capacity, int flags)
+{
+ struct cxl_ctx *ctx = cxl_memdev_get_ctx(memdev);
+ struct cxl_cmd *cmd;
+ int rc;
+
+ dbg(ctx, "%s: enter cap: %llx, flags %d\n", __func__,
+ volatile_capacity, flags);
+
+ cmd = cxl_cmd_new_set_partition_info(memdev,
+ volatile_capacity / CXL_CAPACITY_MULTIPLIER, flags);
+ if (!cmd)
+ return -ENXIO;
+
+ rc = cxl_cmd_submit(cmd);
+ if (rc < 0) {
+ err(ctx, "cmd submission failed: %s\n", strerror(-rc));
+ goto err;
+ }
+ rc = cxl_cmd_get_mbox_status(cmd);
+ if (rc != 0) {
+ err(ctx, "%s: mbox status: %d\n", __func__, rc);
+ rc = -ENXIO;
+ }
+err:
+ cxl_cmd_unref(cmd);
+ return rc;
+}
+
+CXL_EXPORT int cxl_cmd_partition_info_flag_immediate(void)
+{
+ return CXL_CMD_SET_PARTITION_INFO_FLAG_IMMEDIATE;
+}
diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym
index 1e2cf05..d5a0f5b 100644
--- a/cxl/lib/libcxl.sym
+++ b/cxl/lib/libcxl.sym
@@ -78,6 +78,11 @@ global:
cxl_cmd_partition_info_get_active_persistent_bytes;
cxl_cmd_partition_info_get_next_volatile_bytes;
cxl_cmd_partition_info_get_next_persistent_bytes;
+ cxl_cmd_new_set_partition_info;
+ cxl_memdev_set_partition_info;
+ cxl_cmd_partition_info_flag_none;
+ cxl_cmd_partition_info_flag_immediate;
+
local:
*;
};
diff --git a/cxl/lib/private.h b/cxl/lib/private.h
index dd9234f..4da8ea7 100644
--- a/cxl/lib/private.h
+++ b/cxl/lib/private.h
@@ -114,6 +114,14 @@ struct cxl_cmd_get_partition_info {
#define CXL_CAPACITY_MULTIPLIER SZ_256M
+struct cxl_cmd_set_partition_info {
+ le64 volatile_capacity;
+ u8 flags;
+} __attribute__((packed));
+
+/* CXL 2.0 8.2.9.5.2 Set Partition Info */
+#define CXL_CMD_SET_PARTITION_INFO_FLAG_IMMEDIATE BIT(0)
+
/* CXL 2.0 8.2.9.5.3 Byte 0 Health Status */
#define CXL_CMD_HEALTH_INFO_STATUS_MAINTENANCE_NEEDED_MASK BIT(0)
#define CXL_CMD_HEALTH_INFO_STATUS_PERFORMANCE_DEGRADED_MASK BIT(1)
diff --git a/cxl/libcxl.h b/cxl/libcxl.h
index f19ed4f..8f1a330 100644
--- a/cxl/libcxl.h
+++ b/cxl/libcxl.h
@@ -50,6 +50,8 @@ int cxl_memdev_read_label(struct cxl_memdev *memdev, void *buf, size_t length,
size_t offset);
int cxl_memdev_write_label(struct cxl_memdev *memdev, void *buf, size_t length,
size_t offset);
+int cxl_memdev_set_partition_info(struct cxl_memdev *memdev,
+ unsigned long long volatile_capacity, int flags);
#define cxl_memdev_foreach(ctx, memdev) \
for (memdev = cxl_memdev_get_first(ctx); \
@@ -117,6 +119,9 @@ unsigned long long cxl_cmd_partition_info_get_active_volatile_bytes(struct cxl_c
unsigned long long cxl_cmd_partition_info_get_active_persistent_bytes(struct cxl_cmd *cmd);
unsigned long long cxl_cmd_partition_info_get_next_volatile_bytes(struct cxl_cmd *cmd);
unsigned long long cxl_cmd_partition_info_get_next_persistent_bytes(struct cxl_cmd *cmd);
+struct cxl_cmd *cxl_cmd_new_set_partition_info(struct cxl_memdev *memdev,
+ unsigned long long volatile_capacity, int flags);
+int cxl_cmd_partition_info_flag_immediate(void);
#ifdef __cplusplus
} /* extern "C" */
--
2.31.1
next prev parent reply other threads:[~2022-01-12 6:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 6:33 [ndctl PATCH v2 0/6] Add partitioning support for CXL memdevs alison.schofield
2022-01-12 6:33 ` [ndctl PATCH v2 1/6] libcxl: add GET_PARTITION_INFO mailbox command and accessors alison.schofield
2022-01-12 6:33 ` [ndctl PATCH v2 2/6] libcxl: add accessors for capacity fields of the IDENTIFY command alison.schofield
2022-01-12 6:33 ` [ndctl PATCH v2 3/6] libcxl: return the partition alignment field in bytes alison.schofield
2022-01-13 16:31 ` Alison Schofield
2022-01-13 16:34 ` Alison Schofield
2022-01-14 7:28 ` Verma, Vishal L
2022-01-12 6:33 ` [ndctl PATCH v2 4/6] cxl: add memdev partition information to cxl-list alison.schofield
2022-01-12 6:33 ` alison.schofield [this message]
2022-01-12 6:33 ` [ndctl PATCH v2 6/6] cxl: add command set-partition-info alison.schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dae8e094fe9dd897cb16510a86644ad1fab97efe.1641965853.git.alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox