From: Dongsheng Yang <dongsheng.yang@easystack.cn>
To: Randy Dunlap <rdunlap@infradead.org>,
dan.j.williams@intel.com, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cxl@vger.kernel.org,
Dongsheng Yang <dongsheng.yang.linux@gmail.com>
Subject: Re: [PATCH 1/7] block: Init for CBD(CXL Block Device)
Date: Tue, 23 Apr 2024 06:41:11 +0800 [thread overview]
Message-ID: <dd1df8f1-f80c-5a3a-f804-3e360bfac339@easystack.cn> (raw)
In-Reply-To: <7d24e1fb-520c-4ec2-a6aa-89856092891a@infradead.org>
在 2024/4/23 星期二 上午 2:39, Randy Dunlap 写道:
> Hi,
>
> On 4/22/24 12:16 AM, Dongsheng Yang wrote:
>> diff --git a/drivers/block/cbd/Kconfig b/drivers/block/cbd/Kconfig
>> new file mode 100644
>> index 000000000000..98b2cbcdf895
>> --- /dev/null
>> +++ b/drivers/block/cbd/Kconfig
>> @@ -0,0 +1,4 @@
>> +config BLK_DEV_CBD
>> + tristate "CXL Block Device"
>> + help
>> + If unsure say 'm'.
>
> I think that needs more help text. checkpatch should have said something
> about that...
>
> And why should someone say 'm' to the config question?
> Will lots of (non-server) computers have CXL block device capability?
Hi,
Thanx for your review! In this RFC version, I have focused entirely
on prototype validation and demonstration, so this aspect has evidently
been overlooked. I will supplement the help text in the next version. Of
course, this place should be If unsure say "n", not "m".
Thanx
>
> thanks.
>
next prev parent reply other threads:[~2024-04-22 22:57 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 7:15 [PATCH RFC 0/7] block: Introduce CBD (CXL Block Device) Dongsheng Yang
2024-04-22 7:16 ` [PATCH 1/7] block: Init for CBD(CXL " Dongsheng Yang
2024-04-22 18:39 ` Randy Dunlap
2024-04-22 22:41 ` Dongsheng Yang [this message]
2024-04-24 3:58 ` Chaitanya Kulkarni
2024-04-24 8:36 ` Dongsheng Yang
2024-04-22 7:16 ` [PATCH 2/7] cbd: introduce cbd_transport Dongsheng Yang
2024-04-24 4:08 ` Chaitanya Kulkarni
2024-04-24 8:43 ` Dongsheng Yang
2024-04-22 7:16 ` [PATCH 3/7] cbd: introduce cbd_channel Dongsheng Yang
2024-04-22 7:16 ` [PATCH 4/7] cbd: introduce cbd_host Dongsheng Yang
2024-04-25 5:51 ` [EXTERNAL] " Bharat Bhushan
2024-04-22 7:16 ` [PATCH 5/7] cbd: introuce cbd_backend Dongsheng Yang
2024-04-24 5:03 ` Chaitanya Kulkarni
2024-04-24 8:36 ` Dongsheng Yang
2024-04-25 5:46 ` [EXTERNAL] " Bharat Bhushan
2024-04-22 7:16 ` [PATCH 7/7] cbd: add related sysfs files in transport register Dongsheng Yang
2024-04-25 5:24 ` [EXTERNAL] " Bharat Bhushan
2024-04-22 22:42 ` [PATCH 6/7] cbd: introduce cbd_blkdev Dongsheng Yang
2024-04-23 7:27 ` Dongsheng Yang
2024-04-24 4:29 ` [PATCH RFC 0/7] block: Introduce CBD (CXL Block Device) Dan Williams
2024-04-24 6:33 ` Dongsheng Yang
2024-04-24 15:14 ` Gregory Price
2024-04-26 1:25 ` Dongsheng Yang
2024-04-26 13:48 ` Gregory Price
2024-04-26 14:53 ` Dongsheng Yang
2024-04-26 16:14 ` Gregory Price
2024-04-28 5:47 ` Dongsheng Yang
2024-04-28 16:44 ` Gregory Price
2024-04-28 16:55 ` John Groves
2024-05-03 9:52 ` Jonathan Cameron
2024-05-08 11:39 ` Dongsheng Yang
2024-05-08 12:11 ` Jonathan Cameron
2024-05-08 13:03 ` Dongsheng Yang
2024-05-08 15:44 ` Jonathan Cameron
2024-05-09 11:24 ` Dongsheng Yang
2024-05-09 12:21 ` Jonathan Cameron
2024-05-09 13:03 ` Dongsheng Yang
2024-05-21 18:41 ` Dan Williams
2024-05-22 6:17 ` Dongsheng Yang
2024-05-29 15:25 ` Gregory Price
2024-05-30 6:59 ` Dongsheng Yang
2024-05-30 13:38 ` Jonathan Cameron
2024-06-01 3:22 ` Dan Williams
2024-06-03 12:48 ` Jonathan Cameron
2024-06-03 17:28 ` James Morse
2024-06-04 14:26 ` Jonathan Cameron
2024-05-31 14:23 ` Gregory Price
2024-06-03 1:33 ` Dongsheng Yang
2024-04-30 0:34 ` Dan Williams
2024-04-24 18:08 ` Dan Williams
[not found] ` <539c1323-68f9-d753-a102-692b69049c20@easystack.cn>
2024-04-30 0:10 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd1df8f1-f80c-5a3a-f804-3e360bfac339@easystack.cn \
--to=dongsheng.yang@easystack.cn \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=dongsheng.yang.linux@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox