From: Dave Jiang <dave.jiang@intel.com>
To: Minwoo Im <minwoo.im.dev@gmail.com>,
linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev
Cc: Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [ndctl PATCH 3/3] cxl: fix changed function name in a comment
Date: Tue, 9 May 2023 10:33:27 -0700 [thread overview]
Message-ID: <dd2b7ea6-ee1d-9c49-0dc0-311269f786e6@intel.com> (raw)
In-Reply-To: <20230509152427.6920-4-minwoo.im.dev@gmail.com>
On 5/9/23 8:24 AM, Minwoo Im wrote:
> cxl_memdev_target_find_decoder() has been renamed to
> cxl_memdev_find_decoder in Commit 21b089025178 ("cxl: add a
> 'create-region' command"). Fix function name in a comment.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> cxl/region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cxl/region.c b/cxl/region.c
> index 71f152d9e5a5..45f0c6a3771c 100644
> --- a/cxl/region.c
> +++ b/cxl/region.c
> @@ -676,7 +676,7 @@ static int create_region(struct cxl_ctx *ctx, int *count,
> }
> if (cxl_decoder_get_mode(ep_decoder) != p->mode) {
> /*
> - * The memdev_target_find_decoder() helper returns a free
> + * The cxl_memdev_find_decoder() helper returns a free
> * decoder whose size has been checked for 0.
> * Thus it is safe to change the mode here if needed.
> */
prev parent reply other threads:[~2023-05-09 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 15:24 [ndctl PATCH 0/3] cxl: clean up and fix typos Minwoo Im
2023-05-09 15:24 ` [ndctl PATCH 1/3] cxl/list: Fix typo in cxl-list documentation Minwoo Im
2023-05-09 17:31 ` Dave Jiang
2023-05-09 15:24 ` [ndctl PATCH 2/3] cxl: region: remove redundant func name from error Minwoo Im
2023-05-09 17:32 ` Dave Jiang
2023-05-09 15:24 ` [ndctl PATCH 3/3] cxl: fix changed function name in a comment Minwoo Im
2023-05-09 17:33 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd2b7ea6-ee1d-9c49-0dc0-311269f786e6@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=minwoo.im.dev@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox