Re: [PATCH v5 0/8] Introduce fwctl subystem

["Nelson, Shannon" <shannon.nelson@amd.com>]

On 3/11/2025 4:23 AM, David Ahern wrote:
> On 3/6/25 12:21 AM, Jason Gunthorpe wrote:

>>
>>> It should be something that is tightly coupled with aux, currently
>>> aux is under drivers/base/auxiliary.c I think it should move to
>>> drivers/aux/auxiliary.c and device drivers should implement their
>>> own aux buses, WH access APIs and probing/init logic under that
>>> directory e.g: drivers/aux/mlx5/..
>>
>> That makes sense to me. I would expect everything in this collection
>> to be PCI drivers spawing aux devices.
>>
>> drivers/aux_core/ or something like that, perhaps?
>>
> 
> drivers/aux_core works for me; removes the 'pci' assumption and makes it
> clear the real attribute here is use of the aux bus with subsystem
> specific devices. I am still not clear on how such a branch will work -
> e.g. We will want multi-vendor review, not just merge the PR and go.
> 

At the risk of getting too far into the naming-choosing rat hole... note 
that even "aux_core" has the assumption that the thing is auxiliary_bus 
oriented, which I don't think is a hard truth.  As an example, yes 
pds_core supports pds_vdpa through an auxiliary_device, but it also 
supports pds_vfio_pci with no aux dev involved.

I could live with drivers/aux_core, but I'd prefer drivers/core.

sln