From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E24D81DDF8 for ; Wed, 28 Feb 2024 03:16:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709090222; cv=none; b=PDwBn2UtBNQrV/1N4Om5mhFXPF0m8MoDTbM4cXcr0PNoDUKpTm8sBFNK7v4GFnisO36KfgI1abJxdnzTOTteN9TsSv0ZoSTJ3p835piOhjZ72GYCZXI9HhTEHfvaKJ2laPMN/0GW/AdWO8OlmFbPR6Hoome2aweSeLDkLb4y+AY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709090222; c=relaxed/simple; bh=0KdTPWMru+xfweo66KvjuRZDB4qBIIrrYr1uS8ZAx8k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uk7vKhkHd4fqRQjcSODhXVhxrtBVo3CKXuE6v5tmtVvwRn3Xk+v3x1T8pZPdKcXfmNb6e3EPf7lRhjdQMKGKIyGDVerl39Fc8nPQM18AxfjQ1gc4I6aXTYbxqwP4iwoPqBliecNxgH18H2e0jDRShiohP36f/GiRrn0hIJRhbm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=J2yH1+pS; arc=none smtp.client-ip=95.215.58.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="J2yH1+pS" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1709090218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q94KM6gcpM8pQoPvK7faabgANBdOOMF+oah02Ewb8ys=; b=J2yH1+pSqzP1U6gjneMP/EO1gmyllNDn/eJJ5z1pOfcYCT7IFnaIWLzAuIBCZ7HaLWZVEY o3HFIPfibXvyLSAIcvEWVgH3nz47duNfp9giLn4cGzJaRynD8GR02C3eZBxwaxEkHxBBMj Vghaddk2NMghxARmAfRbL6XAtgVZPWI= Date: Wed, 28 Feb 2024 11:16:45 +0800 Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] dax: remove SLAB_MEM_SPREAD flag usage Content-Language: en-US To: Dave Jiang , dan.j.williams@intel.com, vishal.l.verma@intel.com Cc: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240224134728.829289-1-chengming.zhou@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2024/2/28 00:29, Dave Jiang wrote: > > > On 2/24/24 6:47 AM, chengming.zhou@linux.dev wrote: >> From: Chengming Zhou >> >> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove >> its usage so we can delete it from slab. No functional change. > > Can you please provide a Link tag to the lore post that indicates SLAB_MEM_SPREAD flag is now a no-op? Update changelog to make it clearer: The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete explicitly to avoid confusion for users. Here we can just remove all its users, which has no any functional change. [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ Thanks! >> >> Signed-off-by: Chengming Zhou >> --- >> drivers/dax/super.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dax/super.c b/drivers/dax/super.c >> index 54e528779877..cff0a15b7236 100644 >> --- a/drivers/dax/super.c >> +++ b/drivers/dax/super.c >> @@ -547,7 +547,7 @@ static int dax_fs_init(void) >> >> dax_cache = kmem_cache_create("dax_cache", sizeof(struct dax_device), 0, >> (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT| >> - SLAB_MEM_SPREAD|SLAB_ACCOUNT), >> + SLAB_ACCOUNT), >> init_once); >> if (!dax_cache) >> return -ENOMEM;