Re: [PATCH] cxl/mem: Demarcate vendor specific capability IDs

["Verma, Vishal L" <vishal.l.verma@intel.com>]

On Thu, 2021-05-20 at 13:48 -0700, Ben Widawsky wrote:
> Vendor capabilities occupy 0x8000 to 0xFFFF according to CXL 2.0 spec
> 8.2.8.2.1 CXL Device Capabilities. While they are not defined by the
> spec, they are allowed and not "unknown". Call this detail out in the
> logs to let users easily distinguish the difference.
> 
> This patch is a squash of two earlier patches and take in some minor
> suggestions from both Vishal and Dan.

Should this be in the commit mesasge?

> 
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
> ---

Other than that, looks good to me,

Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>

>  drivers/cxl/core.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/core.c b/drivers/cxl/core.c
> index 84b90db57420..38979c97158d 100644
> --- a/drivers/cxl/core.c
> +++ b/drivers/cxl/core.c
> @@ -60,7 +60,10 @@ void cxl_setup_device_regs(struct device *dev, void __iomem *base,
>  			regs->memdev = register_block;
>  			break;
>  		default:
> -			dev_dbg(dev, "Unknown cap ID: %d (0x%x)\n", cap_id, offset);
> +			if (cap_id >= 0x8000)
> +				dev_dbg(dev, "Vendor cap ID: %#x offset: %#x\n", cap_id, offset);
> +			else
> +				dev_dbg(dev, "Unknown cap ID: %#x offset: %#x\n", cap_id, offset);
>  			break;
>  		}
>  	}