From: Dave Jiang <dave.jiang@intel.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
qemu-devel@nongnu.org, linux-cxl@vger.kernel.org
Cc: Jonathan.Cameron@huawei.com, dan.j.williams@intel.com
Subject: Re: [RFC PATCH SET] cxl: add poison event handler
Date: Mon, 12 Feb 2024 17:20:12 -0700 [thread overview]
Message-ID: <fd03964a-0b16-42f3-8572-0a7686beda93@intel.com> (raw)
In-Reply-To: <20240209115417.724638-1-ruansy.fnst@fujitsu.com>
On 2/9/24 4:54 AM, Shiyang Ruan wrote:
> Currently driver only trace cxl events, poison injection on cxl memdev
> is silent. OS needs to be notified then it could handle poison range
> in time. Per CXL spec, the device error event could be signaled through
> FW-First and OS-First methods.
>
> This draft patchset adds poison event handler in OS-First method:
> - qemu:
> - CXL device report POISON event to OS by MSI by sending GMER after
> injecting a poison record
> - CXL driver
> a. read the POISON event through GMER;
> b. get POISON list;
> c. translate DPA to HPA;
> d. construct a mce instance, then call mce_log() to queue this mce
> instance;
>
> This patchset includes 2 patches for qemu, 5 patches for cxl driver.
Hi Ruan,
Next time please split this out and post as 2 different series. You can have the CXL driver series cover letter reference the QEMU changes. And please add QEMU to subject prefix for the QEMU patches. Thank you!
>
> Shiyang Ruan (5):
> cxl/core: correct length of DPA field masks
> cxl/core: introduce cxl_memdev_dpa_to_hpa()
> cxl/core: introduce cxl_mem_report_poison()
> cxl/core: add report option for cxl_mem_get_poison()
> cxl/core: add poison injection event handler
>
> arch/x86/kernel/cpu/mce/core.c | 1 +
> drivers/cxl/core/mbox.c | 82 +++++++++++++++++++++++++++-------
> drivers/cxl/core/memdev.c | 16 ++++++-
> drivers/cxl/core/region.c | 8 ++--
> drivers/cxl/core/trace.h | 6 +--
> drivers/cxl/cxlmem.h | 11 ++---
> drivers/cxl/pci.c | 4 +-
> 7 files changed, 97 insertions(+), 31 deletions(-)
>
prev parent reply other threads:[~2024-02-13 0:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 11:54 [RFC PATCH SET] cxl: add poison event handler Shiyang Ruan
2024-02-09 11:54 ` [RFC PATCH 1/2] hw/cxl/type3: add missing flag bit for GMER Shiyang Ruan
2024-02-13 16:27 ` Jonathan Cameron
2024-02-09 11:54 ` [RFC PATCH 2/2] hw/cxl/type3: send a GMER while injecting poison Shiyang Ruan
2024-02-13 16:32 ` Jonathan Cameron
2024-02-09 11:54 ` [RFC PATCH 1/5] cxl/core: correct length of DPA field masks Shiyang Ruan
2024-02-10 6:34 ` Dan Williams
2024-02-19 10:49 ` Shiyang Ruan
2024-02-22 2:27 ` Dan Williams
2024-02-09 11:54 ` [RFC PATCH 2/5] cxl/core: introduce cxl_memdev_dpa_to_hpa() Shiyang Ruan
2024-02-10 6:39 ` Dan Williams
2024-02-09 11:54 ` [RFC PATCH 3/5] cxl/core: introduce cxl_mem_report_poison() Shiyang Ruan
2024-02-10 6:46 ` Dan Williams
2024-03-14 15:23 ` Shiyang Ruan
2024-02-15 1:19 ` Tony Luck
2024-02-09 11:54 ` [RFC PATCH 4/5] cxl/core: add report option for cxl_mem_get_poison() Shiyang Ruan
2024-02-10 6:49 ` Dan Williams
2024-03-14 15:01 ` Shiyang Ruan
2024-02-09 11:54 ` [RFC PATCH 5/5] cxl/core: add poison injection event handler Shiyang Ruan
2024-02-10 6:54 ` Dan Williams
2024-02-13 16:51 ` Jonathan Cameron
2024-03-15 2:29 ` Shiyang Ruan
2024-04-05 17:35 ` Jonathan Cameron
2024-02-13 0:20 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd03964a-0b16-42f3-8572-0a7686beda93@intel.com \
--to=dave.jiang@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=ruansy.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox