>-----Original Message-----
>From: Dan Williams <dan.j.williams@intel.com>
>Sent: 06 December 2024 00:48
>To: Dave Jiang <dave.jiang@intel.com>; linux-cxl@vger.kernel.org
>Cc: dan.j.williams@intel.com; ira.weiny@intel.com; vishal.l.verma@intel.com;
>alison.schofield@intel.com; Jonathan Cameron
><jonathan.cameron@huawei.com>; dave@stgolabs.net; jgg@nvidia.com; Shiju
>Jose <shiju.jose@huawei.com>
>Subject: Re: [RFC PATCH v2 06/20] cxl/mbox: Add SET_FEATURE mailbox
>command
>
>Dave Jiang wrote:
>> From: Shiju Jose <shiju.jose@huawei.com>
>>
>> Add support for SET_FEATURE mailbox command.
>>
>> CXL spec 3.1 section 8.2.9.6 describes optional device specific features.
>> CXL devices supports features with changeable attributes.
>> The settings of a feature can be optionally modified using Set Feature
>> command.
>> CXL spec 3.1 section 8.2.9.6.3 describes Set Feature command.
>>
>> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>> ---
>> This patch is not needed except for the opcode enumeration.
>> ---
>
>Same reaction as a the last patch.
>
>We can always circle back to add this on top if really necessary, but lets keep
>this set on topic with the cover letter of enabling fwctl for features.

Hi Dan, 

I  modified to cxl_set_feature(struct cxl_mailbox *cxl_mbox, ..) in the EDAC CXL features setup and tested fine.

Thanks,
Shiju