Re: [PATCH v15 09/16] PCI/CXL: Cache endpoint HDM state during PCI enumeration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing MODULE_IMPORT_NS("CXL") in drivers/pci/cxl.c causes modpost namespace warnings.
--

commit 316d4b1d9e38508bd7197a5097af59c2f4cb6fd4
Author: Srirangan Madhavan <smadhavan@nvidia.com>

PCI/CXL: Cache endpoint HDM state during PCI enumeration
    
This commit caches the HDM state in pci_dev->hdm after BAR resource
setup and before driver binding, allowing resets to restore it without
a bound CXL driver. It saves the HDM register location, decoder settings,
and Device DVSEC state, keeping PCI discovery separate from shared HDM helpers.

Link: https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git/commit/?id=b12baa1105f33cc1a10f9c9c0c6376194397d9f3

> diff --git a/drivers/pci/cxl.c b/drivers/pci/cxl.c
> new file mode 100644
> index 0000000000000..471b57391593e
> --- /dev/null
> +++ b/drivers/pci/cxl.c

[ ... ]

> +static void __iomem *cxl_pci_hdm_map_regs(struct pci_dev *pdev,
> +					  struct cxl_register_map *map,
> +					  resource_size_t *hdm_offset,
> +					  int *decoder_count)
> +{
> +	struct cxl_reg_map *hdm_map = &map->component_map.hdm_decoder;
> +	void __iomem *hdm;
> +	int rc;
> +
> +	/* cxl_setup_regs() populates hdm_map, including its valid bit. */
> +	rc = cxl_setup_regs(map);

[Severity: Low]
Does this file need a MODULE_IMPORT_NS("CXL") declaration?

cxl_setup_regs() is exported via EXPORT_SYMBOL_NS_GPL(cxl_setup_regs, "CXL"),
and drivers/pci/cxl.c invokes this exported function during device enumeration.
Because the file lacks MODULE_IMPORT_NS("CXL");, it causes modpost to emit a
namespace violation warning when verifying vmlinux.o imports.

While this does not cause functional runtime failure, it pollutes the build
logs and can cause build failures under strict configurations.

> +	if (rc)
> +		return ERR_PTR(rc);
> +	if (!hdm_map->valid)
> +		return ERR_PTR(-ENODEV);

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011021422.3428136-1-smadhavan@nvidia.com?part=9