From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795200303; b=qKRs2kO6TM7e+I5OghJ6YBAhsZrspScNK03iTw2b6ssRZ0ot8wD2kn0r5qoLD5na+o6T DOT9Sce/1TEa3AaIG/2C0YtYkAym9/Y6fwHd344QfFzm3GDlorb+19E6qNHNf+fWOGhqj 0VaO5N6/tILowXBMW65ta8TBIbdwcsFvU2+uc65xYNJ2qc3qS/nBwKqzi1JPlntfmC721 53+oAqA3isDr++9tE1LwhQ3QYUM8apLfdXFg8B4kp7yTYhxgGzThpzjbj8HV4byxDEhL3 c2wU6Y1dP8fFKWi+tJZ35P5ul2KI7Kr5Z9+BFV49AiYPj9BmRzDLN0fppqM/xtBJ08Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795200303; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=JkD8OAgj2F6n9ADRagW+iRBXIRn65B4wvrkdyDCF1eY=; b=BxAr7VSUn/hIbKlTWtn68l2szcyDMYMcbdfJQSyssiXqDB9vYCtm63LAg4uFIWXHRHEh 72fkc2j8FX5pmePUZgWwb2+FnPWsglnSm4MA5FPdiCyMi7qbWN7VdDzdA0KBx7YT53Ah+ 7sodpTytVQlLlnTW6c/dhaVH3ju52sn6SPNoedl/q9gS/8b2e8hEoe3fIWYFHvh/Csx+X aXWb2cWBmpBC78nJh1+UOolWG4JE2ngiDTBAAayOT8t5p0Z7spgjZ/25dCyDeOFLa1mz3 R7vljT37xYqfVrg8hiYpmVKfyVkvEVT63PNrJzjLF4naA8vchY++4bEyWtdcbqHvqCg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mZpKbZWp; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C116606A336; Fri, 20 Nov 2026 18:45:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=mZpKbZWp Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACF691F000C4; Fri, 20 Nov 2026 18:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795200303; bh=JkD8OAgj2F6n9ADRagW+iRBXIRn65B4wvrkdyDCF1eY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=mZpKbZWpPyYmKD5mdR1NBPflVu5LCjYaDLXFtvUrDi+FUIbI12jRvq8ILCI+72EkV jTZ9Hg2M52sw422CskDZVdQhDmK1+QvKdw96l+79+BAISPonVrmnDe10S/txpNpWHu YEgNNMSr0dz5zrtg6L7fJy4EtlwXwTP+AmpOtjLPqN+zuVRjDNcJtn84Cce2oHc3UX GYgSivawkmiQSWYEdeZJ8gWnxtKIgJbo52OuTMACpRKWNDyfjv+uhPOcwVkSQvjI77 0CzNnzTduX2XANH12L0BAmOfsDq7hIcU4fYsuWtA09ac7o9wuJ4fTJ63pRWkgeaFqv BJM3B5d9wrbUQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 53/60] mm/mempolicy: add MPOL_F_PRIVATE_NODES for private node bindings Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?R3JlZ29yeSBQcmljZSAoTWV0YSk=?= , "Yury Norov" , "Rasmus Villemoes" , "David Hildenbrand" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Michal Hocko" , "Andrew Morton" , "Oscar Salvador" , "Johannes Weiner" , "Suren Baghdasaryan" , "Brendan Jackman" , "Zi Yan" , "Jonathan Corbet" , "Shuah Khan" , "Randy Dunlap" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Danilo Krummrich" , "Johan Hovold" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Matthew Brost" , "Byungchul Park" , "Alistair Popple" , "SJ Park" , "Ingo Molnar" , "Peter Zijlstra" , "Juri Lelli" , "Vincent Guittot" , "Dietmar Eggemann" , "Steven Rostedt" , "Ben Segall" , "Mel Gorman" , "Valentin Schneider" , "K Prateek Nayak" , "Kees Cook" , "Kairui Song" , "Barry Song" , "Qi Zheng" , "Shakeel Butt" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Michal Hocko" , "David Rientjes" , "Pavel Machek" , "Len Brown" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Lance Yang" , "Usama Arif" , "Kiryl Shutsemau" , "Xu Xin" , "Chengming Zhou" , "Lorenzo Stoakes" , "Pedro Falcato" , "Jann Horn" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNs?= =?utf-8?b?ZSk=?= , "Jan Kara" , "Waiman Long" , "Ridong Chen" , "Tejun Heo" , =?utf-8?b?TWljaGFsIEtvdXRuw70=?= , "Dan Williams" , "Vishal Verma" , "Dave Jiang" , "Alison Schofield" , "Shuah Khan" Cc: linux-mm@kvack.org, linux-cxl@vger.kernel.org, damon@lists.linux.dev, nvdimm@lists.linux.dev In-Reply-To: <20261120-private_nodes_v6-v1-53-74f5f9a115c2@gourry.net> References: <20261120-private_nodes_v6-v1-0-74f5f9a115c2@gourry.net> <20261120-private_nodes_v6-v1-53-74f5f9a115c2@gourry.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 20 Nov 2026 18:44:59 +0000 X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] mm/mempolicy: incomplete suspension of private bindings in alloc_pages_mpol() -- commit ca3f7c695f126ea25e293faadb9871a86c3c7899 Author: Gregory Price (Meta) mm/mempolicy: add MPOL_F_PRIVATE_NODES for private node bindings This commit adds the MPOL_F_PRIVATE_NODES mode flag for mbind() to explicit= ly bind a VMA with MPOL_BIND to a single private memory node in N_MEMORY_MEMPOLICY. > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 9d2e56017ebe5..cb5419cb7ee84 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c [ ... ] > @@ -2495,10 +2539,20 @@ static struct page *alloc_pages_preferred_many(gf= p_t gfp, unsigned int order, > static struct page *alloc_pages_mpol(gfp_t gfp, unsigned int order, > struct mempolicy *pol, pgoff_t ilx, int nid) > { > + unsigned int alloc_flags =3D ALLOC_DEFAULT; > nodemask_t *nodemask; > struct page *page; > =20 > nodemask =3D policy_nodemask(gfp, pol, ilx, &nid); > + if (nodemask && (pol->flags & MPOL_F_PRIVATE_NODES)) { > + int private_nid =3D first_node(*nodemask); > + > + if (node_state(private_nid, N_MEMORY_MEMPOLICY) && > + node_state(private_nid, N_MEMORY_PRIVATE)) { > + nid =3D private_nid; > + alloc_flags =3D ALLOC_ZONELIST_PRIVATE; > + } > + } > =20 > if (pol->mode =3D=3D MPOL_PREFERRED_MANY) > return alloc_pages_preferred_many(gfp, order, nid, nodemask); > @@ -2520,24 +2574,26 @@ static struct page *alloc_pages_mpol(gfp_t gfp, u= nsigned int order, > pol->mode !=3D MPOL_WEIGHTED_INTERLEAVE && > (!nodemask || node_isset(nid, *nodemask))) { > /* > - * First, try to allocate THP only on local node, but > + * First, try to allocate THP only on the selected node, but > * don't reclaim unnecessarily, just compact. > */ > page =3D __alloc_frozen_pages_noprof( > gfp | __GFP_THISNODE | __GFP_NORETRY, order, > - nid, NULL, ALLOC_DEFAULT); > + nid, (alloc_flags & ALLOC_ZONELIST_PRIVATE) ? > + nodemask : NULL, alloc_flags); > if (page || !(gfp & __GFP_DIRECT_RECLAIM)) > return page; > /* > * If hugepage allocations are configured to always > * synchronous compact or the vma has been madvised > * to prefer hugepage backing, retry allowing remote > - * memory with both reclaim and compact as well. > + * memory with both reclaim and compact as well. A > + * private binding stays on its local zonelist. > */ > } > } > =20 > - page =3D __alloc_frozen_pages_noprof(gfp, order, nid, nodemask, ALLOC_D= EFAULT); > + page =3D __alloc_frozen_pages_noprof(gfp, order, nid, nodemask, alloc_f= lags); [Severity: High] Does alloc_pages_mpol() fail to suspend a private binding to common memory when private_nid becomes ineligible without returning as N_MEMORY_COMMON? When private_nid is not in both N_MEMORY_MEMPOLICY and N_MEMORY_PRIVATE, alloc_pages_mpol() leaves nodemask set to &pol->nodes with alloc_flags =3D ALLOC_DEFAULT instead of clearing nodemask to NULL when !node_state(private_nid, N_MEMORY_COMMON). If private_nid is offlined, node_clear_memory_state() clears N_MEMORY_PRIVA= TE and N_HIGH_MEMORY, so apply_policy_zone() still accepts ZONE_MOVABLE faults. When CONFIG_CPUSETS=3Dn (or before cpuset hotplug work updates current->mems_allowed), policy_nodemask() still returns &pol->nodes. Passing nodemask =3D &pol->nodes with ALLOC_DEFAULT finds no zones in ZONELIST_FALL= BACK, and in __alloc_pages_slowpath() alloc_is_private() returns false because ALLOC_ZONELIST_PRIVATE is not set and N_MEMORY_PRIVATE was already cleared: mm/page_alloc.c:alloc_is_private() { if (ac->alloc_flags & ALLOC_ZONELIST_PRIVATE) return true; return ac->nodemask && nodes_intersects(*ac->nodemask, node_states[N_MEMORY_PRIVATE]); } As a result, relax_private_alloc() does not relax ac->nodemask, the fault fails without setting current->private_alloc_failed, and handle_mm_fault() returns VM_FAULT_OOM and invokes the global OOM killer instead of falling back to common memory. Likewise, if private_nid stays online in N_MEMORY_PRIVATE without N_MEMORY_MEMPOLICY, leaving nodemask =3D &pol->nod= es with ALLOC_DEFAULT misses the fastpath on every fault and forces every allocation through __alloc_pages_slowpath() and relax_private_alloc(). In addition, if set_mempolicy_home_node() was used to set pol->home_node to private_nid, policy_nodemask() unconditionally sets *nid =3D pol->home_node even when the private binding is suspended: mm/mempolicy.c:policy_nodemask() { ... case MPOL_BIND: if (apply_policy_zone(pol, gfp_zone(current_gfp_context(gfp))) && cpuset_nodemask_valid_mems_allowed(&pol->nodes)) nodemask =3D &pol->nodes; if (pol->home_node !=3D NUMA_NO_NODE) *nid =3D pol->home_node; break; ... } On the PMD THP branch in alloc_pages_mpol(), __alloc_frozen_pages_noprof() = is then called with __GFP_THISNODE, nid =3D private_nid, and ALLOC_DEFAULT, wh= ich selects private_nid's empty ZONELIST_NOFALLBACK and causes GFP_TRANSHUGE_LIGHT allocations (!(gfp & __GFP_DIRECT_RECLAIM)) to return NULL instead of allocating from common memory. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261120-private_no= des_v6-v1-0-74f5f9a115c2@gourry.net?part=3D53