Linux debuggers
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
	"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
	Omar Sandoval <osandov@osandov.com>,
	David Hildenbrand <david@redhat.com>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Hao Ge <gehao@kylinos.cn>,
	linux-debuggers@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] mm: convert page type macros to enum
Date: Fri, 7 Jun 2024 21:27:38 -0700	[thread overview]
Message-ID: <20240607212738.bf55318aebd7172fadaa11c5@linux-foundation.org> (raw)
In-Reply-To: <20240607202954.1198180-1-stephen.s.brennan@oracle.com>

On Fri,  7 Jun 2024 13:29:53 -0700 Stephen Brennan <stephen.s.brennan@oracle.com> wrote:

> Changing PG_slab from a page flag to a page type in commit 46df8e73a4a3
> ("mm: free up PG_slab") in has the unintended consequence of removing
> the PG_slab constant from kernel debuginfo. The commit does add the
> value to the vmcoreinfo note, which allows debuggers to find the value
> without hardcoding it. However it's most flexible to continue
> representing the constant with an enum. To that end, convert the page
> type fields into an enum. Debuggers will now be able to detect that
> PG_slab's type has changed from enum pageflags to enum pagetype.
> 
> Fixes: 46df8e73a4a3 ("mm: free up PG_slab")

Should we backport this into 6.9.x?

  reply	other threads:[~2024-06-08  4:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07 20:29 [PATCH v4] mm: convert page type macros to enum Stephen Brennan
2024-06-08  4:27 ` Andrew Morton [this message]
2024-06-10 22:41   ` Stephen Brennan
2024-06-17 20:34     ` Stephen Brennan
2024-06-17 20:59       ` Andrew Morton
2024-06-17 21:29       ` Andrew Morton
2024-06-17 22:14         ` Stephen Brennan
2024-06-18 21:14           ` Andrew Morton
2024-06-18  6:35         ` David Hildenbrand
2024-06-11 13:07 ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240607212738.bf55318aebd7172fadaa11c5@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=gehao@kylinos.cn \
    --cc=linux-debuggers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osandov@osandov.com \
    --cc=stephen.s.brennan@oracle.com \
    --cc=vbabka@suse.cz \
    --cc=vishal.moola@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox