From: Amal Raj T <tjarlama@gmail.com>
To: danielt@kernel.org, dianders@chromium.org,
jason.wessel@windriver.com, stephen.s.brennan@oracle.com
Cc: tjarlama@gmail.com, amalrajt@meta.com, osandov@osandov.com,
linux-debuggers@vger.kernel.org, linux-serial@vger.kernel.org,
kgdb-bugreport@lists.sourceforge.net
Subject: [PATCH v3 2/3] kgdb: Add command linux.vmcoreinfo to kgdb
Date: Mon, 13 Jan 2025 09:29:34 -0800 [thread overview]
Message-ID: <20250113172936.1434532-3-tjarlama@gmail.com> (raw)
In-Reply-To: <20250113172936.1434532-1-tjarlama@gmail.com>
From: Amal Raj T <amalrajt@meta.com>
The current implementation of `poll_put_char` in the serial console driver
performs LF -> CRLF replacement, which can corrupt binary data. Since kdb
is the only user of `poll_put_char`, this patch moves the LF -> CRLF
replacement logic to kdb.
Link: https://lore.kernel.org/linux-debuggers/Zy093jVKPs9gSVx2@telecaster/
---
drivers/tty/serial/serial_core.c | 2 --
kernel/debug/kdb/kdb_io.c | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 74fa02b23772..8e702f3deffb 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2738,8 +2738,6 @@ static void uart_poll_put_char(struct tty_driver *driver, int line, char ch)
if (!port)
return;
- if (ch == '\n')
- port->ops->poll_put_char(port, '\r');
port->ops->poll_put_char(port, ch);
uart_port_deref(port);
}
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 6a77f1c779c4..43a7c8ad741a 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -572,6 +572,8 @@ static void kdb_msg_write(const char *msg, int msg_len)
len = msg_len;
while (len--) {
+ if (*cp == '\n')
+ dbg_io_ops->write_char('\r');
dbg_io_ops->write_char(*cp);
cp++;
}
--
2.43.5
next prev parent reply other threads:[~2025-01-13 17:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gmail>
2024-12-10 13:34 ` [PATCH 0/3] Add a new command in kgdb for vmcoreinfo Amal Raj T
2024-12-10 13:34 ` [PATCH 1/3] kgdb: Add kgdb_mem2ebin function for converting memory to binary format Amal Raj T
2024-12-10 13:34 ` [PATCH 2/3] serial: Move LF -> CRLF replacement from serial console to kdb Amal Raj T
2024-12-10 15:16 ` Daniel Thompson
2024-12-11 15:40 ` Amal
2024-12-10 13:34 ` [PATCH 3/3] kgdb: Add command linux.vmcoreinfo to kgdb Amal Raj T
2024-12-11 15:39 ` [PATCH v2 0/3] Add a new command in kgdb for vmcoreinfo Amal Raj T
2024-12-11 15:39 ` [PATCH v2 1/3] kgdb: Add kgdb_mem2ebin function for converting memory to binary format Amal Raj T
2024-12-13 0:55 ` Doug Anderson
[not found] ` <CAOfKSRMBYp6dSbhRqQXm09QUoJTaLjQr0XFqzqGVGeJ-KKoMuQ@mail.gmail.com>
2025-01-24 23:17 ` Doug Anderson
2025-01-08 11:40 ` Daniel Thompson
2024-12-11 15:39 ` [PATCH v2 2/3] serial: Move LF -> CRLF replacement from serial console to kdb Amal Raj T
2024-12-13 0:55 ` Doug Anderson
2024-12-11 15:39 ` [PATCH v2 3/3] kgdb: Add command linux.vmcoreinfo to kgdb Amal Raj T
2024-12-13 0:56 ` Doug Anderson
2025-01-13 17:29 ` [PATCH v3 0/3] Add a new command in kgdb for vmcoreinfo Amal Raj T
2025-01-13 17:29 ` [PATCH v3 1/3] kgdb: Add kgdb_mem2ebin function for converting memory to binary format Amal Raj T
2025-01-13 20:38 ` Stephen Brennan
2025-01-13 17:29 ` Amal Raj T [this message]
2025-01-13 23:24 ` [PATCH v3 2/3] kgdb: Add command linux.vmcoreinfo to kgdb Stephen Brennan
2025-01-13 17:29 ` [PATCH v3 2/3] serial: Move LF -> CRLF replacement from serial console to kdb Amal Raj T
2025-01-13 21:29 ` Stephen Brennan
2025-01-24 22:55 ` Doug Anderson
2025-01-13 17:29 ` [PATCH v3 3/3] kgdb: Add command linux.vmcoreinfo to kgdb Amal Raj T
2025-01-13 23:22 ` Stephen Brennan
2025-01-14 21:18 ` Stephen Brennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113172936.1434532-3-tjarlama@gmail.com \
--to=tjarlama@gmail.com \
--cc=amalrajt@meta.com \
--cc=danielt@kernel.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-debuggers@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=stephen.s.brennan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).