Linux debuggers
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: linux-fsdevel@vger.kernel.org, Omar Sandoval <osandov@osandov.com>
Cc: Christian Brauner <brauner@kernel.org>, NeilBrown <neilb@suse.de>,
	linux-debuggers@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] dcache: convert dentry flag macros to enum
Date: Wed,  9 Apr 2025 12:19:25 +0200	[thread overview]
Message-ID: <20250409-sinkflug-fettgehalt-addc48830fbf@brauner> (raw)
In-Reply-To: <177665a082f048cf536b9cd6af467b3be6b6e6ed.1744141838.git.osandov@fb.com>

On Tue, 08 Apr 2025 13:00:53 -0700, Omar Sandoval wrote:
> Commit 9748cb2dc393 ("VFS: repack DENTRY_ flags.") changed the value of
> DCACHE_MOUNTED, which broke drgn's path_lookup() helper. drgn is forced
> to hard-code it because it's a macro, and macros aren't preserved in
> debugging information by default.
> 
> Enums, on the other hand, are included in debugging information. Convert
> the DCACHE_* flag macros to an enum so that debugging tools like drgn
> and bpftrace can make use of them.
> 
> [...]

This seems good to me and helps drgn. I've reflowed the enum a bit.

---

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] dcache: convert dentry flag macros to enum
      https://git.kernel.org/vfs/vfs/c/63690b75feb1

      parent reply	other threads:[~2025-04-09 10:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 20:00 [PATCH] dcache: convert dentry flag macros to enum Omar Sandoval
2025-04-09 10:14 ` Christian Brauner
2025-04-09 10:19 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250409-sinkflug-fettgehalt-addc48830fbf@brauner \
    --to=brauner@kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-debuggers@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox