Linux debuggers
 help / color / mirror / Atom feed
From: Tony Ambardar <tony.ambardar@gmail.com>
To: linux-kernel@vger.kernel.org, linux-debuggers@vger.kernel.org
Cc: Tony Ambardar <tony.ambardar@gmail.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Kieran Bingham <kbingham@kernel.org>,
	Stephen Brennan <stephen.s.brennan@oracle.com>,
	Christian Brauner <brauner@kernel.org>
Subject: [PATCH v1] scripts/gdb: fix parsing of MNT_* constants
Date: Sat, 31 May 2025 22:50:27 -0700	[thread overview]
Message-ID: <20250601055027.3661480-1-tony.ambardar@gmail.com> (raw)

Recently, constants in linux/mount.h were changed from integer macros
parsable by LX_VALUE() to enums which are not, thus breaking gdb python
scripts:

  Reading symbols from vmlinux...
  Traceback (most recent call last):
    File ".../linux/vmlinux-gdb.py", line 25, in <module>
      import linux.constants
    File ".../linux/scripts/gdb/linux/constants.py", line 19, in <module>
      LX_MNT_NOSUID = MNT_NOSUID
  NameError: name 'MNT_NOSUID' is not defined

Update to parse with LX_GDBPARSED(), which correctly handles enums.

Fixes: 101f2bbab541 ("fs: convert mount flags to enum")
Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
---
 scripts/gdb/linux/constants.py.in | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
index fd6bd69c5096..d5e3069f42a7 100644
--- a/scripts/gdb/linux/constants.py.in
+++ b/scripts/gdb/linux/constants.py.in
@@ -73,12 +73,12 @@ if IS_BUILTIN(CONFIG_MODULES):
     LX_GDBPARSED(MOD_RO_AFTER_INIT)
 
 /* linux/mount.h */
-LX_VALUE(MNT_NOSUID)
-LX_VALUE(MNT_NODEV)
-LX_VALUE(MNT_NOEXEC)
-LX_VALUE(MNT_NOATIME)
-LX_VALUE(MNT_NODIRATIME)
-LX_VALUE(MNT_RELATIME)
+LX_GDBPARSED(MNT_NOSUID)
+LX_GDBPARSED(MNT_NODEV)
+LX_GDBPARSED(MNT_NOEXEC)
+LX_GDBPARSED(MNT_NOATIME)
+LX_GDBPARSED(MNT_NODIRATIME)
+LX_GDBPARSED(MNT_RELATIME)
 
 /* linux/threads.h */
 LX_VALUE(NR_CPUS)
-- 
2.34.1


             reply	other threads:[~2025-06-01  5:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-01  5:50 Tony Ambardar [this message]
2025-06-03  4:42 ` [PATCH v1] scripts/gdb: fix parsing of MNT_* constants Stephen Brennan
2025-06-03 16:17   ` Florian Fainelli
2025-06-19 21:51     ` Florian Fainelli
2025-06-20  5:50       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250601055027.3661480-1-tony.ambardar@gmail.com \
    --to=tony.ambardar@gmail.com \
    --cc=brauner@kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kbingham@kernel.org \
    --cc=linux-debuggers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stephen.s.brennan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox