From: Heiko Carstens <hca@linux.ibm.com>
To: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Andrew Donnellan <andrew+kernel@donnellan.id.au>,
linux-s390@vger.kernel.org, linux-debuggers@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: add CFI directives for call_on_stack
Date: Wed, 18 Nov 2026 11:13:23 +0100 [thread overview]
Message-ID: <20261118101323.14542B45-hca@linux.ibm.com> (raw)
In-Reply-To: <87qzgkpsby.fsf@oracle.com>
Hi Stephen,
On Mon, Nov 16, 2026 at 10:02:57AM -0800, Stephen Brennan wrote:
> Stephen Brennan <stephen.s.brennan@oracle.com> writes:
> > When debugging s390 on drgn, we experience two issues. First, when a
> > panic is triggered on CPU 0, drgn is unable to unwind past a stack
> > switching event[1,2]. Second, drgn is unable to unwind through an
> > interrupt exception frame.
> >
> > It turns out that the reason for both is the generated call_on_stack()
> > assembly. It modifies %r15 (the stack pointer) without any CFI
> > directives describing this change. Thus, the compiler-generated CFI is
> > wrong, and drgn tries to unwind using rules based on the wrong SP value.
> >
> > To resolve this, use %r10 (a callee-saved register) to store the CFA in
> > a temporary register. Then, emit a CFI directive describing the change.
> > So long as DWARF CFI is used to unwind all leaf functions, the value of
> > %r10 should be recoverable, and unwinders will be able to use it to
> > determine the CFA and continue to the new stack.
> >
> > I've tested this only in a QEMU VM using drgn's vmtest framework.
> > With the patch, drgn is able to unwind through two stack changes: the
> > change to the IRQ stack, and the change to the CPU0 nodat_stack during a
> > panic on CPU 0.
> >
> > [1]: https://github.com/osandov/drgn/blob/97b613c23bd4d100a61b3b06fb1b5097fcef9f61/vmtest/enter_kdump.py#L69-L74
> > [2]: https://github.com/osandov/drgn/blob/97b613c23bd4d100a61b3b06fb1b5097fcef9f61/tests/linux_kernel/vmcore/test_vmcore.py#L19-L25
> >
> > Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
>
> Hello,
>
> Following up on this patch. Is there any additional verification I can
> work on to help facilitate review?
Sorry for the late reply and thanks for providing the fix!
Please be a bit more patient, your patch was not forgotten, and
nothing needs to be done on your side. Might take another couple
of days before I get to it.
prev parent reply other threads:[~2026-11-18 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 23:17 [PATCH] s390: add CFI directives for call_on_stack Stephen Brennan
2026-11-16 18:02 ` Stephen Brennan
2026-11-18 10:13 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118101323.14542B45-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=andrew+kernel@donnellan.id.au \
--cc=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=linux-debuggers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=stephen.s.brennan@oracle.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox