Linux debuggers
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: elfutils-devel@sourceware.org, linux-debuggers@vger.kernel.org
Subject: Re: [PATCH v2 0/5] debuginfod: speed up extraction from kernel debuginfo packages by 200x
Date: Tue, 16 Jul 2024 14:15:37 -0700	[thread overview]
Message-ID: <Zpbi-VXYv7dmP_8H@telecaster.dhcp.thefacebook.com> (raw)
In-Reply-To: <20240716201601.GB7214@redhat.com>

On Tue, Jul 16, 2024 at 04:16:01PM -0400, Frank Ch. Eigler wrote:
> Hi -
> 
> > This is v2 of my patch series optimizing debuginfod for kernel
> > debuginfo.  v1 is here [7].
> 
> This generally looks great to me.  I'll send it through the testsuite
> trybots here.

Great, thank you!

> But there isn't an xz-y test case yet.  Is there a
> smallish seekable-xz rpm file that you have or could make that we
> could jam into the elfutils testsuite?

Good point, I'll add one.

> (A prometheus metric counting
> seeked-xz attempts/successes would be cool to assist testing and to
> monitor it on deployed servers.)

I do have:

  inc_metric("error_count","lzma",to_string(rc));

in lzma_exception and:

  inc_metric ("http_responses_total","result",metric);

in create_buildid_r_response, which gets called with
metric = "seekable archive".  But I'll add another metric for attempts,
and name the existing one "seekable xz archive" to be more explicit.

Thanks,
Omar

  reply	other threads:[~2024-07-16 21:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-15 10:04 [PATCH v2 0/5] debuginfod: speed up extraction from kernel debuginfo packages by 200x Omar Sandoval
2024-07-15 10:04 ` [PATCH v2 1/5] debuginfod: factor out common code for responding from an archive Omar Sandoval
2024-07-15 10:04 ` [PATCH v2 2/5] debugifod: add new table and views for seekable archives Omar Sandoval
2024-07-15 10:04 ` [PATCH v2 3/5] debuginfod: optimize extraction from seekable xz archives Omar Sandoval
2024-07-15 10:04 ` [PATCH v2 4/5] debuginfod: populate _r_seekable on scan Omar Sandoval
2024-07-15 10:04 ` [PATCH v2 5/5] debuginfod: populate _r_seekable on request Omar Sandoval
2024-07-16 20:16 ` [PATCH v2 0/5] debuginfod: speed up extraction from kernel debuginfo packages by 200x Frank Ch. Eigler
2024-07-16 21:15   ` Omar Sandoval [this message]
2024-07-16 22:15   ` Frank Ch. Eigler
2024-07-16 22:17     ` Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zpbi-VXYv7dmP_8H@telecaster.dhcp.thefacebook.com \
    --to=osandov@osandov.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=fche@redhat.com \
    --cc=linux-debuggers@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox