From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 618B236AF5 for ; Mon, 2 Sep 2024 03:05:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725246326; cv=none; b=I74ViT74KIkoSnqvCVR6Ru4kVLqeX92UmH5Hbjw05H+regDnBzsFmGGvBtDVDMQN1t1S4QIADX5QpkE7dybY4wrMDB+mba5oJ8IeF0i2NLvwY1vghxNElMSZIuIrCY5PhVqinr1qCoDJtJX1LPJUHMfiu1sNJNA+tUVlJ/mC/Ik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725246326; c=relaxed/simple; bh=SdBGx/046qIxw3N5LU0o7ilkNZVrzxdFOb6VXUgXw04=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h39czjDgY6+YWVmRAEEY/HmREDKmL09mArAGkInHSW2uTBBfCcpY7tD1t2LS1aYOl+oMbhf5gnkZ1lTnp4yg5GdezK9vMtUmHfOI+1S2L0oM0ue0XfhKZ+gpbo/A9ydI1dzf6yqv9FQ88ACiy8qmnAp9NNSp7ZbtMJWbmpLP+Vc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VSE8bPA5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VSE8bPA5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725246323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/wSjolqkdgtanP1gHe7DoyJjSl0u2RbxSmbePTYD+6I=; b=VSE8bPA5CMv2Ye1S1sNUNB8/VBX3vZrDiVLmjJCI1XR0Cayw5O8kVlkKT2JkLt/xoJKPgl 6HLPb/xupRzmTCVuOysE3ijqUkjlvdnm2QGrfNFsLxOrkuPfJbTNkyz/1U62Y3/2NwJwqN kQzEbu3CruSJ7/u6jQZZAjQWXQ2ufns= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-QtgqlzQbOqKpg5gH5i3qkw-1; Sun, 01 Sep 2024 23:05:18 -0400 X-MC-Unique: QtgqlzQbOqKpg5gH5i3qkw-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AE2E719560B0; Mon, 2 Sep 2024 03:05:15 +0000 (UTC) Received: from localhost (unknown [10.72.112.58]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B1A9919560AA; Mon, 2 Sep 2024 03:05:13 +0000 (UTC) Date: Mon, 2 Sep 2024 11:05:03 +0800 From: Baoquan He To: "Guilherme G. Piccoli" Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org, vgoyal@redhat.com, dyoung@redhat.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-debuggers@vger.kernel.org, stephen.s.brennan@oracle.com, kernel@gpiccoli.net, kernel-dev@igalia.com Subject: Re: [PATCH V2] Documentation: Improve crash_kexec_post_notifiers description Message-ID: References: <20240830182219.485065-1-gpiccoli@igalia.com> Precedence: bulk X-Mailing-List: linux-debuggers@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240830182219.485065-1-gpiccoli@igalia.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 08/30/24 at 03:21pm, Guilherme G. Piccoli wrote: > Be more clear about the downsides, the upsides (yes, there are some!) > and about code that unconditionally sets that. > > Reviewed-by: Stephen Brennan > Signed-off-by: Guilherme G. Piccoli > > --- > > V2: Some wording improvements from Stephen, thanks! > Also added his review tag. > > V1 link: https://lore.kernel.org/r/20240830140401.458542-1-gpiccoli@igalia.com/ > > > Documentation/admin-guide/kernel-parameters.txt | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index efc52ddc6864..351730108c58 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -913,12 +913,16 @@ > the parameter has no effect. > > crash_kexec_post_notifiers > - Run kdump after running panic-notifiers and dumping > - kmsg. This only for the users who doubt kdump always > - succeeds in any situation. > - Note that this also increases risks of kdump failure, > - because some panic notifiers can make the crashed > - kernel more unstable. > + Only jump to kdump kernel after running the panic > + notifiers and dumping kmsg. This option increases the > + risks of a kdump failure, since some panic notifiers > + can make the crashed kernel more unstable. In the > + configurations where kdump may not be reliable, > + running the panic notifiers can allow collecting more > + data on dmesg, like stack traces from other CPUS or > + extra data dumped by panic_print. Notice that some > + code enables this option unconditionally, like > + Hyper-V, PowerPC (fadump) and AMD SEV. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I know Hyper-V enable panic-notifiers by default, but don't remember how PowerPC and AMD SEC behave in this aspect. While at it, can you add a little more words to state them in log so that people can learn it? Thanks. > > crashkernel=size[KMG][@offset[KMG]] > [KNL,EARLY] Using kexec, Linux can switch to a 'crash kernel' > -- > 2.46.0 >