Re: [PATCH dwarves v4 0/4] Emit global variables in BTF

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Fri, Oct 04, 2024 at 10:26:24AM -0700, Stephen Brennan wrote:
> Hi all,
> 
> This is v4 of the series which adds global variables to pahole's generated BTF.
> 
> Since v3:
> 
> 1. Gathered Alan's Reviewed-by + Tested-by, and Jiri's Acked-by.
> 2. Consistently start shndx loops at 1, and use size_t.
> 3. Since patch 1 of v3 was already applied, I dropped it out of this series.
> 
> v3: https://lore.kernel.org/dwarves/20241002235253.487251-1-stephen.s.brennan@oracle.com/
> v2: https://lore.kernel.org/dwarves/20240920081903.13473-1-stephen.s.brennan@oracle.com/
> v1: https://lore.kernel.org/dwarves/20240912190827.230176-1-stephen.s.brennan@oracle.com/
> 
> Thanks everyone for your review, tests, and consideration!

Looks ok, I run the existing regression tests:

acme@x1:~/git/pahole$ tests/tests 
  1: Validation of BTF encoding of functions; this may take some time: Ok
  2: Pretty printing of files using DWARF type information: Ok
  3: Parallel reproducible DWARF Loading/Serial BTF encoding: Ok
/home/acme/git/pahole
acme@x1:~/git/pahole$

And now I'm building a kernel with clang + Thin LTO + Rust enabled in
the kernel to test other fixes I have merged and doing that with your
patch series.

Its all in the next branch and will move to master later today or
tomorrow when I finish the clang+LTO+Rust tests.

- Arnaldo

> Stephen
> 
> Stephen Brennan (4):
>   btf_encoder: stop indexing symbols for VARs
>   btf_encoder: explicitly check addr/size for u32 overflow
>   btf_encoder: allow encoding VARs from many sections
>   pahole: add global_var BTF feature
> 
>  btf_encoder.c      | 340 +++++++++++++++++++++------------------------
>  btf_encoder.h      |   1 +
>  dwarves.h          |   1 +
>  man-pages/pahole.1 |   7 +-
>  pahole.c           |   3 +-
>  5 files changed, 167 insertions(+), 185 deletions(-)
> 
> -- 
> 2.43.5