From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C96A322173D for ; Tue, 28 Oct 2025 16:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761667584; cv=none; b=WxJIQ/ROGUEmtbz9/izXbWlxDKhMClpfEjTDPhW8t8DRMgwpVAKpW8KagksInwjx5M9q2HkInHH83ywTFnFDHivL2G+gmUylH4d6rNphaB76UYDd7ppeibSWshLb/Pn/LSrTAoqc7cSh/mSTea76yQVqwqdxB4PWKM0AGcZ7Z88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761667584; c=relaxed/simple; bh=bmnmA73xpnPPZqC7UO0wa3cwBwtkXnIxlAxnUFLE84g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M6f8CQ25cXrDqB8k+Q5fvOJTNVpTZUWhoXyohZIKRqv9xxSxAX2OEQ/AokKljeJWs58Nji2w7FVFY4/p5FkuLp5fC0OTVMjqpCmQN2rnjGpcU42G7TDrF2/BPlnfowlXuRDZ7Ow2h8r3V14CeynxP/aSFrCI7uRIlkn3xllW5dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UTiZibmk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UTiZibmk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761667581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7fEiTV8vRb6ThfDpOr4lY+uCNfpmz0C8bm6VrusAPB8=; b=UTiZibmkm5RzAZ3gVfizXfzOh8awh32fTKvA0pK0ABGWCOcnszZ/EMwUHuMKeRaLB/UC2E t1rYlzVFfbMLoZrUxOqbTV2vmMgc16StNad1HRXaTgfZEqLC6xpaUfr75KND5NFOmSXODt VRQuIdJMMbtMjDWNeRBDY2Y7fqfbiqE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-WikFz_s0PkiVhLdElQGs2A-1; Tue, 28 Oct 2025 12:06:20 -0400 X-MC-Unique: WikFz_s0PkiVhLdElQGs2A-1 X-Mimecast-MFC-AGG-ID: WikFz_s0PkiVhLdElQGs2A_1761667579 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47106a388cfso36338535e9.0 for ; Tue, 28 Oct 2025 09:06:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761667579; x=1762272379; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7fEiTV8vRb6ThfDpOr4lY+uCNfpmz0C8bm6VrusAPB8=; b=Hu/woRpwvOPHiEXDXQ0YPQtRkNLXmXnHfbax4hud00mG6QaS9ojxgT2880hHBPtPJF MmAmn8dkA1XWuwCEC9mPQST3V0+l9Lqfol7Iq5EzuTkACVJ0wmPfXYZYR1HgcWKXJBRP eNJqZoJZ8JoW4dUbh6z7le+uHdv1u2Lsa09VYlrGzpcCCmS/FahPniwUMm/F/JFHTqk4 rfoZuDcKIMTL2Y+dg4AeSK0QKyXjrnBxLuk1v6I8XKjajnHKdxkXudCzEVUGv7yYgFu3 QhOaa+yRO71Dft+4nlt+frWu2jk2wAL/vtPVowkr8mCKqUfy7D+vcVEQDj/Xv9kCjk1S 4wsw== X-Forwarded-Encrypted: i=1; AJvYcCUgnLqeAWCSBEluBrZnvdZuW1VBYXgly6VObDynT9kKeDdGx+QdeE4FigZWjogRzjPLFNmibosoLISOh0YDwwg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywik4UIJHxeys6Krg0Z+favlUh7gumKmb58s9sxBdJcfM7cJO2c hYVIJJz0R/ok5JkbflfoN6ADU+8tPB59U6R4w7VCry9En65egokHVxh4burlE2pHjQrj/9Fdd0q 1CEnHgxrnx/RvKkRoK0tipaJt4VrmAZTZDlsRlXKvmrI3bKgwaoidsSZQaym9k1mfFrBjUg== X-Gm-Gg: ASbGncujMSRmVaOwVy1LK6MZa+ViCUOFDmKYNgryyS/sgjdzQyygVv+WF/PcCcNYwMJ UuxKnpyhpQPJT7Hpl/fMBeX5t9PKraIxBUQAL0B6YOmras+iqJY805bcaIBNTcUoBFGNKscvq05 jWwCfUBICgKbOdiTfviUpNYe0Tu8BZorOfX3VeXbfZft3jX6PfpFFyk+OdbKMDef/JteJJ8vZnR cO+fjd6sIZncL7uBHT3P6j7F2zLI/elPjXxTABvuneUScPb7a9KVs7aJ5iq9NVamdNV8S3she8A 66ogBjNDD6cJEnbk0Mu1V8PwEb1k7jfJ+rxjbryCMYmGKVKHhg6NYZ9KXwYeapFzlDoiZEjR5go iJrl9IfP/sRMcihPWDdMz/DJSMmHQPVGh X-Received: by 2002:a05:600c:3510:b0:46f:b42e:e394 with SMTP id 5b1f17b1804b1-47717e7a904mr28298545e9.41.1761667579328; Tue, 28 Oct 2025 09:06:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXT5BB0dlLpX7heAZB79STVaY/doPErnydPItM+XhQvOUsNw5gcKnIBB8PLR6EDjE/Vkd2kw== X-Received: by 2002:a05:600c:3510:b0:46f:b42e:e394 with SMTP id 5b1f17b1804b1-47717e7a904mr28298285e9.41.1761667578841; Tue, 28 Oct 2025 09:06:18 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475dd4a36easm204397805e9.10.2025.10.28.09.06.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Oct 2025 09:06:18 -0700 (PDT) Message-ID: Date: Tue, 28 Oct 2025 17:06:17 +0100 Precedence: bulk X-Mailing-List: linux-debuggers@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Convert memory block states (MEM_*) macros to enum To: Omar Sandoval , Lorenzo Stoakes Cc: Israel Batista , akpm@linux-foundation.org, linux-mm@kvack.org, linux-debuggers@vger.kernel.org References: <20251026162156.12141-1-linux@israelbatista.dev.br> <811fd675-b231-45e4-b9d5-636fe63bde6b@redhat.com> <3d3bfa52-3e13-4d23-8ef7-6cb8b1ab7d79@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: V0KpB7yy0nZ0ygJ526Y5QZmL1Q2u8sDz26A2eJD-de0_1761667579 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > I read > https://lore.kernel.org/all/809f552d-3282-4746-ba49-066d2bd8d44f@lucifer.local/ > ("it's not valid to have flag values as an enum") as a claim that this > was invalid at the language level, but it sounds like your objection is > more of a personal style preference. Which is totally fine, the MM > subsystem can have whatever rules it wants. > > To play devil's advocate, using a named enum for flags makes it easy to > document what flags are used for a given field A current best practice for flags is to use a __bitwise typedef. That way, sparse will be able to make sure that people are not using other random values. We don't make use of that everywhere yet, of course. FOLL_ flags are still wrapped in an enum, for example. -- Cheers David / dhildenb