From: Seungwon Jeon <tgih.jun@samsung.com>
To: dinguyen@altera.com, linux-mmc@vger.kernel.org
Cc: dinh.linux@gmail.com, devicetree@vger.kernel.org,
'Rob Herring' <robh+dt@kernel.org>,
'Pawel Moll' <pawel.moll@arm.com>,
'Mark Rutland' <mark.rutland@arm.com>,
'Ian Campbell' <ijc+devicetree@hellion.org.uk>,
'Kumar Gala' <galak@codeaurora.org>,
'Jaehoon Chung' <jh80.chung@samsung.com>,
'Chris Ball' <chris@printf.net>
Subject: RE: [PATCHv3 2/3] mmc: dw_mmc: Add support for SOCFPGA's platform specific implementation
Date: Tue, 18 Feb 2014 23:02:21 +0900 [thread overview]
Message-ID: <000001cf2cb2$0b787c00$22697400$%jun@samsung.com> (raw)
In-Reply-To: <1392690662-19106-2-git-send-email-dinguyen@altera.com>
On Tue, February 18, 2014, Dinh Nguyen wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> Like the rockchip, Altera's SOCFPGA platform specific implementation of the
> dw_mmc driver requires using the HOLD register for SD commands. This patch
> renames dw_mci_rockchip_prepare_command to dw_mci_pltfm_prepare_command so
> that SOCFPGA and Rockchip can use it.
>
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Tested-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Seungwon Jeon <tgih.jun@samsung.com>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Thanks,
Seungwon Jeon
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Chris Ball <chris@printf.net>
> ---
> v3: Renamed dw_mci_rockchip_prepare_command to
> dw_mci_pltfm_prepare_command
> v2: Use dw_mci_socfpga_prepare_command instead of
> dw_mci_rockchip_prepare_command
> ---
> drivers/mmc/host/dw_mmc-pltfm.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/host/dw_mmc-pltfm.c
> index 5c49656..3263327 100644
> --- a/drivers/mmc/host/dw_mmc-pltfm.c
> +++ b/drivers/mmc/host/dw_mmc-pltfm.c
> @@ -25,13 +25,17 @@
> #include "dw_mmc.h"
> #include "dw_mmc-pltfm.h"
>
> -static void dw_mci_rockchip_prepare_command(struct dw_mci *host, u32 *cmdr)
> +static void dw_mci_pltfm_prepare_command(struct dw_mci *host, u32 *cmdr)
> {
> *cmdr |= SDMMC_CMD_USE_HOLD_REG;
> }
>
> static const struct dw_mci_drv_data rockchip_drv_data = {
> - .prepare_command = dw_mci_rockchip_prepare_command,
> + .prepare_command = dw_mci_pltfm_prepare_command,
> +};
> +
> +static const struct dw_mci_drv_data socfpga_drv_data = {
> + .prepare_command = dw_mci_pltfm_prepare_command,
> };
>
> int dw_mci_pltfm_register(struct platform_device *pdev,
> @@ -92,6 +96,8 @@ static const struct of_device_id dw_mci_pltfm_match[] = {
> { .compatible = "snps,dw-mshc", },
> { .compatible = "rockchip,rk2928-dw-mshc",
> .data = &rockchip_drv_data },
> + { .compatible = "altr,socfpga-dw-mshc",
> + .data = &socfpga_drv_data },
> {},
> };
> MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-18 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 2:31 [PATCHv3 1/3] mmc: dw_mmc-socfpga: Remove the SOCFPGA specific platform for dw_mmc dinguyen
2014-02-18 2:31 ` [PATCHv3 2/3] mmc: dw_mmc: Add support for SOCFPGA's platform specific implementation dinguyen
2014-02-18 14:02 ` Seungwon Jeon [this message]
2014-02-18 2:31 ` [PATCHv3 3/3] dts: socfpga: Add support for SD/MMC on the SOCFPGA platform dinguyen
2014-02-18 14:09 ` [PATCHv3 1/3] mmc: dw_mmc-socfpga: Remove the SOCFPGA specific platform for dw_mmc Seungwon Jeon
2014-02-25 16:58 ` Dinh Nguyen
2014-02-27 2:32 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cf2cb2$0b787c00$22697400$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=chris@printf.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=dinh.linux@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).