From: Jonghwan Choi <jhbird.choi@samsung.com>
To: 'Tomasz Figa' <tomasz.figa@gmail.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
cpufreq@vger.kernel.org
Cc: 'Kukjin Kim' <kgene.kim@samsung.com>,
"'Rafael J. Wysocki'" <rjw@sisk.pl>,
'Jonghwan Choi' <jhbird.choi@gmail.com>,
'Viresh Kumar' <viresh.kumar@linaro.org>
Subject: RE: [PATCH v2] cpufreq: exynos: Fix the compile error
Date: Fri, 16 May 2014 18:57:38 +0900 [thread overview]
Message-ID: <000001cf70ed$451bbec0$cf533c40$@samsung.com> (raw)
In-Reply-To: <5375D150.1020109@gmail.com>
On 16.05.2014 5:50 PM, Tomasz Figa wrote:
> We have been discussing Exynos cpufreq framework rework, including DT support since quite a long time.
> so if you want to know details, please look at respective discussion threads. I don't have time to
> find them for you right now, but if you look for threads of cpufreq patches by Thomas Abraham and ones
> about Exynos multiplatform support, then you should have quite complete set of information.
>
I will check that.
> In general, I can see three ways to "fix" this for 3.15:
>
> 1) revert moving soc_is_* macros to mach-exynos/common.h,
>
> 2) move soc_is_* macros to a header in mach-exynos/include/mach/,
>
> 3) use of_machine_is_compatible() or of_match_node() on root node in this driver to match directly
> with SoC compatible strings.
>
> Probably option 3) would be preferred, as it would remove some of the dependencies of this driver on
> arch code and including plat/cpu.h (or mach/cpu.h as would be introduced by 2)) would be no longer
> necessary.
Thanks~
Best Regards.
prev parent reply other threads:[~2014-05-16 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 7:58 [PATCH v2] cpufreq: exynos: Fix the compile error Jonghwan Choi
2014-05-16 8:50 ` Tomasz Figa
2014-05-16 9:57 ` Jonghwan Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cf70ed$451bbec0$cf533c40$@samsung.com' \
--to=jhbird.choi@samsung.com \
--cc=cpufreq@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jhbird.choi@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tomasz.figa@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).