From: "Keiji Hayashibara" <hayashibara.keiji-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
To: "Yamada,
Masahiro/山田 真弘"
<yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
Cc: wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org,
"Guenter Roeck" <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Linux Kernel Mailing List"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Masami Hiramatsu"
<masami.hiramatsu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Jassi Brar"
<jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Hayashi,
Kunihiko/林 邦彦"
<hayashi.kunihiko-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>,
"Owada,
Kiyoshi/大和田 清志"
<owada.kiyoshi-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
Subject: RE: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver
Date: Thu, 8 Jun 2017 14:51:21 +0900 [thread overview]
Message-ID: <000001d2e01b$41b00840$c51018c0$@socionext.com> (raw)
In-Reply-To: <CAK7LNARQb3r7fvytCZ86G3iQBpWhu7-06DY9gcJswjH0heUonA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hello Yamada-san,
> > +
> > +#include <linux/module.h>
> > +#include <linux/mfd/syscon.h>
> > +#include <linux/of.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/regmap.h>
> > +#include <linux/watchdog.h>
> > +#include <linux/bitops.h>
>
> I think you should have added <linux/bitops.h> on the top
> to keep the includes alphabetically sorted.
Sorry, I will fix in v3 patch.
----------
Best Regards,
Keiji Hayashibara
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-08 5:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 9:11 [PATCH V2 0/3] add UniPhier watchdog support Keiji Hayashibara
[not found] ` <1496740294-12653-1-git-send-email-hayashibara.keiji-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2017-06-06 9:11 ` [PATCH V2 1/3] devicetree: add UniPhier WDT devicetree bindings documentation Keiji Hayashibara
[not found] ` <1496740294-12653-2-git-send-email-hayashibara.keiji-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2017-06-08 2:11 ` Masahiro Yamada
[not found] ` <CAK7LNATMRPW3PYU-fX+biRdez-mgkUKRbVi+w+dBNb3szOuXdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-08 6:22 ` Keiji Hayashibara
2017-06-06 9:11 ` [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver Keiji Hayashibara
[not found] ` <1496740294-12653-3-git-send-email-hayashibara.keiji-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2017-06-08 2:09 ` Masahiro Yamada
[not found] ` <CAK7LNARQb3r7fvytCZ86G3iQBpWhu7-06DY9gcJswjH0heUonA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-08 5:51 ` Keiji Hayashibara [this message]
2017-06-08 12:31 ` Guenter Roeck
[not found] ` <248751ac-f1db-84d2-05ad-e2a9aed34373-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2017-06-09 10:22 ` Keiji Hayashibara
2017-06-06 9:11 ` [PATCH V2 3/3] arm64: dts: uniphier: add watchdog node for LD11 and LD20 Keiji Hayashibara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d2e01b$41b00840$c51018c0$@socionext.com' \
--to=hayashibara.keiji-uwylwvc0a2jby3ivrkzq2a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hayashi.kunihiko-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org \
--cc=jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=masami.hiramatsu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=owada.kiyoshi-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org \
--cc=yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).