From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C7FC35247 for ; Tue, 4 Feb 2020 16:37:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37D222084E for ; Tue, 4 Feb 2020 16:37:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="SUoOU5mT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727390AbgBDQhO (ORCPT ); Tue, 4 Feb 2020 11:37:14 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:44962 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727296AbgBDQhO (ORCPT ); Tue, 4 Feb 2020 11:37:14 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1580834233; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Sender; bh=agoXjFrnTmxkOUbSigXOO4ODx6+TcOAJBzPUjhLzlBM=; b=SUoOU5mTsMhPW8AwhyPrsA2qT6shwOKHiwxuuG8peY2dK3x8TGuDpNN5tgPlSMYpt/slYDQc bvLGAamD32nssag1hcTMCV42DBidq4dKIqblmWpKbWZDpStU/t8hGTuK7R5MQlmhVLMl2zz5 AfV7mwZQGvIKiTSWUhmIr0RylRA= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e399db6.7fd838397030-smtp-out-n03; Tue, 04 Feb 2020 16:37:10 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3EFD8C447A1; Tue, 4 Feb 2020 16:37:09 +0000 (UTC) Received: from Pillair (unknown [183.83.68.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: pillair) by smtp.codeaurora.org (Postfix) with ESMTPSA id 68156C43383; Tue, 4 Feb 2020 16:37:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 68156C43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=pillair@codeaurora.org From: To: "'Bjorn Andersson'" Cc: , , , References: <1580281223-2759-1-git-send-email-pillair@codeaurora.org> <20200203173500.GB3948@builder> In-Reply-To: <20200203173500.GB3948@builder> Subject: RE: [PATCH v5] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Date: Tue, 4 Feb 2020 22:07:02 +0530 Message-ID: <000001d5db79$5814edb0$083ec910$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHPh76zXXDoz9WIzFQCmi0NWmaUmALbmOLiqAEGNCA= Content-Language: en-us Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Bjorn, I have addressed your comments and sent out the v6 for this patch. Thanks, Rakesh Pillai. > -----Original Message----- > From: Bjorn Andersson > Sent: Monday, February 3, 2020 11:05 PM > To: Rakesh Pillai > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org > Subject: Re: [PATCH v5] arm64: dts: qcom: sc7180: Add WCN3990 WLAN > module device node > > On Tue 28 Jan 23:00 PST 2020, Rakesh Pillai wrote: > > > Add device node for the ath10k SNOC platform driver probe > > and add resources required for WCN3990 on sc7180 soc. > > > > Signed-off-by: Rakesh Pillai > > --- > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++ > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 > ++++++++++++++++++++++++++++ > > 2 files changed, 33 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > index 388f50a..167f68ac 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > @@ -287,6 +287,11 @@ > > vdda-pll-supply = <&vreg_l4a_0p8>; > > }; > > > > +&wifi { > > + status = "okay"; > > + qcom,msa-fixed-perm; > > +}; > > + > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > &qspi_clk { > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index 8011c5f..0a00c94 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -75,6 +75,12 @@ > > reg = <0x0 0x80900000 0x0 0x200000>; > > no-map; > > }; > > + > > + wlan_fw_mem: memory@93900000 { > > + compatible = "removed-dma-pool"; > > Sorry for not spotting this earlier, the "removed-dma-pool" compatible > is a downstream thing and isn't defined upstream. > > > + no-map; > > + reg = <0 0x93900000 0 0x200000>; > > If you swap the order of no-map and reg in this node it will look like > all the others. > > > Apart from that the patch looks good. > > Regards, > Bjorn > > > + }; > > }; > > > > cpus { > > @@ -1490,6 +1496,28 @@ > > > > #freq-domain-cells = <1>; > > }; > > + > > + wifi: wifi@18800000 { > > + compatible = "qcom,wcn3990-wifi"; > > + reg = <0 0x18800000 0 0x800000>; > > + reg-names = "membase"; > > + iommus = <&apps_smmu 0xc0 0x1>; > > + interrupts = > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */>, > > + */>; > > + memory-region = <&wlan_fw_mem>; > > + status = "disabled"; > > + }; > > }; > > > > thermal-zones { > > -- > > 2.7.4 > >