From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E34C433B4 for ; Fri, 9 Apr 2021 07:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40BBF61182 for ; Fri, 9 Apr 2021 07:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229621AbhDIHfL (ORCPT ); Fri, 9 Apr 2021 03:35:11 -0400 Received: from mga18.intel.com ([134.134.136.126]:39752 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbhDIHfL (ORCPT ); Fri, 9 Apr 2021 03:35:11 -0400 IronPort-SDR: w4Z7OtXSrAsudeIJ741xRiNlmynv7toYzF/PLrUtKLM4nIHir95Nmz7DooZMVMe9ik3jchgglN p4cnOUq5tqyQ== X-IronPort-AV: E=McAfee;i="6000,8403,9948"; a="181244031" X-IronPort-AV: E=Sophos;i="5.82,208,1613462400"; d="scan'208";a="181244031" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2021 00:34:58 -0700 IronPort-SDR: /zuUZRZGg0ELsnVV8P09wAtAwUOqlmqsakb0GtFSfvjndZWuK8y0n0T+Up6qT0lQ0Rcehz6oie a1mK579ikwHA== X-IronPort-AV: E=Sophos;i="5.82,208,1613462400"; d="scan'208";a="422617172" Received: from msaitovx-mobl.ger.corp.intel.com (HELO mkrastexMOBL) ([10.104.88.16]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2021 00:34:56 -0700 From: "Martina Krasteva" To: "'Rob Herring'" Cc: , , , , , , References: <20210330142023.141-1-martinax.krasteva@linux.intel.com> <20210330142023.141-2-martinax.krasteva@linux.intel.com> <20210407223512.GA140520@robh.at.kernel.org> In-Reply-To: <20210407223512.GA140520@robh.at.kernel.org> Subject: RE: [PATCH 1/6] dt-bindings: media: Add bindings for imx335 Date: Fri, 9 Apr 2021 08:34:53 +0100 Message-ID: <000001d72d12$d7bce0e0$8736a2a0$@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQMGgl+zuelOrAO8/f9lWDH85rRoUgGTN1eBAM2EUW2oOhqugA== Content-Language: en-us dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, Thank you for the review > > On Tue, Mar 30, 2021 at 03:20:18PM +0100, Martina Krasteva wrote: > > From: Martina Krasteva > > > > - Add dt-bindings documentation for Sony imx335 sensor driver > > - Add MAINTAINERS entry for Sony imx335 binding documentation > > > > Signed-off-by: Martina Krasteva > > Acked-by: Daniele Alessandrelli > > Acked-by: Paul J. Murphy > > --- > > .../devicetree/bindings/media/i2c/sony,imx335.yaml | 90 > ++++++++++++++++++++++ > > MAINTAINERS | 8 ++ > > 2 files changed, 98 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > > b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > > new file mode 100644 > > index 000000000000..0e286226ad9b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > > @@ -0,0 +1,90 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright > > +(C) 2021 Intel Corporation %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/sony,imx335.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sony IMX335 Sensor > > + > > +maintainers: > > + - Paul J. Murphy > > + - Daniele Alessandrelli > > + > > +description: > > + IMX335 sensor is a Sony CMOS active pixel digital image sensor with > > +an active > > + array size of 2592H x 1944V. It is programmable through I2C > > +interface. The > > + I2C client address is fixed to 0x1a as per sensor data sheet. Image > > +data is > > + sent through MIPI CSI-2. > > + > > +properties: > > + compatible: > > + const: sony,imx335 > > + reg: > > + description: I2C address > > + maxItems: 1 > > + > > + assigned-clocks: true > > + assigned-clock-parents: true > > + assigned-clock-rates: true > > + > > + clocks: > > + description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz > > + maxItems: 1 > > + > > + reset-gpios: > > + description: Reference to the GPIO connected to the XCLR pin, if any. > > Missed one thing. You need 'maxItems: 1' to define how many gpios. > Will be added in next version :) > > + > > + port: > > + additionalProperties: false > > + $ref: /schemas/graph.yaml#/properties/port > > + > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: true > > + link-frequencies: true > > + > > + required: > > + - data-lanes > > + - link-frequencies > > + > > + required: > > + - endpoint > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - port > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + camera@1a { > > + compatible = "sony,imx335"; > > + reg = <0x1a>; > > + clocks = <&imx335_clk>; > > + > > + assigned-clocks = <&imx335_clk>; > > + assigned-clock-parents = <&imx335_clk_parent>; > > + assigned-clock-rates = <24000000>; > > + > > + port { > > + imx335: endpoint { > > + remote-endpoint = <&cam>; > > + data-lanes = <1 2 3 4>; > > + link-frequencies = /bits/ 64 <594000000>; > > + }; > > + }; > > + }; > > + }; > > +... > > diff --git a/MAINTAINERS b/MAINTAINERS index > > cd988b258fe0..510e3c4a45b6 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -16875,6 +16875,14 @@ T: git git://linuxtv.org/media_tree.git > > F: Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > F: drivers/media/i2c/imx334.c > > > > +SONY IMX335 SENSOR DRIVER > > +M: Paul J. Murphy > > +M: Daniele Alessandrelli > > +L: linux-media@vger.kernel.org > > +S: Maintained > > +T: git git://linuxtv.org/media_tree.git > > +F: Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml > > + > > SONY IMX355 SENSOR DRIVER > > M: Tianshu Qiu > > L: linux-media@vger.kernel.org > > -- > > 2.11.0 > > Best Regards, Martina