RE: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support

["Alim Akhtar" <alim.akhtar@samsung.com>]

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Wednesday, January 19, 2022 12:01 AM
>To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>kernel@lists.infradead.org; linux-kernel@vger.kernel.org
>Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org;
>olof@lixom.net; arnd@arndb.de; linus.walleij@linaro.org;
>catalin.marinas@arm.com; robh+dt@kernel.org; s.nawrocki@samsung.com;
>linux-samsung-soc@vger.kernel.org; pankaj.dubey@samsung.com; linux-
>fsd@tesla.com; Jayati Sahu <jayati.sahu@samsung.com>; Ajay Kumar
><ajaykumar.rs@samsung.com>
>Subject: Re: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support
>
>On 18/01/2022 15:48, Alim Akhtar wrote:
>> Add initial clock support for FSD (Full Self-Driving) SoC which is
>> required to bring-up platforms based on this SoC.
>>
>> Cc: linux-fsd@tesla.com
>> Signed-off-by: Jayati Sahu <jayati.sahu@samsung.com>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>>  drivers/clk/samsung/Kconfig   |   7 +
>>  drivers/clk/samsung/Makefile  |   1 +
>>  drivers/clk/samsung/clk-fsd.c | 308
>++++++++++++++++++++++++++++++++++
>>  drivers/clk/samsung/clk-pll.c |   1 +
>>  drivers/clk/samsung/clk-pll.h |   1 +
>>  5 files changed, 318 insertions(+)
>>  create mode 100644 drivers/clk/samsung/clk-fsd.c
>>
>> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
>> index 0e18d6ff2916..11587eb87fc4 100644
>> --- a/drivers/clk/samsung/Kconfig
>> +++ b/drivers/clk/samsung/Kconfig
>> @@ -124,3 +124,10 @@ config S3C2443_COMMON_CLK
>>  	help
>>  	  Support for the clock controller present on the Samsung
>>  	  S3C2416/S3C2443 SoCs. Choose Y here only if you build for this SoC.
>> +
>> +config TESLA_FSD_COMMON_CLK
>> +	bool "Tesla FSD clock controller support" if COMPILE_TEST
>> +	depends on COMMON_CLK_SAMSUNG
>> +	help
>> +	  Support for the clock controller present on the Tesla FSD SoC.
>> +	  Choose Y here only if you build for this SoC.
>
>The clock drivers Kconfig is organized in a way, that platform should select only
>COMMON_CLK_SAMSUNG (first comment in a file), so let's keep it consistent
>also for FSD. "select TESLA_FSD_COMMON_CLK if ARM64 &&
>ARCH_TESLA_FSD" and skip the select in Kconfig.platform in following patch.
>
Thanks Krzysztof for a quick review.
Will incorporate above in the next set.

>
>Best regards,
>Krzysztof