RE: [PATCH 2/2] arm64: dts: fsd: add sysreg device node

["Sriranjani P" <sriranjani.p@samsung.com>]

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 21 November 2022 17:58
> To: Sriranjani P <sriranjani.p@samsung.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; lee@kernel.org;
> devicetree@vger.kernel.org; alim.akhtar@samsung.com;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node
> 
> On 21/11/2022 10:11, Sriranjani P wrote:
> > Add SYSREG controller device node, which is available in PERIC, FSYS0
> > and
> > FSYS1 block of FSD SoC.
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> > ---
> >  arch/arm64/boot/dts/tesla/fsd.dtsi | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > index f35bc5a288c2..db78816ba0bf 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > @@ -518,6 +518,21 @@
> >  				"dout_cmu_fsys1_shared0div4";
> >  		};
> >
> > +		sysreg_peric: syscon@14030000 {
> 
> Node name system-controller
[Sriranjani P] Will fix it in the next version. We added “syscon” since I referred other dtsi files in mainline for example exynosautov9.dtsi used syscon as node name. If this is the name we should add then I’ll post few more patches fixing this node name in other Exynos dtsi files.
> and either put it next to existing one or next to functional block (peric
> clocks?) ordered by unit address.
[Sriranjani P] We thought of it but as I saw current fsd.dtsi file and other exynos file like exynosautov9.dtsi, in that nodes are not properly arranged as per unit address.

So I can think of following two approaches: 
1: For the time being I will put this sysreg node in between clock_peric node and clock_fysys0 node and clock_fsys1 node as per increasing unit address. I will clean up other exynos and FSD DTSI files and post a new patch 
2: First I will clean up exynos and FSD DTSI files and then post this sysreg patch keeping it at appropriate place. 

Please let me know which way it will be more appropriate.
> 
> > +			compatible = "tesla,fsd-sysreg", "syscon";
> > +			reg = <0x0 0x14030000 0x0 0x1000>;
> > +		};
> 
> Best regards,
> Krzysztof
[Sriranjani P] Thank you for reviewing the patch.