devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pritam Manohar Sutar" <pritam.sutar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>, <vkoul@kernel.org>,
	<kishon@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <alim.akhtar@samsung.com>,
	<andre.draszik@linaro.org>, <peter.griffin@linaro.org>,
	<kauschluss@disroot.org>, <ivo.ivanov.ivanov1@gmail.com>,
	<igor.belwon@mentallysanemainliners.org>,
	<m.szyprowski@samsung.com>, <s.nawrocki@samsung.com>
Cc: <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>, <rosa.pila@samsung.com>,
	<dev.tailor@samsung.com>, <faraz.ata@samsung.com>,
	<muhammed.ali@samsung.com>, <selvarasu.g@samsung.com>
Subject: RE: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible
Date: Wed, 8 Oct 2025 10:15:27 +0530	[thread overview]
Message-ID: <000001dc380e$612b5680$23820380$@samsung.com> (raw)
In-Reply-To: <808d166a-b615-49c6-b0f5-bf5101721381@kernel.org>

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 07 October 2025 11:54 AM
> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; vkoul@kernel.org;
> kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; alim.akhtar@samsung.com; andre.draszik@linaro.org;
> peter.griffin@linaro.org; kauschluss@disroot.org;
> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org;
> m.szyprowski@samsung.com; s.nawrocki@samsung.com
> Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-
> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com;
> faraz.ata@samsung.com; muhammed.ali@samsung.com;
> selvarasu.g@samsung.com
> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
> ExynosAutov920 HS phy compatible
> 
> On 22/09/2025 14:26, Pritam Manohar Sutar wrote:
> > This phy needs 0.75v, 0.18v and 3.3v supplies for its internal
> > functionally. Power Supply's names are as per phy's User Data-Book.
> > These names, (dvdd, vdd18 and vdd33), are considered  for 0.75v, 1.8v
> > and 3.3v respectively.
> > "
> >
> >>
> >> I still cannot find constraints for the rest of properties, though.
> >
> > Sorry I didn't get it completely. Can you please elaborate on the same?
> 
> 
> Writing bindings and introductory talks elaborate on that. You add properties
> without constraints. That's not what we want. We want constraints.
> 

Have added only supplies in this patch-set. However, was going 
through schema example and it says nothing is needed to define
in terms of supply. 

ref: 
1. Documentation/devicetree/bindings/writing-schema.rst +151

... A "description" property is always required.

2. Documentation/devicetree/bindings/example-schema.yaml +135

# *-supply is always a single phandle, so nothing more to define.
foo-supply: true

Please confirm and let me know if your expectations are something 
else in terms of constraints of the properties.

> 
> Best regards,
> Krzysztof

Thank you,

Regards,
Pritam


  reply	other threads:[~2025-10-08  4:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250903072932epcas5p4dc5b5ada87f09f6f0c4e1b750874fc85@epcas5p4.samsung.com>
2025-09-03  7:38 ` [PATCH v8 0/6] initial usbdrd phy support for Exynosautov920 soc Pritam Manohar Sutar
     [not found]   ` <CGME20250903072936epcas5p4a28d0e63c7f0792b516b0cbc68bf3a8e@epcas5p4.samsung.com>
2025-09-03  7:38     ` [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible Pritam Manohar Sutar
2025-09-04  6:48       ` Krzysztof Kozlowski
2025-09-04  7:51         ` Pritam Manohar Sutar
2025-09-04  9:42           ` Krzysztof Kozlowski
2025-09-04 10:21             ` Pritam Manohar Sutar
2025-09-18  2:43               ` Krzysztof Kozlowski
2025-09-18 11:49                 ` Pritam Manohar Sutar
2025-09-17  7:07             ` Pritam Manohar Sutar
2025-09-18  2:44       ` Krzysztof Kozlowski
2025-09-18 11:55         ` Pritam Manohar Sutar
2025-09-19  0:29           ` Krzysztof Kozlowski
2025-09-22  5:26             ` Pritam Manohar Sutar
2025-10-07  6:23               ` Krzysztof Kozlowski
2025-10-08  4:45                 ` Pritam Manohar Sutar [this message]
2025-10-08  8:12                   ` Krzysztof Kozlowski
2025-10-08 11:43                     ` Pritam Manohar Sutar
2025-09-29  6:45       ` Alim Akhtar
2025-10-06  7:55         ` Pritam Manohar Sutar
     [not found]   ` <CGME20250903072939epcas5p4b36818cd2e2b5c59fdd4a1b90579eb47@epcas5p4.samsung.com>
2025-09-03  7:38     ` [PATCH v8 2/6] phy: exynos5-usbdrd: support HS phy for ExynosAutov920 Pritam Manohar Sutar
2025-09-29  6:46       ` Alim Akhtar
     [not found]   ` <CGME20250903072942epcas5p2154a85b45152af50e2714248c38c5adc@epcas5p2.samsung.com>
2025-09-03  7:38     ` [PATCH v8 3/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo hsphy Pritam Manohar Sutar
2025-09-29  6:46       ` Alim Akhtar
     [not found]   ` <CGME20250903072946epcas5p371f7d0e15d8757f738c08f80a8eefb60@epcas5p3.samsung.com>
2025-09-03  7:38     ` [PATCH v8 4/6] phy: exynos5-usbdrd: support HS combo phy for ExynosAutov920 Pritam Manohar Sutar
2025-09-29  6:48       ` Alim Akhtar
     [not found]   ` <CGME20250903072949epcas5p11a1e474fad83ff3036be2c443ed5bc35@epcas5p1.samsung.com>
2025-09-03  7:38     ` [PATCH v8 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy Pritam Manohar Sutar
2025-09-29  6:49       ` Alim Akhtar
     [not found]   ` <CGME20250903072952epcas5p38eaa34521236ad10d963783137748069@epcas5p3.samsung.com>
2025-09-03  7:38     ` [PATCH v8 6/6] phy: exynos5-usbdrd: support SS combo phy for ExynosAutov920 Pritam Manohar Sutar
2025-09-29  6:49       ` Alim Akhtar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001dc380e$612b5680$23820380$@samsung.com' \
    --to=pritam.sutar@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=dev.tailor@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=faraz.ata@samsung.com \
    --cc=igor.belwon@mentallysanemainliners.org \
    --cc=ivo.ivanov.ivanov1@gmail.com \
    --cc=kauschluss@disroot.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=muhammed.ali@samsung.com \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=rosa.pila@samsung.com \
    --cc=s.nawrocki@samsung.com \
    --cc=selvarasu.g@samsung.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).