From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE928385536 for ; Wed, 4 Mar 2026 07:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772610409; cv=none; b=KK1BoaNMsLUdyeZ6B9swB36kDcOqdW/85lBN6wOq60wBodLvtY66O2O1777ZaUoA1yqopPU+My7sFrCtBP0wOscK9AFJdYqnjscllOhBxD8exnkMU53hv+6FmN1Jvqc9x9AcK3XB6eM5LQhSMCaEP05ZBTR9uuMhTUIAmKpQscI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772610409; c=relaxed/simple; bh=ZgkidBpLL8oWBDBcLOBpxRD9Rfn2XlNJpVDOX2q6dmk=; h=From:To:Cc:In-Reply-To:Subject:Date:Message-ID:MIME-Version: Content-Type:References; b=e4f6WQFbgEAfLoziVIx2UZG+TGA8QQXqz2P6MhIJKCdcJRaukgqEJDt5Ko6t0i2L5mXsem5kW435VYHHCBrRdC90I86fR2on+NOPMHfMKu6Px5D2mTosxgMxUWEOeU/WdaGLvn0JzhE18I+canLpLdWqrZNIZ939KM9p8XbIv9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=pXBvI9b4; arc=none smtp.client-ip=203.254.224.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="pXBvI9b4" Received: from epcas5p4.samsung.com (unknown [182.195.41.42]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20260304074642epoutp02e04739fb2036dffd8900913c16287abb~Zk8TpZxlN2329523295epoutp02M for ; Wed, 4 Mar 2026 07:46:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20260304074642epoutp02e04739fb2036dffd8900913c16287abb~Zk8TpZxlN2329523295epoutp02M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1772610402; bh=kOSxfB+UsOuozAKdJYcd03wV8YPEdksJx4QCQmr+or8=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=pXBvI9b4K3VDKV1w2jS/GCWc6tbiKJBYMJ5bufAoYj6dWJ4F6WxxFZr4Go8uCpyg4 2iuIFnprpBNiZRU/adQqSSVFCSi33gcfrQo4V+Kl0Di/ZllKUREBi1e6Tg8sHd1H43 AA8uCwt+YpxmfH6rJ67XgHD/4CBHro7SrHNdnPfg= Received: from epsnrtp01.localdomain (unknown [182.195.42.153]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPS id 20260304074640epcas5p36b26a45cf9acf580c7c717f5998248ed~Zk8SFl5eK0732507325epcas5p3R; Wed, 4 Mar 2026 07:46:40 +0000 (GMT) Received: from epcas5p3.samsung.com (unknown [182.195.38.89]) by epsnrtp01.localdomain (Postfix) with ESMTP id 4fQl9W4R4Sz6B9m7; Wed, 4 Mar 2026 07:46:39 +0000 (GMT) Received: from epsmtip2.samsung.com (unknown [182.195.34.31]) by epcas5p2.samsung.com (KnoxPortal) with ESMTPA id 20260304074638epcas5p23e2fddcfdad2ac7eaff71907d902f706~Zk8QW3l0b0808608086epcas5p29; Wed, 4 Mar 2026 07:46:38 +0000 (GMT) Received: from INBRO007194 (unknown [107.122.3.105]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260304074636epsmtip2d413503c49f5f56dc235c3bf9bc61751~Zk8N9uXGh0539805398epsmtip2V; Wed, 4 Mar 2026 07:46:36 +0000 (GMT) From: To: "'Krzysztof Kozlowski'" , , , , Cc: , , , , , , , , In-Reply-To: Subject: RE: [PATCH v2 2/3] arm64: dts: exynos: ExynosAutov920: Add regulators for the USB Date: Wed, 4 Mar 2026 13:16:34 +0530 Message-ID: <000001dcabab$089a75d0$19cf6170$@samsung.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEa27yOGkcSyej7W4JCG0x5iKXFKwI+5auhAd1pMcUC7yIEuAId+/jbAjLLeawBtyOf6wEmYkR7tq/MoMA= Content-Language: en-us X-CMS-MailID: 20260304074638epcas5p23e2fddcfdad2ac7eaff71907d902f706 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P cpgsPolicy: CPGSC10-542,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20260122125134epcas5p36625b7ac70b8dfba9430831a11955682 References: <20260122130721.205664-1-pritam.sutar@samsung.com> <20260122130721.205664-3-pritam.sutar@samsung.com> <352427f4-144a-4a43-a2f3-dd959302939f@kernel.org> <000001dc9c13$ea305520$be90ff60$@samsung.com> <2edff611-76bb-45aa-922e-f96581dd0525@kernel.org> <019001dca0b8$f709e640$e51db2c0$@samsung.com> Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski > Sent: Thursday, February 19, 2026 1:24 AM > To: pritam.sutar=40samsung.com; robh=40kernel.org; krzk+dt=40kernel.org; > conor+dt=40kernel.org; alim.akhtar=40samsung.com > Cc: devicetree=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org;= linux- > samsung-soc=40vger.kernel.org; linux-kernel=40vger.kernel.org; > rosa.pila=40samsung.com; dev.tailor=40samsung.com; > faraz.ata=40samsung.com; muhammed.ali=40samsung.com; > selvarasu.g=40samsung.com > Subject: Re: =5BPATCH v2 2/3=5D arm64: dts: exynos: ExynosAutov920: Add > regulators for the USB >=20 > On 18/02/2026 10:28, pritam.sutar=40samsung.com wrote: > >>>>> + usbdrd31_dwc3_vbus: usbdrd31_dwc3-vbus =7B > >>>> > >>>> Please use name for all fixed regulators which matches current > >>>> format > >>>> recommendation: 'regulator-=5B0-9=5Dv=5B0-9=5D' > >>>> > >>>> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux. > >>>> gi > >>>> t/tree/ > >>>> Documentation/devicetree/bindings/regulator/fixed-regulator.yaml > >>>> > >>>> None of the regulators are called like you wrote. Really NONE. > >>>> > >>> > >>> Thank you for the references. Will bring changes for regulator's > >>> name and labels as > >>> > >>> - usbdrd31_dwc3_vbus: usbdrd31_dwc3-vbus =7B > >>> + reg_usbdrd31_dwc3_vbus: regulator-1 =7B > >> > >> Did you read the binding? That's not what I asked. > >> > > > > Yes. > > Sorry for misinterpreting above comment. Is it expected as below? > > > > This is based on our understanding by referring binding and other vendo= r > dts. > > > > --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts > > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts > > =40=40 -59,7 +59,7 =40=40 dummy_regulator: regulator-0 =7B > > regulator-name =3D =22dummy_regulator=22; > > =7D; > > > > - usbdrd31_dwc3_vbus: usbdrd31_dwc3-vbus =7B > > + reg_usb_vbus0: regulator-5v0-vbus0 =7B >=20 > Yes, that's better. Thank you for the confirmation. >=20 > Only under the assumption these are actually dedicated single-enable-pin > regulators, not pins going to the PMIC. >=20 Yes. this is dedicated single-enable-pin. > > compatible =3D =22regulator-fixed=22; > > regulator-name =3D =22usbdrd31_dwc3-vbus=22; > > regulator-min-microvolt =3D <5000000>; =40=40 -75,7 +75,= 7 =40=40 > > usb_phy0: usb-phy0 =7B > > vbus-supply =3D <&usbdrd31_dwc3_vbus>; > > =7D; > > >=20 > ... >=20 > >>>> > >>>> That's a bit too much of dummies. This is heavily incomplete. You > >>>> need to bring back the PMIC first. > >>>> > >>> > >>> Presently, relying on USB LDOs being enabled by the bootloader in > >>> this automotive SoC. However, we understand the concern and it is > >>> added in case if anyone wants to use implemented PMIC in future. For > >>> now, would like to proceed with the dummy regulators to enable the > >>> required USB > >> features. > >> > >> And I don't see the point of these dummies. Solves nothing. > >> > > > > Are you expecting details as mentioned in above section in commit > message? > > However, we have mentioned these details in cover letter. >=20 > No, I am expecting proper PMIC to be represented here. One dummy > regulator during the fast development phase is okay. Dummy added by > community contributors without resources and schematics would also fly. >=20 > But Samsung, with all the resources, schematics doing development since > 2023 and still adding 20 dummies to every device? Nope, no, sorry. >=20 > Please start doing this properly. Look how entire new SoC was upstreamed > by Linaro: > https://lore.kernel.org/all/20231121-topic-sm8650-upstream-dt-v3-0- > db9d0507ffd3=40linaro.org/ >=20 > Or something newer by Qualcomm: > https://lore.kernel.org/linux-arm-msm/?q=3Ds%3Aglymur >=20 Appreciated for the references. As you might know, the regulator control and power=E2=80=91management=20arc= hitecture=20=0D=0Ahas=20changed=20in=20recent=20Exynos=E2=80=AFSoCs.=20It= =20is=20now=20controlled=20by=20the=20ACPM/APM=20core,=20and=20=0D=0Athe=20= PMIC=20is=20interfaced=20over=20SPMI=20(instead=20of=20the=20legacy=20I2C= =20interface).=20I=20am=20checking=20=0D=0Ainternally=20how=20to=20implemen= t=20this,=20and=20it=20may=20take=20a=20bit=20longer=20to=20have=20the=20fu= ll=20recipe=20=0D=0Aready=20to=20add=20an=20actual=20regulator.=0D=0A=0D=0A= USB=20is=20one=20of=20the=20critical=20IP=20blocks=20that=20needs=20be=20en= abled=20to=20allow=20the=20rest=20of=20the=20=0D=0Ateam=E2=80=99s=20workflo= w=20over=20USB=20(e.g.,=20enabling=20automation=20via=20USB=20for=20testing= ,=20etc.).=0D=0A=0D=0AIf=20these=20changes=20can=20be=20accommodated,=20it= =20would=20be=20great.=20In=20the=20meantime,=20=0D=0AI=20will=20continue= =20working=20internally=20to=20see=20how=20we=20can=20push=20the=20missing= =20pieces=20upstream.=0D=0A=0D=0A>=20=0D=0A>=20Best=20regards,=0D=0A>=20Krz= ysztof=0D=0A=0D=0AThank=20you.=0D=0A=0D=0ARegards,=0D=0APritam=0D=0A=0D=0A