From: Jingoo Han <jg1.han@samsung.com>
To: 'Liviu Dudau' <Liviu.Dudau@arm.com>
Cc: 'linux-pci' <linux-pci@vger.kernel.org>,
'Bjorn Helgaas' <bhelgaas@google.com>,
'Catalin Marinas' <Catalin.Marinas@arm.com>,
'Will Deacon' <Will.Deacon@arm.com>,
'linaro-kernel' <linaro-kernel@lists.linaro.org>,
'Benjamin Herrenschmidt' <benh@kernel.crashing.org>,
'LKML' <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org,
'LAKML' <linux-arm-kernel@lists.infradead.org>,
'Tanmay Inamdar' <tinamdar@apm.com>,
'Arnd Bergmann' <arnd@arndb.de>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH v6 3/3] arm64: Add architecture support for PCI
Date: Wed, 12 Mar 2014 17:41:33 +0900 [thread overview]
Message-ID: <000101cf3dce$df2c1840$9d8448c0$%han@samsung.com> (raw)
In-Reply-To: <1394020150-1875-4-git-send-email-Liviu.Dudau@arm.com>
On Wednesday, March 05, 2014 8:49 PM, Liviu Dudau wrote:
>
> Use the generic host bridge functions to provide support for
> PCI Express on arm64. There is no support for ISA memory.
>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> Tested-by: Tanmay Inamdar <tinamdar@apm.com>
> ---
> arch/arm64/Kconfig | 19 +++-
> arch/arm64/include/asm/Kbuild | 1 +
> arch/arm64/include/asm/io.h | 3 +-
> arch/arm64/include/asm/pci.h | 49 +++++++++
> arch/arm64/kernel/Makefile | 1 +
> arch/arm64/kernel/pci.c | 173 ++++++++++++++++++++++++++++++++
> 6 files changed, 244 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm64/include/asm/pci.h
> create mode 100644 arch/arm64/kernel/pci.c
[.....]
> --- /dev/null
> +++ b/arch/arm64/include/asm/pci.h
[.....]
> +
> +static inline int pci_domain_nr(struct pci_bus *bus)
> +{
> + struct pci_host_bridge *bridge = find_pci_host_bridge(bus);
> +
> + if (bridge)
> + return bridge->domain_nr;
> +
> + return 0;
> +}
Hi Liviu Dudau,
When CONFIG_PCI=n, the following build errors happen. :-(
Would you confirm this?
In file included from include/linux/pci.h:1393:0,
from drivers/scsi/scsi_lib.c:19:
arch/arm64/include/asm/pci.h:31:19: error: redefinition of 'pci_domain_nr'
static inline int pci_domain_nr(struct pci_bus *bus)
^
In file included from drivers/scsi/scsi_lib.c:19:0:
include/linux/pci.h:1383:19: note: previous definition of 'pci_domain_nr' was here
static inline int pci_domain_nr(struct pci_bus *bus) { return 0; }
^
.....
Best regards,
Jingoo Han
next prev parent reply other threads:[~2014-03-12 8:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 11:49 [PATCH v6 0/3] [RFC] Add support for PCI in AArch64 Liviu Dudau
2014-03-05 11:49 ` [PATCH v6 1/3] Fix ioport_map() for !CONFIG_GENERIC_IOMAP cases Liviu Dudau
2014-03-05 23:31 ` Russell King - ARM Linux
2014-03-06 10:36 ` Liviu Dudau
2014-03-07 0:37 ` Arnd Bergmann
2014-03-07 1:09 ` Russell King - ARM Linux
2014-03-07 1:44 ` Liviu Dudau
2014-03-14 11:54 ` Arnd Bergmann
2014-03-05 11:49 ` [PATCH v6 2/3] arm64: Extend the PCI I/O space to 16MB Liviu Dudau
2014-03-05 11:49 ` [PATCH v6 3/3] arm64: Add architecture support for PCI Liviu Dudau
2014-03-12 8:41 ` Jingoo Han [this message]
[not found] ` <000101cf3dce$df2c1840$9d8448c0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-13 0:11 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101cf3dce$df2c1840$9d8448c0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=Catalin.Marinas@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Will.Deacon@arm.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).