From: "Jingoo Han" <jingoohan1@gmail.com>
To: 'Michal Simek' <michal.simek@xilinx.com>,
'Moritz Fischer' <moritz.fischer@ettus.com>,
jassisinghbrar@gmail.com
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
soren.brinkmann@xilinx.com, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, mchehab@osg.samsung.com,
arnd@arndb.de, joe@perches.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv1 0/2] Adding driver for Xilinx LogiCORE IP mailbox.
Date: Mon, 25 May 2015 22:56:14 +0900 [thread overview]
Message-ID: <000101d096f2$97457cf0$c5d076d0$@com> (raw)
In-Reply-To: <5562BB92.60808@xilinx.com>
On Monday, May 25, 2015 3:05 PM, Michal Simek wrote:
> On 05/22/2015 08:03 PM, Moritz Fischer wrote:
> > This patchset adds mailbox framework integration for the Xilinx LogiCORE IP
> > mailbox. The Xilinx LogiCORE IP mailbox is a fpga softcore that allows
> > interprocessor communication between AXI4 stream / memory mapped
> > processors.
> >
> > Changes from v0:
> > ---------------------
> >
> > - Several stylistic issues
> > - Dropped superfluous intr_mode member
> > - Really masking the IRQs on mailbox_shutdown
> > - No longer using polling by accident in non-IRQ mode
> > - Swapped doc and driver commits
>
> Changes update should be in every particular patch.
> Also v1 is used to the first version that's why this one should be v2.
Right, I agree with Michal Simek's opinion.
If there are 'Changes update' in each patch, it makes people review
the patches more easily. In addition, normally, 'v0' is not used.
Best regards,
Jingoo Han
>
> Thanks,
> Michal
next prev parent reply other threads:[~2015-05-25 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 18:03 [PATCHv1 0/2] Adding driver for Xilinx LogiCORE IP mailbox Moritz Fischer
2015-05-22 18:03 ` [PATCHv1 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver Moritz Fischer
2015-05-22 18:03 ` [PATCHv1 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox Moritz Fischer
2015-05-23 0:08 ` Moritz Fischer
2015-05-25 6:05 ` [PATCHv1 0/2] " Michal Simek
2015-05-25 13:56 ` Jingoo Han [this message]
2015-05-26 16:12 ` Moritz Fischer
2015-05-27 6:12 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101d096f2$97457cf0$c5d076d0$@com' \
--to=jingoohan1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jassisinghbrar@gmail.com \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=michal.simek@xilinx.com \
--cc=moritz.fischer@ettus.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).