devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Padmanabhan Rajanbabu'" <p.rajanbabu@samsung.com>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<chanho61.park@samsung.com>, <linus.walleij@linaro.org>,
	<pankaj.dubey@samsung.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-samsung-soc@vger.kernel.org>
Subject: RE: [PATCH v3 2/4] arm64: dts: fix HSI2C drive strength values as per FSD HW UM
Date: Fri, 14 Oct 2022 07:09:38 +0530	[thread overview]
Message-ID: <000101d8df6d$d448f4d0$7cdade70$@samsung.com> (raw)
In-Reply-To: <20221013104024.50179-3-p.rajanbabu@samsung.com>



>-----Original Message-----
>From: Padmanabhan Rajanbabu [mailto:p.rajanbabu@samsung.com]
>Sent: Thursday, October 13, 2022 4:10 PM
>To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
>alim.akhtar@samsung.com; chanho61.park@samsung.com;
>linus.walleij@linaro.org; pankaj.dubey@samsung.com
>Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
>samsung-soc@vger.kernel.org; Padmanabhan Rajanbabu
><p.rajanbabu@samsung.com>
>Subject: [PATCH v3 2/4] arm64: dts: fix HSI2C drive strength values as per FSD
>HW UM
>
>Drive strength values used for HSI2C is not reflecting the default values
>recommended by FSD HW UM.
>
>Fix the drive strength values for HSI2C, thereby ensuring that the existing
>device tree file is using default drive strength values recommended by UM for
>FSD SoC.
>
>Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support")
>Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>index 4e151d419909..09a492b1fd6e 100644
>--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>@@ -253,56 +253,56 @@
> 		samsung,pins = "gpb0-0", "gpb0-1";
> 		samsung,pin-function = <FSD_PIN_FUNC_2>;
> 		samsung,pin-pud = <FSD_PIN_PULL_UP>;
>-		samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> 	};
>
> 	hs_i2c1_bus: hs-i2c1-bus-pins {
> 		samsung,pins = "gpb0-2", "gpb0-3";
> 		samsung,pin-function = <FSD_PIN_FUNC_2>;
> 		samsung,pin-pud = <FSD_PIN_PULL_UP>;
>-		samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> 	};
>
> 	hs_i2c2_bus: hs-i2c2-bus-pins {
> 		samsung,pins = "gpb0-4", "gpb0-5";
> 		samsung,pin-function = <FSD_PIN_FUNC_2>;
> 		samsung,pin-pud = <FSD_PIN_PULL_UP>;
>-		samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> 	};
>
> 	hs_i2c3_bus: hs-i2c3-bus-pins {
> 		samsung,pins = "gpb0-6", "gpb0-7";
> 		samsung,pin-function = <FSD_PIN_FUNC_2>;
> 		samsung,pin-pud = <FSD_PIN_PULL_UP>;
>-		samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> 	};
>
> 	hs_i2c4_bus: hs-i2c4-bus-pins {
> 		samsung,pins = "gpb1-0", "gpb1-1";
> 		samsung,pin-function = <FSD_PIN_FUNC_2>;
> 		samsung,pin-pud = <FSD_PIN_PULL_UP>;
>-		samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> 	};
>
> 	hs_i2c5_bus: hs-i2c5-bus-pins {
> 		samsung,pins = "gpb1-2", "gpb1-3";
> 		samsung,pin-function = <FSD_PIN_FUNC_2>;
> 		samsung,pin-pud = <FSD_PIN_PULL_UP>;
>-		samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> 	};
>
> 	hs_i2c6_bus: hs-i2c6-bus-pins {
> 		samsung,pins = "gpb1-4", "gpb1-5";
> 		samsung,pin-function = <FSD_PIN_FUNC_2>;
> 		samsung,pin-pud = <FSD_PIN_PULL_UP>;
>-		samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> 	};
>
> 	hs_i2c7_bus: hs-i2c7-bus-pins {
> 		samsung,pins = "gpb1-6", "gpb1-7";
> 		samsung,pin-function = <FSD_PIN_FUNC_2>;
> 		samsung,pin-pud = <FSD_PIN_PULL_UP>;
>-		samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> 	};
>
> 	uart0_data: uart0-data-pins {
>--
>2.17.1



  reply	other threads:[~2022-10-14  1:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20221013110708epcas5p3c54c22bbc77175eb2a26dc9fd43814d5@epcas5p3.samsung.com>
2022-10-13 10:40 ` [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform Padmanabhan Rajanbabu
     [not found]   ` <CGME20221013110721epcas5p44cc7dcc5ac2ab8eaf6c472cc87dea06f@epcas5p4.samsung.com>
2022-10-13 10:40     ` [PATCH v3 1/4] arm64: dts: fix drive strength macros as per FSD HW UM Padmanabhan Rajanbabu
2022-10-14  1:38       ` Alim Akhtar
     [not found]   ` <CGME20221013110725epcas5p1411c422eb2c29494fd5c1e66e09564c5@epcas5p1.samsung.com>
2022-10-13 10:40     ` [PATCH v3 2/4] arm64: dts: fix HSI2C drive strength values " Padmanabhan Rajanbabu
2022-10-14  1:39       ` Alim Akhtar [this message]
     [not found]   ` <CGME20221013110728epcas5p22fb8b83f6cfb4b6a035a9fbb5a38546f@epcas5p2.samsung.com>
2022-10-13 10:40     ` [PATCH v3 3/4] arm64: dts: fix UART " Padmanabhan Rajanbabu
2022-10-14  1:41       ` Alim Akhtar
     [not found]   ` <CGME20221013110733epcas5p36e0104bfa4da37159da77f9231ff6e2c@epcas5p3.samsung.com>
2022-10-13 10:40     ` [PATCH v3 4/4] arm64: dts: fix SPI " Padmanabhan Rajanbabu
2022-10-14  1:41       ` Alim Akhtar
2022-10-18 13:21   ` [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform Krzysztof Kozlowski
2022-10-18 13:21   ` Krzysztof Kozlowski
2022-10-18 13:25     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000101d8df6d$d448f4d0$7cdade70$@samsung.com' \
    --to=alim.akhtar@samsung.com \
    --cc=chanho61.park@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=p.rajanbabu@samsung.com \
    --cc=pankaj.dubey@samsung.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).