From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB4C02E9754 for ; Thu, 11 Sep 2025 16:04:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.24 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757606697; cv=none; b=DzLlGHugPIbW4ZJnDYjo3nfT9wH1tNz90kfnTpF7vRXhItkRTcfKZvz4PYM33QqEc3hJs8jtf9SLnw2Mdn0wegjGMJ2qf8cB0vFTfuZSuEofduWbjZexZ5TUNcxfgkvMyzS60LstXP8k75UbDSl4LsFqRiZcZ9mqox1R+0TglR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757606697; c=relaxed/simple; bh=QLqT72F3OiEEkIlx+AH/Ww1OOwEOuDTmBVb4LAHkNe0=; h=From:To:Cc:In-Reply-To:Subject:Date:Message-ID:MIME-Version: Content-Type:References; b=A0DJ8OCDGrytHkrPKjyFeOuowD1OfwKTZIW4AeL5ZBbjt8tvqqcBAh2kgkkQedtYRV1685bQV5aZ8DEL16H+oMEbPKEeb72Vujy6F1v0iG8Y79it0i6gjavZJaqShseEuq2aIsrhQAWMzRQzWaaU1nfz1MIc6hHghWkWTruCtN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=TfJef+/W; arc=none smtp.client-ip=203.254.224.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="TfJef+/W" Received: from epcas5p1.samsung.com (unknown [182.195.41.39]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250911160453epoutp01cb18e687d6fe3c3d8a44301b9b9807cf~kRfmfHqea0379503795epoutp01B for ; Thu, 11 Sep 2025 16:04:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250911160453epoutp01cb18e687d6fe3c3d8a44301b9b9807cf~kRfmfHqea0379503795epoutp01B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1757606693; bh=NEAgB8FLwolb3G6/hv5nbzV1b6/W++gnOLU+viUGvD4=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=TfJef+/W3AlO8hMAWuR+qDRc/TocML3gfGJaghLdx9TG2SsaXYeNkTNaw6Ocqdyym V6TDlUN9pk516NYhSFwMDXPlU+HUnSW2Kg3UzrQ7ESykXhxP1jN1WVgBqE6ZJMe+/n Bm9Ewp2xFBANxsRtxbtgJSftt89F/YTxzA6UGAZg= Received: from epsnrtp02.localdomain (unknown [182.195.42.154]) by epcas5p1.samsung.com (KnoxPortal) with ESMTPS id 20250911160451epcas5p1428a7400e31cfaf0fb49ae1bb1e281b0~kRflCwNxe0037600376epcas5p1Q; Thu, 11 Sep 2025 16:04:51 +0000 (GMT) Received: from epcas5p4.samsung.com (unknown [182.195.38.94]) by epsnrtp02.localdomain (Postfix) with ESMTP id 4cN2Sf5WKZz2SSKf; Thu, 11 Sep 2025 16:04:50 +0000 (GMT) Received: from epsmtip1.samsung.com (unknown [182.195.34.30]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPA id 20250911160449epcas5p4016f54ce49a5af4e50787e90b0a8572b~kRfi51XKu2011520115epcas5p4b; Thu, 11 Sep 2025 16:04:49 +0000 (GMT) Received: from FDSFTE411 (unknown [107.122.81.184]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250911160442epsmtip1d6d45c14abaa5b9aa6c8b5552c0471da~kRfcmF7XE2197521975epsmtip1p; Thu, 11 Sep 2025 16:04:42 +0000 (GMT) From: "Ravi Patel" To: "'Krzysztof Kozlowski'" , "'Geert Uytterhoeven'" Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , In-Reply-To: <8aeda67e-404e-4deb-ac90-015f2325ef64@kernel.org> Subject: RE: [PATCH 3/3] tty: serial: samsung: Remove unused artpec-8 specific code Date: Thu, 11 Sep 2025 21:34:40 +0530 Message-ID: <000101dc2335$ccd62f60$66828e20$@samsung.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJu8uqH6fYxQzG+hnF7rWV1C9oliQHCvJCeAevVl18Bulx3hgI90RbxAdnEKbSzHH4+gA== Content-Language: en-in X-CMS-MailID: 20250911160449epcas5p4016f54ce49a5af4e50787e90b0a8572b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P cpgsPolicy: CPGSC10-541,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250911141714epcas5p29f591a1d645c9c69dc5b7d2c2d12af50 References: <20250911141605.13034-1-ravi.patel@samsung.com> <20250911141605.13034-4-ravi.patel@samsung.com> <6df0e227-896b-438a-913e-95b637aa2b14@kernel.org> <8aeda67e-404e-4deb-ac90-015f2325ef64@kernel.org> > -----Original Message----- > From: Krzysztof Kozlowski > Sent: 11 September 2025 20:05 ... > Subject: Re: =5BPATCH 3/3=5D tty: serial: samsung: Remove unused artpec-8= specific code >=20 > On 11/09/2025 16:29, Krzysztof Kozlowski wrote: > >>> --- a/drivers/tty/serial/samsung_tty.c > >>> +++ b/drivers/tty/serial/samsung_tty.c > >> > >>> =40=40 -2655,8 +2621,6 =40=40 static const struct of_device_id s3c24x= x_uart_dt_match=5B=5D =3D =7B > >>> .data =3D S5L_SERIAL_DRV_DATA =7D, > >>> =7B .compatible =3D =22samsung,exynos850-uart=22, > >>> .data =3D EXYNOS850_SERIAL_DRV_DATA =7D, > >>> - =7B .compatible =3D =22axis,artpec8-uart=22, > >>> - .data =3D ARTPEC8_SERIAL_DRV_DATA =7D, > >>> =7B .compatible =3D =22google,gs101-uart=22, > >>> .data =3D GS101_SERIAL_DRV_DATA =7D, > >>> =7B .compatible =3D =22samsung,exynos8895-uart=22, > >>> =40=40 -2828,8 +2792,6 =40=40 OF_EARLYCON_DECLARE(s5pv210, =22samsung= ,s5pv210-uart=22, > >>> s5pv210_early_console_setup); > >>> OF_EARLYCON_DECLARE(exynos4210, =22samsung,exynos4210-uart=22, > >>> s5pv210_early_console_setup); > >>> -OF_EARLYCON_DECLARE(artpec8, =22axis,artpec8-uart=22, > >>> - s5pv210_early_console_setup); > >>> > >>> static int __init gs101_early_console_setup(struct earlycon_device *= device, > >>> const char *opt) > >> > >> Removing these breaks backwards-compatibility with existing DTBs, > >> which lack the new =22samsung,exynos8895-uart=22 fallback compatible v= alue. > > > > This was just applied, so ABI break would be fine. It should be however > > clearly expressed in the commit msg. > > > > I have a feeling that not much testing was happening in Samsung around > > this patchset and only now - after I applied it - some things happen. > > But it is damn too late, my tree is already closed which means this is > > going to be the ABI. >=20 > Ah, no, I mixed up patches with recent DTS for Artpec-8. This serial ABI > was accepted three years ago (=21=21=21), so you are Geert absolutely rig= ht - > that's ABI break. Thank you for your review. The DTS patches for ARTPEC-8 is added recently (https://lore.kernel.org/lin= ux-samsung-soc/20250901051926.59970-1-ravi.patel=40samsung.com/) Before that, there was no user (in DT) of =22axis,artpec8-uart=22 compatibl= e. So I am not convinced of ABI break (considering patch =231 and =232 goes fi= rst with review comment fixes) My intension here is to optimize the driver code (by removing kind of dupli= cated code) And also preparation of upcoming ARTPEC-9 patch series where ARTPEC-9 uart = is exactly same as ARTPEC-8. Please let me know if I misunderstood anything here. Thanks, Ravi >=20 > Folks in Samsung, maybe try to organize some weekly sessions sharing > knowledge after upstreaming reviews/feedbacks? I feel like you are > repeating same mistakes. >=20 > Best regards, > Krzysztof