* [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform [not found] <CGME20221013110708epcas5p3c54c22bbc77175eb2a26dc9fd43814d5@epcas5p3.samsung.com> @ 2022-10-13 10:40 ` Padmanabhan Rajanbabu [not found] ` <CGME20221013110721epcas5p44cc7dcc5ac2ab8eaf6c472cc87dea06f@epcas5p4.samsung.com> ` (5 more replies) 0 siblings, 6 replies; 12+ messages in thread From: Padmanabhan Rajanbabu @ 2022-10-13 10:40 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, alim.akhtar, chanho61.park, linus.walleij, pankaj.dubey Cc: devicetree, linux-kernel, linux-samsung-soc, Padmanabhan Rajanbabu With reference to FSD SoC HW UM, there are some deviations in the drive strength macros names and macro values. Also the IPs are not using the default drive strength values as recommended by HW UM. FSD SoC pinctrl has following four levels of drive-strength and their corresponding values: Level-1 <-> 0 Level-2 <-> 1 Level-4 <-> 2 Level-6 <-> 3 The commit 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") used drive strength macros defined for Exynos4 SoC family. For some IPs the macros values of Exynos4 matched and worked well, but Exynos4 SoC family drive-strength (names and values) is not exactly matching with FSD SoC. The intention of this patch series is to: 1. Fix the drive strength macros to reflect actual names and values given in FSD HW UM. 2. Ensure that the existing peripherals in device tree file is using default drive strength values recommended in FSD HW UM. Padmanabhan Rajanbabu (4): arm64: dts: fix drive strength macros as per FSD HW UM arm64: dts: fix HSI2C drive strength values as per FSD HW UM arm64: dts: fix UART drive strength values as per FSD HW UM arm64: dts: fix SPI drive strength values as per FSD HW UM arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 34 +++++++++++----------- arch/arm64/boot/dts/tesla/fsd-pinctrl.h | 6 ++-- 2 files changed, 20 insertions(+), 20 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <CGME20221013110721epcas5p44cc7dcc5ac2ab8eaf6c472cc87dea06f@epcas5p4.samsung.com>]
* [PATCH v3 1/4] arm64: dts: fix drive strength macros as per FSD HW UM [not found] ` <CGME20221013110721epcas5p44cc7dcc5ac2ab8eaf6c472cc87dea06f@epcas5p4.samsung.com> @ 2022-10-13 10:40 ` Padmanabhan Rajanbabu 2022-10-14 1:38 ` Alim Akhtar 0 siblings, 1 reply; 12+ messages in thread From: Padmanabhan Rajanbabu @ 2022-10-13 10:40 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, alim.akhtar, chanho61.park, linus.walleij, pankaj.dubey Cc: devicetree, linux-kernel, linux-samsung-soc, Padmanabhan Rajanbabu Drive strength macros defined for FSD platform is not reflecting actual names and values as per HW UM. FSD SoC pinctrl has following four levels of drive-strength and their corresponding values: Level-1 <-> 0 Level-2 <-> 1 Level-4 <-> 2 Level-6 <-> 3 The commit 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") used drive strength macros defined for Exynos4 SoC family. For some IPs the macros values of Exynos4 matched and worked well, but Exynos4 SoC family drive-strength (names and values) is not exactly matching with FSD SoC. Fix the drive strength macros to reflect actual names and values given in FSD HW UM. Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> --- arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 8 ++++---- arch/arm64/boot/dts/tesla/fsd-pinctrl.h | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi index d0abb9aa0e9e..4e151d419909 100644 --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi @@ -55,14 +55,14 @@ samsung,pins = "gpf5-0"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_NONE>; - samsung,pin-drv = <FSD_PIN_DRV_LV2>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; ufs_refclk_out: ufs-refclk-out-pins { samsung,pins = "gpf5-1"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_NONE>; - samsung,pin-drv = <FSD_PIN_DRV_LV2>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; }; @@ -239,14 +239,14 @@ samsung,pins = "gpb6-1"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV2>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; pwm1_out: pwm1-out-pins { samsung,pins = "gpb6-5"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV2>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; hs_i2c0_bus: hs-i2c0-bus-pins { diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.h b/arch/arm64/boot/dts/tesla/fsd-pinctrl.h index 6ffbda362493..c397d02208a0 100644 --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.h +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.h @@ -16,9 +16,9 @@ #define FSD_PIN_PULL_UP 3 #define FSD_PIN_DRV_LV1 0 -#define FSD_PIN_DRV_LV2 2 -#define FSD_PIN_DRV_LV3 1 -#define FSD_PIN_DRV_LV4 3 +#define FSD_PIN_DRV_LV2 1 +#define FSD_PIN_DRV_LV4 2 +#define FSD_PIN_DRV_LV6 3 #define FSD_PIN_FUNC_INPUT 0 #define FSD_PIN_FUNC_OUTPUT 1 -- 2.17.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* RE: [PATCH v3 1/4] arm64: dts: fix drive strength macros as per FSD HW UM 2022-10-13 10:40 ` [PATCH v3 1/4] arm64: dts: fix drive strength macros as per FSD HW UM Padmanabhan Rajanbabu @ 2022-10-14 1:38 ` Alim Akhtar 0 siblings, 0 replies; 12+ messages in thread From: Alim Akhtar @ 2022-10-14 1:38 UTC (permalink / raw) To: 'Padmanabhan Rajanbabu', robh+dt, krzysztof.kozlowski+dt, chanho61.park, linus.walleij, pankaj.dubey Cc: devicetree, linux-kernel, linux-samsung-soc >-----Original Message----- >From: Padmanabhan Rajanbabu [mailto:p.rajanbabu@samsung.com] >Sent: Thursday, October 13, 2022 4:10 PM >To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; >alim.akhtar@samsung.com; chanho61.park@samsung.com; >linus.walleij@linaro.org; pankaj.dubey@samsung.com >Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >samsung-soc@vger.kernel.org; Padmanabhan Rajanbabu ><p.rajanbabu@samsung.com> >Subject: [PATCH v3 1/4] arm64: dts: fix drive strength macros as per FSD HW >UM > >Drive strength macros defined for FSD platform is not reflecting actual names >and values as per HW UM. FSD SoC pinctrl has following four levels of drive- >strength and their corresponding values: >Level-1 <-> 0 >Level-2 <-> 1 >Level-4 <-> 2 >Level-6 <-> 3 > >The commit 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") used >drive strength macros defined for Exynos4 SoC family. For some IPs the >macros values of Exynos4 matched and worked well, but Exynos4 SoC family >drive-strength (names and values) is not exactly matching with FSD SoC. > >Fix the drive strength macros to reflect actual names and values given in FSD >HW UM. > >Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") >Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> >--- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> Thanks! > arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 8 ++++---- > arch/arm64/boot/dts/tesla/fsd-pinctrl.h | 6 +++--- > 2 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >index d0abb9aa0e9e..4e151d419909 100644 >--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >@@ -55,14 +55,14 @@ > samsung,pins = "gpf5-0"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_NONE>; >- samsung,pin-drv = <FSD_PIN_DRV_LV2>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > ufs_refclk_out: ufs-refclk-out-pins { > samsung,pins = "gpf5-1"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_NONE>; >- samsung,pin-drv = <FSD_PIN_DRV_LV2>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > }; > >@@ -239,14 +239,14 @@ > samsung,pins = "gpb6-1"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV2>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > pwm1_out: pwm1-out-pins { > samsung,pins = "gpb6-5"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV2>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > hs_i2c0_bus: hs-i2c0-bus-pins { >diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.h >b/arch/arm64/boot/dts/tesla/fsd-pinctrl.h >index 6ffbda362493..c397d02208a0 100644 >--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.h >+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.h >@@ -16,9 +16,9 @@ > #define FSD_PIN_PULL_UP 3 > > #define FSD_PIN_DRV_LV1 0 >-#define FSD_PIN_DRV_LV2 2 >-#define FSD_PIN_DRV_LV3 1 >-#define FSD_PIN_DRV_LV4 3 >+#define FSD_PIN_DRV_LV2 1 >+#define FSD_PIN_DRV_LV4 2 >+#define FSD_PIN_DRV_LV6 3 > > #define FSD_PIN_FUNC_INPUT 0 > #define FSD_PIN_FUNC_OUTPUT 1 >-- >2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <CGME20221013110725epcas5p1411c422eb2c29494fd5c1e66e09564c5@epcas5p1.samsung.com>]
* [PATCH v3 2/4] arm64: dts: fix HSI2C drive strength values as per FSD HW UM [not found] ` <CGME20221013110725epcas5p1411c422eb2c29494fd5c1e66e09564c5@epcas5p1.samsung.com> @ 2022-10-13 10:40 ` Padmanabhan Rajanbabu 2022-10-14 1:39 ` Alim Akhtar 0 siblings, 1 reply; 12+ messages in thread From: Padmanabhan Rajanbabu @ 2022-10-13 10:40 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, alim.akhtar, chanho61.park, linus.walleij, pankaj.dubey Cc: devicetree, linux-kernel, linux-samsung-soc, Padmanabhan Rajanbabu Drive strength values used for HSI2C is not reflecting the default values recommended by FSD HW UM. Fix the drive strength values for HSI2C, thereby ensuring that the existing device tree file is using default drive strength values recommended by UM for FSD SoC. Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> --- arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi index 4e151d419909..09a492b1fd6e 100644 --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi @@ -253,56 +253,56 @@ samsung,pins = "gpb0-0", "gpb0-1"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; hs_i2c1_bus: hs-i2c1-bus-pins { samsung,pins = "gpb0-2", "gpb0-3"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; hs_i2c2_bus: hs-i2c2-bus-pins { samsung,pins = "gpb0-4", "gpb0-5"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; hs_i2c3_bus: hs-i2c3-bus-pins { samsung,pins = "gpb0-6", "gpb0-7"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; hs_i2c4_bus: hs-i2c4-bus-pins { samsung,pins = "gpb1-0", "gpb1-1"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; hs_i2c5_bus: hs-i2c5-bus-pins { samsung,pins = "gpb1-2", "gpb1-3"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; hs_i2c6_bus: hs-i2c6-bus-pins { samsung,pins = "gpb1-4", "gpb1-5"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; hs_i2c7_bus: hs-i2c7-bus-pins { samsung,pins = "gpb1-6", "gpb1-7"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; uart0_data: uart0-data-pins { -- 2.17.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* RE: [PATCH v3 2/4] arm64: dts: fix HSI2C drive strength values as per FSD HW UM 2022-10-13 10:40 ` [PATCH v3 2/4] arm64: dts: fix HSI2C drive strength values " Padmanabhan Rajanbabu @ 2022-10-14 1:39 ` Alim Akhtar 0 siblings, 0 replies; 12+ messages in thread From: Alim Akhtar @ 2022-10-14 1:39 UTC (permalink / raw) To: 'Padmanabhan Rajanbabu', robh+dt, krzysztof.kozlowski+dt, chanho61.park, linus.walleij, pankaj.dubey Cc: devicetree, linux-kernel, linux-samsung-soc >-----Original Message----- >From: Padmanabhan Rajanbabu [mailto:p.rajanbabu@samsung.com] >Sent: Thursday, October 13, 2022 4:10 PM >To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; >alim.akhtar@samsung.com; chanho61.park@samsung.com; >linus.walleij@linaro.org; pankaj.dubey@samsung.com >Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >samsung-soc@vger.kernel.org; Padmanabhan Rajanbabu ><p.rajanbabu@samsung.com> >Subject: [PATCH v3 2/4] arm64: dts: fix HSI2C drive strength values as per FSD >HW UM > >Drive strength values used for HSI2C is not reflecting the default values >recommended by FSD HW UM. > >Fix the drive strength values for HSI2C, thereby ensuring that the existing >device tree file is using default drive strength values recommended by UM for >FSD SoC. > >Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") >Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> >--- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >index 4e151d419909..09a492b1fd6e 100644 >--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >@@ -253,56 +253,56 @@ > samsung,pins = "gpb0-0", "gpb0-1"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > hs_i2c1_bus: hs-i2c1-bus-pins { > samsung,pins = "gpb0-2", "gpb0-3"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > hs_i2c2_bus: hs-i2c2-bus-pins { > samsung,pins = "gpb0-4", "gpb0-5"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > hs_i2c3_bus: hs-i2c3-bus-pins { > samsung,pins = "gpb0-6", "gpb0-7"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > hs_i2c4_bus: hs-i2c4-bus-pins { > samsung,pins = "gpb1-0", "gpb1-1"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > hs_i2c5_bus: hs-i2c5-bus-pins { > samsung,pins = "gpb1-2", "gpb1-3"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > hs_i2c6_bus: hs-i2c6-bus-pins { > samsung,pins = "gpb1-4", "gpb1-5"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > hs_i2c7_bus: hs-i2c7-bus-pins { > samsung,pins = "gpb1-6", "gpb1-7"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > uart0_data: uart0-data-pins { >-- >2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <CGME20221013110728epcas5p22fb8b83f6cfb4b6a035a9fbb5a38546f@epcas5p2.samsung.com>]
* [PATCH v3 3/4] arm64: dts: fix UART drive strength values as per FSD HW UM [not found] ` <CGME20221013110728epcas5p22fb8b83f6cfb4b6a035a9fbb5a38546f@epcas5p2.samsung.com> @ 2022-10-13 10:40 ` Padmanabhan Rajanbabu 2022-10-14 1:41 ` Alim Akhtar 0 siblings, 1 reply; 12+ messages in thread From: Padmanabhan Rajanbabu @ 2022-10-13 10:40 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, alim.akhtar, chanho61.park, linus.walleij, pankaj.dubey Cc: devicetree, linux-kernel, linux-samsung-soc, Padmanabhan Rajanbabu Drive strength values used for UART is not reflecting the default values recommended by FSD HW UM. Fix the drive strength values for UART, thereby ensuring that the existing device tree file is using default drive strength values recommended by UM for FSD SoC. Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> --- arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi index 09a492b1fd6e..a2634e70925a 100644 --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi @@ -309,14 +309,14 @@ samsung,pins = "gpb7-0", "gpb7-1"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_NONE>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; uart1_data: uart1-data-pins { samsung,pins = "gpb7-4", "gpb7-5"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_NONE>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; spi0_bus: spi0-bus-pins { -- 2.17.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* RE: [PATCH v3 3/4] arm64: dts: fix UART drive strength values as per FSD HW UM 2022-10-13 10:40 ` [PATCH v3 3/4] arm64: dts: fix UART " Padmanabhan Rajanbabu @ 2022-10-14 1:41 ` Alim Akhtar 0 siblings, 0 replies; 12+ messages in thread From: Alim Akhtar @ 2022-10-14 1:41 UTC (permalink / raw) To: 'Padmanabhan Rajanbabu', robh+dt, krzysztof.kozlowski+dt, chanho61.park, linus.walleij, pankaj.dubey Cc: devicetree, linux-kernel, linux-samsung-soc >-----Original Message----- >From: Padmanabhan Rajanbabu [mailto:p.rajanbabu@samsung.com] >Sent: Thursday, October 13, 2022 4:10 PM >To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; >alim.akhtar@samsung.com; chanho61.park@samsung.com; >linus.walleij@linaro.org; pankaj.dubey@samsung.com >Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >samsung-soc@vger.kernel.org; Padmanabhan Rajanbabu ><p.rajanbabu@samsung.com> >Subject: [PATCH v3 3/4] arm64: dts: fix UART drive strength values as per FSD >HW UM > >Drive strength values used for UART is not reflecting the default values >recommended by FSD HW UM. > >Fix the drive strength values for UART, thereby ensuring that the existing >device tree file is using default drive strength values recommended by UM for >FSD SoC. > >Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") >Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> >--- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >index 09a492b1fd6e..a2634e70925a 100644 >--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >@@ -309,14 +309,14 @@ > samsung,pins = "gpb7-0", "gpb7-1"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_NONE>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > uart1_data: uart1-data-pins { > samsung,pins = "gpb7-4", "gpb7-5"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_NONE>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > spi0_bus: spi0-bus-pins { >-- >2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <CGME20221013110733epcas5p36e0104bfa4da37159da77f9231ff6e2c@epcas5p3.samsung.com>]
* [PATCH v3 4/4] arm64: dts: fix SPI drive strength values as per FSD HW UM [not found] ` <CGME20221013110733epcas5p36e0104bfa4da37159da77f9231ff6e2c@epcas5p3.samsung.com> @ 2022-10-13 10:40 ` Padmanabhan Rajanbabu 2022-10-14 1:41 ` Alim Akhtar 0 siblings, 1 reply; 12+ messages in thread From: Padmanabhan Rajanbabu @ 2022-10-13 10:40 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, alim.akhtar, chanho61.park, linus.walleij, pankaj.dubey Cc: devicetree, linux-kernel, linux-samsung-soc, Padmanabhan Rajanbabu Drive strength values used for SPI is not reflecting the default values recommended by FSD HW UM. Fix the drive strength values for SPI, thereby ensuring that the existing device tree file is using default drive strength values recommended by UM for FSD SoC. Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> --- arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi index a2634e70925a..e3852c946352 100644 --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi @@ -323,21 +323,21 @@ samsung,pins = "gpb4-0", "gpb4-2", "gpb4-3"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; spi1_bus: spi1-bus-pins { samsung,pins = "gpb4-4", "gpb4-6", "gpb4-7"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; spi2_bus: spi2-bus-pins { samsung,pins = "gpb5-0", "gpb5-2", "gpb5-3"; samsung,pin-function = <FSD_PIN_FUNC_2>; samsung,pin-pud = <FSD_PIN_PULL_UP>; - samsung,pin-drv = <FSD_PIN_DRV_LV1>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* RE: [PATCH v3 4/4] arm64: dts: fix SPI drive strength values as per FSD HW UM 2022-10-13 10:40 ` [PATCH v3 4/4] arm64: dts: fix SPI " Padmanabhan Rajanbabu @ 2022-10-14 1:41 ` Alim Akhtar 0 siblings, 0 replies; 12+ messages in thread From: Alim Akhtar @ 2022-10-14 1:41 UTC (permalink / raw) To: 'Padmanabhan Rajanbabu', robh+dt, krzysztof.kozlowski+dt, chanho61.park, linus.walleij, pankaj.dubey Cc: devicetree, linux-kernel, linux-samsung-soc >-----Original Message----- >From: Padmanabhan Rajanbabu [mailto:p.rajanbabu@samsung.com] >Sent: Thursday, October 13, 2022 4:10 PM >To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; >alim.akhtar@samsung.com; chanho61.park@samsung.com; >linus.walleij@linaro.org; pankaj.dubey@samsung.com >Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >samsung-soc@vger.kernel.org; Padmanabhan Rajanbabu ><p.rajanbabu@samsung.com> >Subject: [PATCH v3 4/4] arm64: dts: fix SPI drive strength values as per FSD >HW UM > >Drive strength values used for SPI is not reflecting the default values >recommended by FSD HW UM. > >Fix the drive strength values for SPI, thereby ensuring that the existing device >tree file is using default drive strength values recommended by UM for FSD >SoC. > >Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support") >Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com> >--- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >index a2634e70925a..e3852c946352 100644 >--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >@@ -323,21 +323,21 @@ > samsung,pins = "gpb4-0", "gpb4-2", "gpb4-3"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > spi1_bus: spi1-bus-pins { > samsung,pins = "gpb4-4", "gpb4-6", "gpb4-7"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > > spi2_bus: spi2-bus-pins { > samsung,pins = "gpb5-0", "gpb5-2", "gpb5-3"; > samsung,pin-function = <FSD_PIN_FUNC_2>; > samsung,pin-pud = <FSD_PIN_PULL_UP>; >- samsung,pin-drv = <FSD_PIN_DRV_LV1>; >+ samsung,pin-drv = <FSD_PIN_DRV_LV4>; > }; > }; > >-- >2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform 2022-10-13 10:40 ` [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform Padmanabhan Rajanbabu ` (3 preceding siblings ...) [not found] ` <CGME20221013110733epcas5p36e0104bfa4da37159da77f9231ff6e2c@epcas5p3.samsung.com> @ 2022-10-18 13:21 ` Krzysztof Kozlowski 2022-10-18 13:21 ` Krzysztof Kozlowski 5 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2022-10-18 13:21 UTC (permalink / raw) To: Padmanabhan Rajanbabu, robh+dt, krzysztof.kozlowski+dt, alim.akhtar, chanho61.park, linus.walleij, pankaj.dubey Cc: devicetree, linux-kernel, linux-samsung-soc On 13/10/2022 06:40, Padmanabhan Rajanbabu wrote: > Padmanabhan Rajanbabu (4): > arm64: dts: fix drive strength macros as per FSD HW UM > arm64: dts: fix HSI2C drive strength values as per FSD HW UM > arm64: dts: fix UART drive strength values as per FSD HW UM > arm64: dts: fix SPI drive strength values as per FSD HW UM > Use subject prefixes matching the subsystem (git log --oneline -- ...). > Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform 2022-10-13 10:40 ` [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform Padmanabhan Rajanbabu ` (4 preceding siblings ...) 2022-10-18 13:21 ` [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform Krzysztof Kozlowski @ 2022-10-18 13:21 ` Krzysztof Kozlowski 2022-10-18 13:25 ` Krzysztof Kozlowski 5 siblings, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2022-10-18 13:21 UTC (permalink / raw) To: chanho61.park, pankaj.dubey, alim.akhtar, linus.walleij, robh+dt, Padmanabhan Rajanbabu, krzysztof.kozlowski+dt Cc: Krzysztof Kozlowski, devicetree, linux-samsung-soc, linux-kernel On Thu, 13 Oct 2022 16:10:20 +0530, Padmanabhan Rajanbabu wrote: > With reference to FSD SoC HW UM, there are some deviations in the > drive strength macros names and macro values. Also the IPs are not > using the default drive strength values as recommended by HW UM. > > FSD SoC pinctrl has following four levels of drive-strength and their > corresponding values: > Level-1 <-> 0 > Level-2 <-> 1 > Level-4 <-> 2 > Level-6 <-> 3 > > [...] Applied, thanks! [1/4] arm64: dts: fix drive strength macros as per FSD HW UM https://git.kernel.org/krzk/linux/c/3a27bce7e13e3b5368377c9a518927e197a4afb1 [2/4] arm64: dts: fix HSI2C drive strength values as per FSD HW UM https://git.kernel.org/krzk/linux/c/bb997d949e5a835f626facfd67b1768fd4492398 [3/4] arm64: dts: fix UART drive strength values as per FSD HW UM https://git.kernel.org/krzk/linux/c/8aa0323c14d546a14cb1d39e38673bda20699f7e [4/4] arm64: dts: fix SPI drive strength values as per FSD HW UM https://git.kernel.org/krzk/linux/c/54e628d4fb24f54d70aa423da485bf5f5ab7260b Best regards, -- Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform 2022-10-18 13:21 ` Krzysztof Kozlowski @ 2022-10-18 13:25 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2022-10-18 13:25 UTC (permalink / raw) To: chanho61.park, pankaj.dubey, alim.akhtar, linus.walleij, robh+dt, Padmanabhan Rajanbabu, krzysztof.kozlowski+dt Cc: devicetree, linux-samsung-soc, linux-kernel On 18/10/2022 09:21, Krzysztof Kozlowski wrote: > On Thu, 13 Oct 2022 16:10:20 +0530, Padmanabhan Rajanbabu wrote: >> With reference to FSD SoC HW UM, there are some deviations in the >> drive strength macros names and macro values. Also the IPs are not >> using the default drive strength values as recommended by HW UM. >> >> FSD SoC pinctrl has following four levels of drive-strength and their >> corresponding values: >> Level-1 <-> 0 >> Level-2 <-> 1 >> Level-4 <-> 2 >> Level-6 <-> 3 >> >> [...] > > Applied, thanks! > > [1/4] arm64: dts: fix drive strength macros as per FSD HW UM > https://git.kernel.org/krzk/linux/c/3a27bce7e13e3b5368377c9a518927e197a4afb1 > [2/4] arm64: dts: fix HSI2C drive strength values as per FSD HW UM > https://git.kernel.org/krzk/linux/c/bb997d949e5a835f626facfd67b1768fd4492398 Fixed subject and squashed last two commits into this one. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-10-18 13:26 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20221013110708epcas5p3c54c22bbc77175eb2a26dc9fd43814d5@epcas5p3.samsung.com>
2022-10-13 10:40 ` [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform Padmanabhan Rajanbabu
[not found] ` <CGME20221013110721epcas5p44cc7dcc5ac2ab8eaf6c472cc87dea06f@epcas5p4.samsung.com>
2022-10-13 10:40 ` [PATCH v3 1/4] arm64: dts: fix drive strength macros as per FSD HW UM Padmanabhan Rajanbabu
2022-10-14 1:38 ` Alim Akhtar
[not found] ` <CGME20221013110725epcas5p1411c422eb2c29494fd5c1e66e09564c5@epcas5p1.samsung.com>
2022-10-13 10:40 ` [PATCH v3 2/4] arm64: dts: fix HSI2C drive strength values " Padmanabhan Rajanbabu
2022-10-14 1:39 ` Alim Akhtar
[not found] ` <CGME20221013110728epcas5p22fb8b83f6cfb4b6a035a9fbb5a38546f@epcas5p2.samsung.com>
2022-10-13 10:40 ` [PATCH v3 3/4] arm64: dts: fix UART " Padmanabhan Rajanbabu
2022-10-14 1:41 ` Alim Akhtar
[not found] ` <CGME20221013110733epcas5p36e0104bfa4da37159da77f9231ff6e2c@epcas5p3.samsung.com>
2022-10-13 10:40 ` [PATCH v3 4/4] arm64: dts: fix SPI " Padmanabhan Rajanbabu
2022-10-14 1:41 ` Alim Akhtar
2022-10-18 13:21 ` [PATCH v3 0/4] arm64: dts: fix drive strength macros and values for FSD Platform Krzysztof Kozlowski
2022-10-18 13:21 ` Krzysztof Kozlowski
2022-10-18 13:25 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).