From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BF3C35240 for ; Wed, 29 Jan 2020 05:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4373D2071E for ; Wed, 29 Jan 2020 05:46:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="fDMDy6S7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725816AbgA2Fqm (ORCPT ); Wed, 29 Jan 2020 00:46:42 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:50140 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbgA2Fqm (ORCPT ); Wed, 29 Jan 2020 00:46:42 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1580276801; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Sender; bh=Uia7eHgmOQeOEXkeVdlnBpq8/eBlSOChehhm3LLPNcE=; b=fDMDy6S7fx+y30zheYqszf6o3M5+Eau5NtEx7ZNzB+lg/zw6K3ThZTBrQhlNe1rTcBIy+H3u DFFvNJAlBUVyULQLf73+J3ZI4YUd8nd7iV72Niw00wkelQaC9nyqvK6a41qrwaNiLDFwuXuW COkK/iKNwnCafTlfhXQ+dUa7awM= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e311c40.7fec0ed46148-smtp-out-n01; Wed, 29 Jan 2020 05:46:40 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 27812C4479C; Wed, 29 Jan 2020 05:46:39 +0000 (UTC) Received: from Pillair (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: pillair) by smtp.codeaurora.org (Postfix) with ESMTPSA id A407AC43383; Wed, 29 Jan 2020 05:46:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A407AC43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=pillair@codeaurora.org From: To: "'Matthias Kaehlcke'" Cc: , , , References: <1580207617-818-1-git-send-email-pillair@codeaurora.org> <20200128192027.GB46072@google.com> In-Reply-To: <20200128192027.GB46072@google.com> Subject: RE: [PATCH v4] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Date: Wed, 29 Jan 2020 11:16:32 +0530 Message-ID: <000601d5d667$78f056d0$6ad10470$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJpUoH9UNBKfyz7+S0TRz+kcMMVewHZ23B3pstalZA= Content-Language: en-us Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Matthias, Please find my replies inline. > -----Original Message----- > From: Matthias Kaehlcke > Sent: Wednesday, January 29, 2020 12:50 AM > To: Rakesh Pillai > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; = linux- > kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org > Subject: Re: [PATCH v4] arm64: dts: qcom: sc7180: Add WCN3990 WLAN > module device node >=20 > Hi Rakesh, >=20 > On Tue, Jan 28, 2020 at 04:03:37PM +0530, Rakesh Pillai wrote: > > Add device node for the ath10k SNOC platform driver probe > > and add resources required for WCN3990 on sc7180 soc. > > > > Signed-off-by: Rakesh Pillai > > --- > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++ > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 > ++++++++++++++++++++++++++++ > > 2 files changed, 33 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > index 189254f..151b489 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > @@ -248,6 +248,11 @@ > > status =3D "okay"; > > }; > > > > +&wifi { > > + status =3D "okay"; > > + qcom,msa-fixed-perm; > > +}; > > + > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > &qup_i2c2_default { > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index 666e9b9..7efb97f 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -42,6 +42,12 @@ > > compatible =3D "qcom,cmd-db"; > > no-map; > > }; > > + > > + wlan_fw_mem: memory@93900000 { > > + compatible =3D "removed-dma-pool"; > > + no-map; > > + reg =3D <0 0x93900000 0 0x200000>; > > + }; > > }; >=20 > This part doesn't apply cleanly on qcom/for-next, looks like you have = to > rebase. [Rakesh]: let me rebase it and send out the next version. >=20 > > cpus { > > @@ -1119,6 +1125,28 @@ > > #clock-cells =3D <1>; > > }; > > }; > > + > > + wifi: wifi@18800000 { >=20 > You added this node at the end of the file, outside of the 'soc' node. > It should be inside the 'soc' node, the sub-nodes are ordered by = address, > so (currently) this node should be inserted after 'cpufreq@18323000'. [Rakesh] Will update this in the next patchset. (Possibly this was = caused due to rebase conflicts) >=20 > > + compatible =3D "qcom,wcn3990-wifi"; > > + reg =3D <0 0x18800000 0 0x800000>; > > + reg-names =3D "membase"; > > + iommus =3D <&apps_smmu 0xC0 0x1>; >=20 > nit: the convention is to use lowercase characters for hex adresses. [Rakesh]: Will change it. >=20 > > + interrupts =3D > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */>, > > + */>; >=20 > not sure these 'CEx' comments after each interrupt add much value. = What > does > 'CE' stand for in the first place? [Rakesh]: CE stands for Copy engine. These are the copy engine = interrupts, hence the comments. >=20 > Thanks >=20 > Matthias