From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Praveenkumar I <quic_ipkumar@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org, vkoul@kernel.org,
kishon@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
gregkh@linuxfoundation.org, catalin.marinas@arm.com,
will@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be,
arnd@arndb.de, neil.armstrong@linaro.org,
nfraprado@collabora.com, u-kumar1@ti.com, peng.fan@nxp.com,
quic_wcheng@quicinc.com, quic_varada@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
quic_kathirav@quicinc.com, quic_nsekar@quicinc.com,
quic_srichara@quicinc.com
Subject: Re: [PATCH 2/8] phy: qcom: Introduce Super-Speed USB UNIPHY driver
Date: Sat, 7 Oct 2023 01:57:55 +0200 [thread overview]
Message-ID: <0007b5ff-34d4-44c0-80bd-8277d5842c01@linaro.org> (raw)
In-Reply-To: <CAA8EJprhQz_Tj0Bhv6zhGa7h37Ug-Fp6Tof9tNscTFyZzkbJvw@mail.gmail.com>
On 3.10.2023 16:54, Dmitry Baryshkov wrote:
> On Tue, 3 Oct 2023 at 17:22, Praveenkumar I <quic_ipkumar@quicinc.com> wrote:
>>
>>
>>
>> On 9/30/2023 10:48 PM, Dmitry Baryshkov wrote:
>>> On 29/09/2023 11:42, Praveenkumar I wrote:
>>>> Adds Qualcomm 22ull Super-Speed USB UNIPHY driver support which
>>>> is present in Qualcomm IPQ5332 SoC. This PHY is interfaced with
>>>> SNPS DWC3 USB and SNPS DWC PCIe. Either one of the interface
>>>> can use the it and selection is done via mux present in TCSR
>>>> register. This driver selects the PHY for DWC3 USB and handles
>>>> the reset, clocks and regulator.
>>>>
>>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>>>> ---
>>>> drivers/phy/qualcomm/Kconfig | 11 +
>>>> drivers/phy/qualcomm/Makefile | 1 +
>>>> drivers/phy/qualcomm/phy-qcom-uniphy-usb.c | 322 +++++++++++++++++++++
>>>> 3 files changed, 334 insertions(+)
>>>> create mode 100644 drivers/phy/qualcomm/phy-qcom-uniphy-usb.c
>>>>
>>>> diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig
>>>> index d891058b7c39..7257c8455c53 100644
>>>> --- a/drivers/phy/qualcomm/Kconfig
>>>> +++ b/drivers/phy/qualcomm/Kconfig
>>>> @@ -154,6 +154,17 @@ config PHY_QCOM_M31_USB
>>>> management. This driver is required even for peripheral only or
>>>> host only mode configurations.
>>>> +config PHY_QCOM_UNIPHY_USB
>>>> + tristate "Qualcomm USB Super-Speed UNIPHY driver"
>>>
>>> Can we please have more specific driver name? As I wrote earlier,
>>> there are two other (different) kinds of Qualcomm UNI PHY devices:
>>> - DSI / HDMI UNIPHY on apq8064 / msm8974 / msm8960 (?)
>>> - USB QMP UNI PHY drivers
>>>
>>> Adding a driver called UNIPHY, which is not related to those two kinds
>>> sounds pretty confusing to me.
>> This UNIPHY is different from above mentioned ones. This a custom
>> version for 22nm on Qualcomm IPQ5332.
>> Can we name the driver as phy-qcom-uniphy-usb-ss-22ull.c /
>> phy-qcom-usb-ss-22ull.c ?
>
> usb-ss-22ull sounds better. Or maybe usb-ipq-ss
usb-ipq-ss is as safe as usb-msm-ss
We can not rely on the hardware never ever changing down the
product line :D
Konrad
next prev parent reply other threads:[~2023-10-06 23:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 8:42 [PATCH 0/8] Enable USB3 for Qualcomm IPQ5332 Praveenkumar I
2023-09-29 8:42 ` [PATCH 1/8] dt-bindings: phy: qcom,uniphy-usb: Document qcom,uniphy-usb phy Praveenkumar I
2023-09-30 14:56 ` Krzysztof Kozlowski
2023-10-03 14:09 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 2/8] phy: qcom: Introduce Super-Speed USB UNIPHY driver Praveenkumar I
2023-09-30 17:18 ` Dmitry Baryshkov
2023-10-03 14:21 ` Praveenkumar I
2023-10-03 14:54 ` Dmitry Baryshkov
2023-10-03 16:33 ` Praveenkumar I
2023-10-06 23:57 ` Konrad Dybcio [this message]
2023-10-09 12:22 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 3/8] arm64: dts: qcom: ipq5332: Add USB Super-Speed PHY node Praveenkumar I
2023-09-29 12:56 ` Konrad Dybcio
2023-09-29 13:30 ` Praveenkumar I
2023-09-30 17:22 ` Dmitry Baryshkov
2023-10-03 14:28 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 4/8] dt-bindings: usb: dwc3: Add clocks on Qualcomm IPQ5332 Praveenkumar I
2023-09-30 14:58 ` Krzysztof Kozlowski
2023-09-30 17:23 ` Dmitry Baryshkov
2023-10-03 14:30 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 5/8] arm64: dts: qcom: ipq5332: Add clocks for USB Super-Speed Praveenkumar I
2023-09-30 17:25 ` Dmitry Baryshkov
2023-10-03 14:42 ` Praveenkumar I
2023-10-03 14:45 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 6/8] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY in USB node Praveenkumar I
2023-09-29 13:14 ` Konrad Dybcio
2023-09-29 13:31 ` Praveenkumar I
2023-09-30 17:26 ` Dmitry Baryshkov
2023-10-03 14:02 ` Praveenkumar I
2023-09-30 17:27 ` Dmitry Baryshkov
2023-10-03 14:42 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 7/8] arm64: dts: qcom: ipq5332: Enable USB Super-Speed PHY Praveenkumar I
2023-09-29 8:42 ` [PATCH 8/8] arm64: defconfig: Enable qcom USB UNIPHY driver Praveenkumar I
2023-09-30 14:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0007b5ff-34d4-44c0-80bd-8277d5842c01@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_nsekar@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).