From: Tony K Nadackal <tony.kn@samsung.com>
To: 'Jacek Anaszewski' <j.anaszewski@samsung.com>
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
mchehab@osg.samsung.com, kgene@kernel.org, k.debski@samsung.com,
s.nawrocki@samsung.com, robh+dt@kernel.org, mark.rutland@arm.com,
bhushan.r@samsung.com
Subject: RE: [PATCH v2 2/2] [media] s5p-jpeg: Adding Exynos7 JPEG variant
Date: Wed, 07 Jan 2015 16:52:51 +0530 [thread overview]
Message-ID: <000801d02a6c$59fdbc60$0df93520$@samsung.com> (raw)
In-Reply-To: <54AD068F.8030001@samsung.com>
Hi Jacek,
On Wednesday, January 07, 2015 3:43 PM : Jacek Anaszewski wrote,
> Hi Tony,
>
> On 12/19/2014 08:38 AM, Tony K Nadackal wrote:
> > Fimp_jpeg used in Exynos7 is a revised version. Some register
> > configurations are slightly different from JPEG in Exynos4.
> > Added one more variant SJPEG_EXYNOS7 to handle these differences.
> >
> > Signed-off-by: Tony K Nadackal <tony.kn@samsung.com>
> > ---
> > .../bindings/media/exynos-jpeg-codec.txt | 2 +-
> > drivers/media/platform/s5p-jpeg/jpeg-core.c | 61
++++++++++++++++++-
> ---
> > drivers/media/platform/s5p-jpeg/jpeg-core.h | 10 ++--
> > drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 32 ++++++------
> > drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.h | 8 +--
> > drivers/media/platform/s5p-jpeg/jpeg-regs.h | 17 ++++--
> > 6 files changed, 93 insertions(+), 37 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> > b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> > index bf52ed4..cd19417 100644
> > --- a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> > +++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> > @@ -4,7 +4,7 @@ Required properties:
> >
> > - compatible : should be one of:
> > "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg",
> > - "samsung,exynos3250-jpeg";
> > + "samsung,exynos3250-jpeg", "samsung,exynos7-jpeg";
> > - reg : address and length of the JPEG codec IP register set;
> > - interrupts : specifies the JPEG codec IP interrupt;
> > - clock-names : should contain:
>
> This should be put in a separate patch.
Checkpatch gives warning if this change is not there.
If that is ok with you, I will make this change a separate patch.
[snip]
> --
> Best Regards,
> Jacek Anaszewski
Thanks and Regards,
Tony
next prev parent reply other threads:[~2015-01-07 11:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 7:37 [PATCH v2 0/2] Adding support for Exynos7 Jpeg variant Tony K Nadackal
2014-12-19 7:37 ` [PATCH v2 1/2] [media] s5p-jpeg: Fix modification sequence of interrupt enable register Tony K Nadackal
2015-01-07 10:08 ` Jacek Anaszewski
2015-01-07 11:46 ` Tony K Nadackal
2014-12-19 7:38 ` [PATCH v2 2/2] [media] s5p-jpeg: Adding Exynos7 JPEG variant Tony K Nadackal
2015-01-07 10:12 ` Jacek Anaszewski
2015-01-07 11:22 ` Tony K Nadackal [this message]
2015-01-07 12:11 ` Jacek Anaszewski
2015-01-05 5:15 ` [PATCH v2 0/2] Adding support for Exynos7 Jpeg variant Tony K Nadackal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000801d02a6c$59fdbc60$0df93520$@samsung.com' \
--to=tony.kn@samsung.com \
--cc=bhushan.r@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=j.anaszewski@samsung.com \
--cc=k.debski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).