From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Rob Herring'" <robh@kernel.org>
Cc: "'Alim Akhtar'" <alim.akhtar@samsung.com>,
"'Avri Altman'" <avri.altman@wdc.com>,
"'James E . J . Bottomley'" <jejb@linux.ibm.com>,
"'Martin K . Petersen'" <martin.petersen@oracle.com>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
"'Bean Huo'" <beanhuo@micron.com>,
"'Bart Van Assche'" <bvanassche@acm.org>,
"'Adrian Hunter'" <adrian.hunter@intel.com>,
"'Christoph Hellwig'" <hch@infradead.org>,
"'Can Guo'" <cang@codeaurora.org>,
"'Jaegeuk Kim'" <jaegeuk@kernel.org>,
"'Gyunghoon Kwon'" <goodjob.kwon@samsung.com>,
<linux-samsung-soc@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: RE: [PATCH v3 05/17] dt-bindings: ufs: exynos-ufs: add sysreg regmap property
Date: Thu, 23 Sep 2021 09:47:44 +0900 [thread overview]
Message-ID: <000801d7b014$9ed9fe40$dc8dfac0$@samsung.com> (raw)
In-Reply-To: <YUuKpSPgdKl2CiSy@robh.at.kernel.org>
> > + sysreg:
>
> Needs a vendor prefix.
Thanks. I'll use "samsung,sysreg-phandle".
>
> > + $ref: '/schemas/types.yaml#/definitions/phandle'
> > + description: phandle for FSYS sysreg interface, used to control
> > + sysreg register bit for UFS IO Coherency
>
> Is there more than 1 FSYS? If not, you can just get the node by its
> compatible.
The phandle can be differed each exynos SoCs, AFAIK. I think other exynos
SoCs since exnos7 will need this but not upstreamed yet...
>
> Also, what about 'dma-coherent' property? The driver core needs to know.
Yes. 'dma-coherent' should be listed as well.
Best Regards,
Chanho Park
next prev parent reply other threads:[~2021-09-23 0:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210917065436.145629-1-chanho61.park@samsung.com>
[not found] ` <CGME20210917065523epcas2p3ff66daa15c8c782f839422756c388d93@epcas2p3.samsung.com>
2021-09-17 6:54 ` [PATCH v3 05/17] dt-bindings: ufs: exynos-ufs: add sysreg regmap property Chanho Park
2021-09-22 19:57 ` Rob Herring
2021-09-23 0:47 ` Chanho Park [this message]
2021-09-23 12:39 ` Rob Herring
2021-09-24 1:10 ` Chanho Park
[not found] ` <CGME20210917065524epcas2p455b2900227b6a20994bec4816248f2bf@epcas2p4.samsung.com>
2021-09-17 6:54 ` [PATCH v3 17/17] dt-bindings: ufs: exynos-ufs: add exynosautov9 compatible Chanho Park
2021-09-22 19:58 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000801d7b014$9ed9fe40$dc8dfac0$@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=goodjob.kwon@samsung.com \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).