[PATCH] ASoC: dt-bindings: wm8974: Convert to dtschema

[PATCH] ASoC: dt-bindings: wm8974: Convert to dtschema

[Kartik Agarwala]

Convert WM8974 audio CODEC bindings from text to dtschema.

Signed-off-by: Kartik Agarwala <agarwala.kartik@gmail.com>
---
 .../devicetree/bindings/sound/wlf,wm8974.txt  | 15 -------
 .../devicetree/bindings/sound/wlf,wm8974.yaml | 41 +++++++++++++++++++
 2 files changed, 41 insertions(+), 15 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.yaml

diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8974.txt b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
deleted file mode 100644
index 01d3a7c83..000000000
--- a/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
+++ /dev/null
@@ -1,15 +0,0 @@
-WM8974 audio CODEC
-
-This device supports both I2C and SPI (configured with pin strapping
-on the board).
-
-Required properties:
-  - compatible: "wlf,wm8974"
-  - reg: the I2C address or SPI chip select number of the device
-
-Examples:
-
-codec: wm8974@1a {
-	compatible = "wlf,wm8974";
-	reg = <0x1a>;
-};
diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8974.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8974.yaml
new file mode 100644
index 000000000..d27300207
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8974.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8974.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: WM8974 audio CODEC
+
+maintainers:
+  - patches@opensource.cirrus.com
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    const: wlf,wm8974
+
+  reg:
+    maxItems: 1
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@1a {
+            compatible = "wlf,wm8974";
+            reg = <0x1a>;
+        };
+    };
-- 
2.34.1

Re: [PATCH] ASoC: dt-bindings: wm8974: Convert to dtschema

[Krzysztof Kozlowski]

On 25/03/2024 19:19, Kartik Agarwala wrote:
> Convert WM8974 audio CODEC bindings from text to dtschema.
> 
> Signed-off-by: Kartik Agarwala <agarwala.kartik@gmail.com>

Thank you for your patch. There are no DTS users of this binding, so
while such conversions are useful, they have significantly smaller
impact. In the future, please consider converting bindings from active
platforms (arm64 defconfig, arm multi_v7). This would have significantly
bigger impact.

See also:
https://lore.kernel.org/all/6552bcb8-e046-4882-91da-1094fff3d239@linaro.org/

> ---
>  .../devicetree/bindings/sound/wlf,wm8974.txt  | 15 -------
>  .../devicetree/bindings/sound/wlf,wm8974.yaml | 41 +++++++++++++++++++
>  2 files changed, 41 insertions(+), 15 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.yaml
> 

...

> +  "#sound-dai-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        codec@1a {
> +            compatible = "wlf,wm8974";
> +            reg = <0x1a>;

In the future for other patches like this, make example complete, so add
a dai-cells also here.

No need to resend just for that.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH] ASoC: dt-bindings: wm8974: Convert to dtschema

[Kartik Agarwala]

On 3/26/24 1:00 AM, Krzysztof Kozlowski wrote:
> On 25/03/2024 19:19, Kartik Agarwala wrote:
>> Convert WM8974 audio CODEC bindings from text to dtschema.
>>
>> Signed-off-by: Kartik Agarwala <agarwala.kartik@gmail.com>
> 
> Thank you for your patch. There are no DTS users of this binding, so
> while such conversions are useful, they have significantly smaller
> impact. In the future, please consider converting bindings from active
> platforms (arm64 defconfig, arm multi_v7). This would have significantly
> bigger impact.
> 
> See also:
> https://lore.kernel.org/all/6552bcb8-e046-4882-91da-1094fff3d239@linaro.org/

Noted, thanks for letting me know.

Regards,
Kartik Agarwala

Re: [PATCH] ASoC: dt-bindings: wm8974: Convert to dtschema

[Mark Brown]

On Mon, 25 Mar 2024 23:49:42 +0530, Kartik Agarwala wrote:
> Convert WM8974 audio CODEC bindings from text to dtschema.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: wm8974: Convert to dtschema
      commit: b340f56a74b62d8ce8617650c8ab4a26c87ba5c5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark