From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A1DEC43603 for ; Thu, 19 Dec 2019 05:57:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 279F4227BF for ; Thu, 19 Dec 2019 05:57:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Djp2JghR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725844AbfLSF5d (ORCPT ); Thu, 19 Dec 2019 00:57:33 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:61481 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbfLSF5c (ORCPT ); Thu, 19 Dec 2019 00:57:32 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576735052; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Sender; bh=gij6s46FDaVHWH1PKbNbofgZ7vDlisgHp23/Qe0e81A=; b=Djp2JghR/DTf6gNrluKZR6JZ5I+8Y29XBb0b0X1kAxUGtlQvmDS4xJXfZKd8FKhh3zwwi3go eibBCh4LhL2shjmS0dE8pmiRxow8gtPGyJKSiio/uNuXz7iRPlhswpK5AC+eS+QTmTAzexGN I2OPrW9DNoAOuhi1YzcZgR1m9Zk= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5dfb1148.7f5b1df62030-smtp-out-n01; Thu, 19 Dec 2019 05:57:28 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A7E9BC48B02; Thu, 19 Dec 2019 05:57:27 +0000 (UTC) Received: from Pillair (unknown [183.83.68.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: pillair) by smtp.codeaurora.org (Postfix) with ESMTPSA id B9B8BC3863A; Thu, 19 Dec 2019 05:57:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B9B8BC3863A Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=pillair@codeaurora.org From: To: "'Bjorn Andersson'" Cc: , , , References: <0101016ed018cde9-da3dc3e0-de6e-4b18-9add-bc6f88511ab2-000000@us-west-2.amazonses.com> <20191211072053.GH3143381@builder> In-Reply-To: <20191211072053.GH3143381@builder> Subject: RE: [PATCH] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Date: Thu, 19 Dec 2019 11:27:20 +0530 Message-ID: <000b01d5b631$30ae26f0$920a74d0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQMb6H2dXQ8o6wUj3EGWt532+Zf66wHvDMacpSUYhgA= Content-Language: en-us Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org I will raise the next patchset with the comments addressed. > -----Original Message----- > From: Bjorn Andersson > Sent: Wednesday, December 11, 2019 12:51 PM > To: Rakesh Pillai > Cc: devicetree@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module > device node > > On Wed 04 Dec 00:48 PST 2019, Rakesh Pillai wrote: > > > Add device node for the ath10k SNOC platform driver probe > > and add resources required for WCN3990 on sc7180 soc. > > > > Signed-off-by: Rakesh Pillai > > --- > > This change is dependent on the below set of changes > > arm64: dts: sc7180: Add qupv3_0 and qupv3_1 > (https://lore.kernel.org/patchwork/patch/1150367/) > > Why? The mentioned series of patchset brings the DTSI for sc7180. Hence the addition of wifi node is dependent on this series https://lore.kernel.org/patchwork/patch/1150367/ > > > --- > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 4 ++++ > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 > +++++++++++++++++++++++++++ > > 2 files changed, 31 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > index 189254f..8a6a760 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > @@ -248,6 +248,10 @@ > > status = "okay"; > > }; > > > > +&wifi { > > + status = "okay"; > > Please conclude on the representation of the "skip-hyp-mem-assign" and > add it here, rather than in a subsequent patch - which implies that this > patch doesn't work on its own. Sure, I will update the next patchset. > > > +}; > > + > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > &qup_i2c2_default { > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index 666e9b9..40c9971 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -42,6 +42,12 @@ > > compatible = "qcom,cmd-db"; > > no-map; > > }; > > + > > + wlan_fw_mem: wlan_fw_region@93900000 { > > wlan_fw_mem: memory@93900000 { > > > + compatible = "removed-dma-pool"; > > + no-map; > > + reg = <0 0x93900000 0 0x200000>; > > + }; > > }; > > > > cpus { > > @@ -1119,6 +1125,27 @@ > > #clock-cells = <1>; > > }; > > }; > > + > > + wifi: wifi@18800000 { > > + status = "disabled"; > > + compatible = "qcom,wcn3990-wifi"; > > + reg = <0 0x18800000 0 0x800000>; > > + reg-names = "membase"; > > + interrupts = > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */>, > > + */>; > > + memory-region = <&wlan_fw_mem>; > > No iommus in sc7180? > > Regards, > Bjorn > > > + }; > > }; > > > > timer { > > -- > > 2.7.4 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel