From: <markus.stockhausen@gmx.de>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
<linux-phy@lists.infradead.org>,
<chris.packham@alliedtelesis.co.nz>, <devicetree@vger.kernel.org>
Subject: AW: [PATCH v2 1/3] dt-bindings: phy: add realtek,otto-serdes PHY binding
Date: Tue, 8 Oct 2024 07:38:51 +0200 [thread overview]
Message-ID: <000b01db1944$5bd444b0$137cce10$@gmx.de> (raw)
In-Reply-To: <e0355f2b-9d77-4792-9405-14b0bf79ac32@kernel.org>
> -----Ursprüngliche Nachricht-----
> Von: Krzysztof Kozlowski <krzk@kernel.org>
> Gesendet: Montag, 7. Oktober 2024 21:26
> An: Markus Stockhausen <markus.stockhausen@gmx.de>; linux-phy@lists.infradead.org; chris.packham@alliedtelesis.co.nz; devicetree@vger.kernel.org
> Betreff: Re: [PATCH v2 1/3] dt-bindings: phy: add realtek,otto-serdes PHY binding
>
> ... and still not tested. Sending untested code is waste of our time.
Hi Krzysztof,
appreciate your feedback and I do not want to waste your time. My fixes where a mix
of your feedback and some half-baked "make dt_binding_check" feedbacks (because
packages where missing). My fault and sorry fort he noise.
To get next version in better shape two questions regarding your feedback:
1. "Messed wrapping": According to checkpatch 100 chars/line are accepted.
So I designed the comments in the driver. Does devicetree differ from that?
2 "Bindings vs drivers". The idea about controlled ports came from other bindings.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/st,stih407-irq-syscfg.yaml?h=v6.12-rc2
E.g. st,invert-ext. Something like this will be needed in the future because the
SerDes allow to swap polarity which must be changed depending on the switch
design. How to do this?
Best regards.
Markus
next prev parent reply other threads:[~2024-10-08 5:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 16:36 [PATCH v2 0/3] phy: Realtek Otto SerDes: add new driver Markus Stockhausen
2024-10-07 16:36 ` [PATCH v2 1/3] dt-bindings: phy: add realtek,otto-serdes PHY binding Markus Stockhausen
2024-10-07 18:17 ` Rob Herring (Arm)
2024-10-07 19:26 ` Krzysztof Kozlowski
2024-10-08 5:38 ` markus.stockhausen [this message]
2024-10-08 6:17 ` AW: " Krzysztof Kozlowski
2024-10-08 6:56 ` AW: " markus.stockhausen
2024-10-08 8:32 ` Krzysztof Kozlowski
2024-10-08 9:27 ` AW: " markus.stockhausen
2024-10-16 15:30 ` markus.stockhausen
2024-10-17 6:15 ` Krzysztof Kozlowski
2024-10-07 19:30 ` Rob Herring
2024-10-08 12:27 ` AW: " markus.stockhausen
2024-10-08 7:04 ` Krzysztof Kozlowski
2024-10-08 7:06 ` Krzysztof Kozlowski
2024-10-07 16:36 ` [PATCH v2 2/3] phy: Realtek Otto SerDes driver Markus Stockhausen
2024-10-07 19:32 ` Krzysztof Kozlowski
2024-10-07 16:36 ` [PATCH v2 3/3] phy: Integrate Realtek Otto SerDes driver into build system Markus Stockhausen
2024-10-07 19:27 ` Krzysztof Kozlowski
2024-10-08 6:38 ` kernel test robot
2024-10-08 7:20 ` kernel test robot
2024-10-08 8:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01db1944$5bd444b0$137cce10$@gmx.de' \
--to=markus.stockhausen@gmx.de \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-phy@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).