From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [PATCH v3 1/5] PCI: designware: add rd[wr]_other_conf API Date: Tue, 08 Jul 2014 21:17:13 +0900 Message-ID: <000d01cf9aa6$8cdee420$a69cac60$%han@samsung.com> References: <1404164720-11066-1-git-send-email-m-karicheri2@ti.com> <1404164720-11066-2-git-send-email-m-karicheri2@ti.com> <2CC2A0A4A178534D93D5159BF3BCB661A17A3E4282@EAPEX1MAIL1.st.com> <53BAD09C.8010505@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <53BAD09C.8010505@ti.com> Content-language: ko Sender: linux-pci-owner@vger.kernel.org To: 'Murali Karicheri' , 'Mohit KUMAR DCG' Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, 'Santosh Shilimkar' , 'Russell King' , 'Grant Likely' , 'Rob Herring' , 'Bjorn Helgaas' , 'Pratyush ANAND' , 'Richard Zhu' , 'Kishon Vijay Abraham I' , 'Marek Vasut' , 'Arnd Bergmann' , 'Pawel Moll' , 'Mark Rutland' , 'Ian Campbell' , 'Kumar Gala' , 'Randy Dunlap' , 'Jingoo Han' List-Id: devicetree@vger.kernel.org On Tuesday, July 08, 2014 1:54 AM, Murali Karicheri wrote: > On 07/07/2014 12:11 AM, Mohit KUMAR DCG wrote: > > On Tuesday, July 01, 2014 3:15 AM, Murali Karicheri wrote: > >> > >> v3.65 version of the designware h/w, requires application space registers to > >> be configured to access the remote EP config space. > >> To support this, add rd[wr]_other_conf API in the pcie_host_opts > >> > >> Signed-off-by: Murali Karicheri > >> > >> CC: Santosh Shilimkar > >> CC: Russell King > >> CC: Grant Likely > >> CC: Rob Herring > >> CC: Mohit Kumar > >> CC: Jingoo Han > >> CC: Bjorn Helgaas > >> CC: Pratyush Anand > >> CC: Richard Zhu > >> CC: Kishon Vijay Abraham I > >> CC: Marek Vasut > >> CC: Arnd Bergmann > >> CC: Pawel Moll > >> CC: Mark Rutland > >> CC: Ian Campbell > >> CC: Kumar Gala > >> CC: Randy Dunlap > >> CC: Grant Likely > >> --- > >> drivers/pci/host/pcie-designware.c | 12 ++++++++++-- > >> drivers/pci/host/pcie-designware.h | 4 ++++ > >> 2 files changed, 14 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie- > >> designware.c > >> index 1eaf4df..d8f3af7 100644 > >> --- a/drivers/pci/host/pcie-designware.c > >> +++ b/drivers/pci/host/pcie-designware.c > >> @@ -656,7 +656,11 @@ static int dw_pcie_rd_conf(struct pci_bus *bus, u32 > >> devfn, int where, > >> } > >> > >> if (bus->number != pp->root_bus_nr) > >> - ret = dw_pcie_rd_other_conf(pp, bus, devfn, > >> + if (pp->ops->rd_other_conf) > >> + ret = pp->ops->rd_other_conf(pp, bus, devfn, > >> + where, size, val); > >> + else > >> + ret = dw_pcie_rd_other_conf(pp, bus, devfn, > >> where, size, val); > >> else > >> ret = dw_pcie_rd_own_conf(pp, where, size, val); @@ - > >> 679,7 +683,11 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 > >> devfn, > >> return PCIBIOS_DEVICE_NOT_FOUND; > >> > >> if (bus->number != pp->root_bus_nr) > >> - ret = dw_pcie_wr_other_conf(pp, bus, devfn, > >> + if (pp->ops->wr_other_conf) > >> + ret = pp->ops->wr_other_conf(pp, bus, devfn, > >> + where, size, val); > >> + else > >> + ret = dw_pcie_wr_other_conf(pp, bus, devfn, > >> where, size, val); > >> else > >> ret = dw_pcie_wr_own_conf(pp, where, size, val); diff --git > >> a/drivers/pci/host/pcie-designware.h b/drivers/pci/host/pcie-designware.h > >> index 77f592f..8121901 100644 > >> --- a/drivers/pci/host/pcie-designware.h > >> +++ b/drivers/pci/host/pcie-designware.h > >> @@ -61,6 +61,10 @@ struct pcie_host_ops { > >> u32 val, void __iomem *dbi_base); > >> int (*rd_own_conf)(struct pcie_port *pp, int where, int size, u32 > >> *val); > >> int (*wr_own_conf)(struct pcie_port *pp, int where, int size, u32 > >> val); > >> + int (*rd_other_conf)(struct pcie_port *pp, struct pci_bus *bus, > >> + unsigned int devfn, int where, int size, u32 *val); > >> + int (*wr_other_conf)(struct pcie_port *pp, struct pci_bus *bus, > >> + unsigned int devfn, int where, int size, u32 val); > >> int (*link_up)(struct pcie_port *pp); > >> void (*host_init)(struct pcie_port *pp); }; > > > > - Now it looks good to me. > > > > Acked-by: Mohit Kumar > > > > Regards > > Mohit > >> -- > >> 1.7.9.5 > > > Mohit, > > Thanks. > > Jingoo, could you provide your response or Ack? Acked-by: Jingoo Han Best regards, Jingoo Han > > Thanks > Murali > --