[PATCH v4 0/2] arm64: dts: Add SYSREG nodes for FSD SoC

[PATCH v4 0/2] arm64: dts: Add SYSREG nodes for FSD SoC

[Sriranjani P]

FSD has few system controller register blocks. This patch series intends to
add support of device node for system controller registers group that
resides in PERIC, FSYS0, FSYS1 and CAM blocks of FSD SoC. As these will
be used by PCIE, EQoS and CSI module. Patches for adding support for PCIE,
EQoS and CSI are already under review at [1], [2] and [3].

Also this patch series add required DT bindings for such system controller
of FSD SoC.

[1]: https://lkml.org/lkml/2022/11/21/463
[2]: https://lkml.org/lkml/2022/11/4/420
[3]: https://lkml.org/lkml/2022/11/20/363

These changes are made on top of Krzysztof's patches [4] posted as part of
splitting Samsung Exynos SoC SYSREG bindings to own file.

[4]: https://lkml.org/lkml/2022/11/25/370

Changes since v3:
1. As per update from Krzysztof, add dedicated compatibles for sysreg found
on FSD SoC in the exynos-sysreg.yaml file.
2. Add CAM block sysreg changes in the dtsi file and respective compatible
in binding document.

Changes since v2:
1. Updated compatibles as per improvements suggested by Krzysztof.

Changes since v1:
1. Fixed SoB in [PATCH 1/2] dt-bindings: mfd: syscon: Add tesla compatible
found on FSD SoC.
2. Address review comments from Krzysztof on [PATCH 2/2] and aligned sysreg
node near to respective blocks sorted in order of unit address.

Sriranjani P (2):
  dt-bindings: soc: samsung: exynos-sysreg: Add tesla FSD sysreg
    compatibles
  arm64: dts: fsd: add sysreg device node

 .../soc/samsung/samsung,exynos-sysreg.yaml    |  4 ++++
 arch/arm64/boot/dts/tesla/fsd.dtsi            | 20 +++++++++++++++++++
 2 files changed, 24 insertions(+)

-- 
2.17.1

[PATCH v4 1/2] dt-bindings: soc: samsung: exynos-sysreg: Add tesla FSD sysreg compatibles

[Sriranjani P]

Add compatible for Tesla SYSREG controllers found on FSD SoC.

Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
 .../bindings/soc/samsung/samsung,exynos-sysreg.yaml           | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index e7c80dd73081..4954790eda6c 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -19,6 +19,10 @@ properties:
               - samsung,exynos5-sysreg
               - samsung,exynos850-sysreg
               - samsung,exynosautov9-sysreg
+              - tesla,fsd-cam-sysreg
+              - tesla,fsd-fsys0-sysreg
+              - tesla,fsd-fsys1-sysreg
+              - tesla,fsd-peric-sysreg
           - const: syscon
       - items:
           - enum:
-- 
2.17.1

RE: [PATCH v4 1/2] dt-bindings: soc: samsung: exynos-sysreg: Add tesla FSD sysreg compatibles

[Ravi Patel]

>-----Original Message-----
>From: Sriranjani P [mailto:sriranjani.p@samsung.com]
>Sent: 29 November 2022 17:26
>To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
>devicetree@vger.kernel.org; alim.akhtar@samsung.com;
>pankaj.dubey@samsung.com; ravi.patel@samsung.com;
>sathya@samsung.com
>Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
>samsung-soc@vger.kernel.org; Sriranjani P <sriranjani.p@samsung.com>
>Subject: [PATCH v4 1/2] dt-bindings: soc: samsung: exynos-sysreg: Add tesla
>FSD sysreg compatibles
>
>Add compatible for Tesla SYSREG controllers found on FSD SoC.
>
>Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
>---
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml           | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git
>a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>index e7c80dd73081..4954790eda6c 100644
>--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>@@ -19,6 +19,10 @@ properties:
>               - samsung,exynos5-sysreg
>               - samsung,exynos850-sysreg
>               - samsung,exynosautov9-sysreg
>+              - tesla,fsd-cam-sysreg
>+              - tesla,fsd-fsys0-sysreg
>+              - tesla,fsd-fsys1-sysreg
>+              - tesla,fsd-peric-sysreg
>           - const: syscon
>       - items:
>           - enum:
>--
>2.17.1

Reviewed-by: Ravi Patel <ravi.patel@samsung.com>

[PATCH v4 2/2] arm64: dts: fsd: add sysreg device node

[Sriranjani P]

Add SYSREG controller device node, which is available in PERIC, FSYS0,
FSYS1 and CAM block of FSD SoC.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
 arch/arm64/boot/dts/tesla/fsd.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
index f35bc5a288c2..ff625fb71fbe 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -466,6 +466,11 @@
 			clock-names = "fin_pll";
 		};
 
+		sysreg_cam: system-controller@12630000 {
+			compatible = "tesla,fsd-cam-sysreg", "syscon";
+			reg = <0x0 0x12630000 0x0 0x500>;
+		};
+
 		clock_mfc: clock-controller@12810000 {
 			compatible = "tesla,fsd-clock-mfc";
 			reg = <0x0 0x12810000 0x0 0x3000>;
@@ -492,6 +497,11 @@
 				"dout_cmu_peric_shared1div4_dmaclk";
 		};
 
+		sysreg_peric: system-controller@14030000 {
+			compatible = "tesla,fsd-peric-sysreg", "syscon";
+			reg = <0x0 0x14030000 0x0 0x1000>;
+		};
+
 		clock_fsys0: clock-controller@15010000 {
 			compatible = "tesla,fsd-clock-fsys0";
 			reg = <0x0 0x15010000 0x0 0x3000>;
@@ -506,6 +516,11 @@
 				"dout_cmu_fsys0_shared0div4";
 		};
 
+		sysreg_fsys0: system-controller@15030000 {
+			compatible = "tesla,fsd-fsys0-sysreg", "syscon";
+			reg = <0x0 0x15030000 0x0 0x1000>;
+		};
+
 		clock_fsys1: clock-controller@16810000 {
 			compatible = "tesla,fsd-clock-fsys1";
 			reg = <0x0 0x16810000 0x0 0x3000>;
@@ -518,6 +533,11 @@
 				"dout_cmu_fsys1_shared0div4";
 		};
 
+		sysreg_fsys1: system-controller@16830000 {
+			compatible = "tesla,fsd-fsys1-sysreg", "syscon";
+			reg = <0x0 0x16830000 0x0 0x1000>;
+		};
+
 		mdma0: dma-controller@10100000 {
 			compatible = "arm,pl330", "arm,primecell";
 			reg = <0x0 0x10100000 0x0 0x1000>;
-- 
2.17.1

RE: [PATCH v4 2/2] arm64: dts: fsd: add sysreg device node

[Ravi Patel]

>-----Original Message-----
>From: Sriranjani P [mailto:sriranjani.p@samsung.com]
>Sent: 29 November 2022 17:26
>To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
>devicetree@vger.kernel.org; alim.akhtar@samsung.com;
>pankaj.dubey@samsung.com; ravi.patel@samsung.com;
>sathya@samsung.com
>Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
>samsung-soc@vger.kernel.org; Sriranjani P <sriranjani.p@samsung.com>
>Subject: [PATCH v4 2/2] arm64: dts: fsd: add sysreg device node
>
>Add SYSREG controller device node, which is available in PERIC, FSYS0,
>FSYS1 and CAM block of FSD SoC.
>
>Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
>---
> arch/arm64/boot/dts/tesla/fsd.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
>b/arch/arm64/boot/dts/tesla/fsd.dtsi
>index f35bc5a288c2..ff625fb71fbe 100644
>--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
>+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
>@@ -466,6 +466,11 @@
> 			clock-names = "fin_pll";
> 		};
>
>+		sysreg_cam: system-controller@12630000 {
>+			compatible = "tesla,fsd-cam-sysreg", "syscon";
>+			reg = <0x0 0x12630000 0x0 0x500>;
>+		};
>+
> 		clock_mfc: clock-controller@12810000 {
> 			compatible = "tesla,fsd-clock-mfc";
> 			reg = <0x0 0x12810000 0x0 0x3000>;
>@@ -492,6 +497,11 @@
> 				"dout_cmu_peric_shared1div4_dmaclk";
> 		};
>
>+		sysreg_peric: system-controller@14030000 {
>+			compatible = "tesla,fsd-peric-sysreg", "syscon";
>+			reg = <0x0 0x14030000 0x0 0x1000>;
>+		};
>+
> 		clock_fsys0: clock-controller@15010000 {
> 			compatible = "tesla,fsd-clock-fsys0";
> 			reg = <0x0 0x15010000 0x0 0x3000>;
>@@ -506,6 +516,11 @@
> 				"dout_cmu_fsys0_shared0div4";
> 		};
>
>+		sysreg_fsys0: system-controller@15030000 {
>+			compatible = "tesla,fsd-fsys0-sysreg", "syscon";
>+			reg = <0x0 0x15030000 0x0 0x1000>;
>+		};
>+
> 		clock_fsys1: clock-controller@16810000 {
> 			compatible = "tesla,fsd-clock-fsys1";
> 			reg = <0x0 0x16810000 0x0 0x3000>;
>@@ -518,6 +533,11 @@
> 				"dout_cmu_fsys1_shared0div4";
> 		};
>
>+		sysreg_fsys1: system-controller@16830000 {
>+			compatible = "tesla,fsd-fsys1-sysreg", "syscon";
>+			reg = <0x0 0x16830000 0x0 0x1000>;
>+		};
>+
> 		mdma0: dma-controller@10100000 {
> 			compatible = "arm,pl330", "arm,primecell";
> 			reg = <0x0 0x10100000 0x0 0x1000>;
>--
>2.17.1

Reviewed-by: Ravi Patel <ravi.patel@samsung.com>

RE: [PATCH v4 0/2] arm64: dts: Add SYSREG nodes for FSD SoC

[Sriranjani P]

Hi all,

Gentle Reminder to review this patch series.

Thanks,
Sriranjani P.

> -----Original Message-----
> From: Sriranjani P [mailto:sriranjani.p@samsung.com]
> Sent: 29 November 2022 17:25
> To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> devicetree@vger.kernel.org; alim.akhtar@samsung.com;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com;
> sathya@samsung.com
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> linux-samsung-soc@vger.kernel.org; Sriranjani P
> <sriranjani.p@samsung.com>
> Subject: [PATCH v4 0/2] arm64: dts: Add SYSREG nodes for FSD SoC
> 
> FSD has few system controller register blocks. This patch series intends to
> add support of device node for system controller registers group that resides
> in PERIC, FSYS0, FSYS1 and CAM blocks of FSD SoC. As these will be used by
> PCIE, EQoS and CSI module. Patches for adding support for PCIE, EQoS and
> CSI are already under review at [1], [2] and [3].
> 
> Also this patch series add required DT bindings for such system controller of
> FSD SoC.
> 
> [1]: https://lkml.org/lkml/2022/11/21/463
> [2]: https://lkml.org/lkml/2022/11/4/420
> [3]: https://lkml.org/lkml/2022/11/20/363
> 
> These changes are made on top of Krzysztof's patches [4] posted as part of
> splitting Samsung Exynos SoC SYSREG bindings to own file.
> 
> [4]: https://lkml.org/lkml/2022/11/25/370
> 
> Changes since v3:
> 1. As per update from Krzysztof, add dedicated compatibles for sysreg found
> on FSD SoC in the exynos-sysreg.yaml file.
> 2. Add CAM block sysreg changes in the dtsi file and respective compatible in
> binding document.
> 
> Changes since v2:
> 1. Updated compatibles as per improvements suggested by Krzysztof.
> 
> Changes since v1:
> 1. Fixed SoB in [PATCH 1/2] dt-bindings: mfd: syscon: Add tesla compatible
> found on FSD SoC.
> 2. Address review comments from Krzysztof on [PATCH 2/2] and aligned
> sysreg node near to respective blocks sorted in order of unit address.
> 
> Sriranjani P (2):
>   dt-bindings: soc: samsung: exynos-sysreg: Add tesla FSD sysreg
>     compatibles
>   arm64: dts: fsd: add sysreg device node
> 
>  .../soc/samsung/samsung,exynos-sysreg.yaml    |  4 ++++
>  arch/arm64/boot/dts/tesla/fsd.dtsi            | 20 +++++++++++++++++++
>  2 files changed, 24 insertions(+)
> 
> --
> 2.17.1

Re: [PATCH v4 0/2] arm64: dts: Add SYSREG nodes for FSD SoC

[Krzysztof Kozlowski]

On 06/12/2022 09:57, Sriranjani P wrote:
> Hi all,
> 
> Gentle Reminder to review this patch series.
> 

If you ping me, then:
1. Pinging after a week is a bit too fast. Standard is 2 weeks.
2. It is too late in the cycle for me to pick it up. I will take it
after the merge window. Anything sent after rc5 usually misses upcoming
merge window.

Best regards,
Krzysztof

Re: [PATCH v4 0/2] arm64: dts: Add SYSREG nodes for FSD SoC

[Krzysztof Kozlowski]

On Tue, 29 Nov 2022 17:25:29 +0530, Sriranjani P wrote:
> FSD has few system controller register blocks. This patch series intends to
> add support of device node for system controller registers group that
> resides in PERIC, FSYS0, FSYS1 and CAM blocks of FSD SoC. As these will
> be used by PCIE, EQoS and CSI module. Patches for adding support for PCIE,
> EQoS and CSI are already under review at [1], [2] and [3].
> 
> Also this patch series add required DT bindings for such system controller
> of FSD SoC.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: soc: samsung: exynos-sysreg: Add tesla FSD sysreg compatibles
      https://git.kernel.org/krzk/linux/c/7e03ca7429b23105b740eb79364dc410f214848b
[2/2] arm64: dts: fsd: add sysreg device node
      https://git.kernel.org/krzk/linux/c/beaf55952d46fb14387d92de280bed7985ea85e5

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>