From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AEDEC0015E for ; Sat, 5 Aug 2023 21:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230100AbjHEVGu (ORCPT ); Sat, 5 Aug 2023 17:06:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbjHEVGt (ORCPT ); Sat, 5 Aug 2023 17:06:49 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0E0EF3 for ; Sat, 5 Aug 2023 14:06:48 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fe167d4a18so31280975e9.0 for ; Sat, 05 Aug 2023 14:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691269607; x=1691874407; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7bQWyorKrsAyTYwSEr05KzsqtWIhFwBSuW+LToiflyQ=; b=urnNl0V9kas1yV3Bnm4XUiLjXd3e7p1tpR/zWTWZApJFL7Rf1VbI3hWvWoY1bjXpSz 2+LAVdn6ukkicg0yY2qPw7b+e8whqR0SIMeSIiL5WTxuLwq3rNZ8WNEr4wLtcgMWYaR2 ZADglGlIoVHQsSWa5fpz30yv+rVjNZ0rt2i2DHkGgPgS9vWZOtzd6+qDvYTW/gI2bdRy kCpwewow2HPjCpF7noCc2fcg6uX1BGweP7CbTJqUmNxrUsw64AyQcgFOwMZxC2QAaAMz r0MJ93EEQ7vDKdpteQK1DLAppiK94NwhqAHUi66px8WxNDLBKOoUnluPSuXWSj7mgi70 e+eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691269607; x=1691874407; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7bQWyorKrsAyTYwSEr05KzsqtWIhFwBSuW+LToiflyQ=; b=geR+hGXPsAYj/ayO5ee096ty8JoK27t7GMG+ieHSooCWiqFNiSl7Wdq9DWmmK6dfw8 LYjnb0Jtvj1YFvMfMEWqQAPCmhlLARciyx9FKCoGUtAOwNMaZZqurfAMEqH2UVj1gn9V C6iYDQThuKaZ7sbr6Mg3dx2Bn8bdnKfdMuntQTVXJrE8QqYasrfB3i/IE+NYNzwBggEc GP7uYiJLs/kM7axm1cFs+VFb1be5TlvI1gTS5C2Gy84d50gw7sC2qUl3brMWHgdMNmCM hNdkNNqe5UGugE7F4Yk0I8Kr6b6o2WiYBzeanIG3XvywqpoCxss8PuOYDYcBC/yGSWuZ L4AQ== X-Gm-Message-State: AOJu0Yyb8DoTJ3yjvUEVZfmPOSnZQAe850tpp1LsIrxIlOGXwInmEAau He3aRGVs4JN37xjO18DHWwEPmg== X-Google-Smtp-Source: AGHT+IGBFr8NySeTwyPsNV646xsK3/GAjBh+mi0q0UZ3HrUugcDHoZRLvIbht/mcU3b6eaKo7B9hrg== X-Received: by 2002:a7b:cbc7:0:b0:3fb:bc6d:41f1 with SMTP id n7-20020a7bcbc7000000b003fbbc6d41f1mr4242361wmi.17.1691269606259; Sat, 05 Aug 2023 14:06:46 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.245]) by smtp.gmail.com with ESMTPSA id n22-20020a7bc5d6000000b003fe195cecb3sm10258351wmk.38.2023.08.05.14.06.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Aug 2023 14:06:45 -0700 (PDT) Message-ID: <000f45c5-d7dd-237e-1e1b-72056acd4af1@linaro.org> Date: Sat, 5 Aug 2023 23:06:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v8 04/16] media: cadence: Add support for TI SoCs Content-Language: en-US To: Jai Luthra , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus , Laurent Pinchart , Tomi Valkeinen Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab , Maxime Ripard , niklas.soderlund+renesas@ragnatech.se, Benoit Parrot , Vaishnav Achath , Vignesh Raghavendra , nm@ti.com, devarsht@ti.com References: <20230731-upstream_csi-v8-0-fb7d3661c2c9@ti.com> <20230731-upstream_csi-v8-4-fb7d3661c2c9@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20230731-upstream_csi-v8-4-fb7d3661c2c9@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/07/2023 10:29, Jai Luthra wrote: > Multiple TI SoCs (J721E, AM62) use this CSI2RX receiver, integrated with > an external DPHY and a pixel-grabber IP that unwraps the pixel data and > send it to memory via DMA. > > Add a separate compatible for the TI-specific version of this IP. > > Signed-off-by: Jai Luthra > --- > New in v8 > > drivers/media/platform/cadence/cdns-csi2rx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c > index 0d879d71d818..b087583d636f 100644 > --- a/drivers/media/platform/cadence/cdns-csi2rx.c > +++ b/drivers/media/platform/cadence/cdns-csi2rx.c > @@ -559,6 +559,7 @@ static void csi2rx_remove(struct platform_device *pdev) > > static const struct of_device_id csi2rx_of_table[] = { > { .compatible = "starfive,jh7110-csi2rx" }, > + { .compatible = "ti,j721e-csi2rx" }, Why do you need it? It's redundant - already compatible with cdns. No need to add empty match entries. > { .compatible = "cdns,csi2rx" }, > { }, Best regards, Krzysztof