From: "Inbaraj E" <inbaraj.e@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
<chanho61.park@samsung.com>,
"'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
<tomasz.figa@gmail.com>, "'Chanwoo Choi'" <cw00.choi@samsung.com>,
"'ALIM AKHTAR'" <alim.akhtar@samsung.com>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<robh+dt@kernel.org>
Cc: <linux-samsung-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
"'PANKAJ KUMAR DUBEY'" <pankaj.dubey@samsung.com>
Subject: RE: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock
Date: Mon, 7 Nov 2022 18:07:42 +0530 [thread overview]
Message-ID: <001201d8f2a5$bcb8e870$362ab950$@samsung.com> (raw)
In-Reply-To: <0e929d35-2a90-94fb-49d6-7f6a0f0a3ed0@linaro.org>
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 07 November 2022 14:42
> To: chanho61.park@samsung.com; Inbaraj E <inbaraj.e@samsung.com>;
> Sylwester Nawrocki <s.nawrocki@samsung.com>; tomasz.figa@gmail.com;
> Chanwoo Choi <cw00.choi@samsung.com>; ALIM AKHTAR
> <alim.akhtar@samsung.com>; mturquette@baylibre.com;
> sboyd@kernel.org; robh+dt@kernel.org
> Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; PANKAJ KUMAR DUBEY
> <pankaj.dubey@samsung.com>
> Subject: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
> CMU_FSYS1 mmc card clock
>
> On 07/11/2022 01:04, CHANHO PARK wrote:
> >>> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of
> dout.
> >>>
> >>> This fixes make dtbs_check warning as shown below:
> >>>
> >>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
> >> controller@17040000:
> >>> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From
> schema:
> >>> /home/inbaraj/mainline/linux/Documentation/devicetree/
> >>> bindings/clock/samsung,exynosautov9-clock.yaml
> >>
> >> I don't understand:
> >> 1. Why bindings are wrong not DTSI?
> >> 2. What is "gout"? "dout" had a meaning as clock divider output.
> >
> > "gout" is output of a gate clock, AFAIK.
> > Unlike any other clocks, the fsys1 mmc top clock does not have a divider.
> So, it should be "mout -> gout" instead of "mout -> gout -> dout".
>
> OK, then this should be in commit msg.
>
> My question about full legal name remains, as here in replies I see "Inbaraj
> E".
>
I have address your review comment, and posted v2.
Thanks for review.
> Best regards,
> Krzysztof
prev parent reply other threads:[~2022-11-07 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcas5p2.samsung.com>
2022-11-04 9:00 ` [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock Inbaraj
2022-11-04 13:55 ` Krzysztof Kozlowski
2022-11-04 19:23 ` Krzysztof Kozlowski
[not found] ` <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcms2p3>
2022-11-07 0:04 ` CHANHO PARK
2022-11-07 9:12 ` Krzysztof Kozlowski
2022-11-07 12:37 ` Inbaraj E [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001201d8f2a5$bcb8e870$362ab950$@samsung.com' \
--to=inbaraj.e@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).