* [PATCH RESEND] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1
@ 2022-04-11 14:04 Guillaume Giraudon
2022-04-11 14:20 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Guillaume Giraudon @ 2022-04-11 14:04 UTC (permalink / raw)
To: kernel-dev
Cc: ggiraudon, Rob Herring, Krzysztof Kozlowski, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
The labels for lines 61 through 84 on the periphs-banks were offset by 2.
Realigned them to match the Banana Pi M5 schematics.
Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")
Signed-off-by: Guillaume Giraudon <ggiraudon@prism19.com>
---
arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
index 5751c48620ed..754c3d43ef0b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
@@ -448,7 +448,7 @@
"",
/* GPIOA */
"", "", "", "", "", "", "", "",
- "", "", "", "", "", "",
+ "", "", "", "", "", "", "", "",
"CON1-P27", /* GPIOA_14 */
"CON1-P28", /* GPIOA_15 */
/* GPIOX */
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1 2022-04-11 14:04 [PATCH RESEND] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1 Guillaume Giraudon @ 2022-04-11 14:20 ` Neil Armstrong 2022-04-11 14:22 ` ggiraudon 0 siblings, 1 reply; 3+ messages in thread From: Neil Armstrong @ 2022-04-11 14:20 UTC (permalink / raw) To: Guillaume Giraudon, kernel-dev Cc: Rob Herring, Krzysztof Kozlowski, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel Hi, On 11/04/2022 16:04, Guillaume Giraudon wrote: > The labels for lines 61 through 84 on the periphs-banks were offset by 2. > Realigned them to match the Banana Pi M5 schematics. > > Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts") > > Signed-off-by: Guillaume Giraudon <ggiraudon@prism19.com> > --- > arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > index 5751c48620ed..754c3d43ef0b 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > @@ -448,7 +448,7 @@ > "", > /* GPIOA */ > "", "", "", "", "", "", "", "", > - "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > "CON1-P27", /* GPIOA_14 */ > "CON1-P28", /* GPIOA_15 */ > /* GPIOX */ While reviewing more closely I figured that in fact the issue comes from the : /* BOOT */ "eMMC_D0", /* BOOT_0 */ "eMMC_D1", /* BOOT_1 */ "eMMC_D2", /* BOOT_2 */ "eMMC_D3", /* BOOT_3 */ "eMMC_D4", /* BOOT_4 */ "eMMC_D5", /* BOOT_5 */ "eMMC_D6", /* BOOT_6 */ "eMMC_D7", /* BOOT_7 */ "eMMC_CLK", /* BOOT_8 */ "", "eMMC_CMD", /* BOOT_10 */ "", "eMMC_RST#", /* BOOT_12 */ "eMMC_DS", /* BOOT_13 */ /* GPIOC */ it contains 14 entries, but there is 16 BOOT gpio lines. So instead, send a V2 with 2 entries added in BOOT and leave the GPIOA entries as-is. Thanks, Neil ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH RESEND] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1 2022-04-11 14:20 ` Neil Armstrong @ 2022-04-11 14:22 ` ggiraudon 0 siblings, 0 replies; 3+ messages in thread From: ggiraudon @ 2022-04-11 14:22 UTC (permalink / raw) To: 'Neil Armstrong', kernel-dev Cc: 'Rob Herring', 'Krzysztof Kozlowski', 'Kevin Hilman', 'Jerome Brunet', 'Martin Blumenstingl', devicetree, linux-arm-kernel, linux-amlogic, linux-kernel Will do. Thanks Neil. G -----Original Message----- From: Neil Armstrong <narmstrong@baylibre.com> Sent: April 11, 2022 10:21 AM To: Guillaume Giraudon <ggiraudon@prism19.com>; kernel-dev@prism19.com Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Kevin Hilman <khilman@baylibre.com>; Jerome Brunet <jbrunet@baylibre.com>; Martin Blumenstingl <martin.blumenstingl@googlemail.com>; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-amlogic@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1 Hi, On 11/04/2022 16:04, Guillaume Giraudon wrote: > The labels for lines 61 through 84 on the periphs-banks were offset by 2. > Realigned them to match the Banana Pi M5 schematics. > > Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 > board dts") > > Signed-off-by: Guillaume Giraudon <ggiraudon@prism19.com> > --- > arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > index 5751c48620ed..754c3d43ef0b 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > @@ -448,7 +448,7 @@ > "", > /* GPIOA */ > "", "", "", "", "", "", "", "", > - "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > "CON1-P27", /* GPIOA_14 */ > "CON1-P28", /* GPIOA_15 */ > /* GPIOX */ While reviewing more closely I figured that in fact the issue comes from the : /* BOOT */ "eMMC_D0", /* BOOT_0 */ "eMMC_D1", /* BOOT_1 */ "eMMC_D2", /* BOOT_2 */ "eMMC_D3", /* BOOT_3 */ "eMMC_D4", /* BOOT_4 */ "eMMC_D5", /* BOOT_5 */ "eMMC_D6", /* BOOT_6 */ "eMMC_D7", /* BOOT_7 */ "eMMC_CLK", /* BOOT_8 */ "", "eMMC_CMD", /* BOOT_10 */ "", "eMMC_RST#", /* BOOT_12 */ "eMMC_DS", /* BOOT_13 */ /* GPIOC */ it contains 14 entries, but there is 16 BOOT gpio lines. So instead, send a V2 with 2 entries added in BOOT and leave the GPIOA entries as-is. Thanks, Neil ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-11 14:22 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-04-11 14:04 [PATCH RESEND] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1 Guillaume Giraudon 2022-04-11 14:20 ` Neil Armstrong 2022-04-11 14:22 ` ggiraudon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).