From: <markus.stockhausen@gmx.de>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
<linux-phy@lists.infradead.org>,
<chris.packham@alliedtelesis.co.nz>, <devicetree@vger.kernel.org>
Subject: AW: AW: AW: [PATCH v2 1/3] dt-bindings: phy: add realtek,otto-serdes PHY binding
Date: Tue, 8 Oct 2024 11:27:15 +0200 [thread overview]
Message-ID: <001401db1964$44f0b010$ced21030$@gmx.de> (raw)
In-Reply-To: <30a71840-75ee-44d6-af6e-fca27af88750@kernel.org>
> -----Ursprüngliche Nachricht-----
> Von: Krzysztof Kozlowski <krzk@kernel.org>
> Gesendet: Dienstag, 8. Oktober 2024 10:32
> An: markus.stockhausen@gmx.de; linux-phy@lists.infradead.org; chris.packham@alliedtelesis.co.nz; devicetree@vger.kernel.org
> Betreff: Re: AW: AW: [PATCH v2 1/3] dt-bindings: phy: add realtek,otto-serdes PHY binding
>
> On 08/10/2024 08:56, markus.stockhausen@gmx.de wrote:
> >>
> >>> E.g. st,invert-ext. Something like this will be needed in the future
> >>> because the SerDes allow to swap polarity which must be changed
> >>> depending on the switch design. How to do this?
> >>
> >> I do not understand the hardware aspect discussed in the property description... probably because there is no hardware description at all, but instead you speak about driver.
> >>
> >> I do not understand how polarity has anything to do with U-Boot configuring serdes.
> >
> > Maybe my lack of knowledge in platform driver programming or the
> > naming conventions leads to confusion. I'm searching for knobs to
> > control the behaviour of the SerDes depending on the hardware. Two examples are (more may come):
> >
> > - "ignore SerDes X": because the provided patch sequence confuses the
> > SerDes and overwrites registers with wrong values that vendor patched
> > U-Boot has setup correctly before.
>
> And if someone updates the bootloader to a bit different one, the DTS
> becomes wrong? How do you handle then same board with two different
> bootloaders requiring two different DTS? DTS is software-independent
> description of the hardware, so this does not look like DTS property.
Good point. So the initial idea to provide dynamic patch sequences was
the right direction but storing in devicetree is wrong. Like Chris mentioned
I would change the code to make use of a dynamically loaded firmware file.
- if exist: run sequences from there
- if not exist: keep registers as is.
Reasonable idea?
Best regards.
Markus
next prev parent reply other threads:[~2024-10-08 9:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 16:36 [PATCH v2 0/3] phy: Realtek Otto SerDes: add new driver Markus Stockhausen
2024-10-07 16:36 ` [PATCH v2 1/3] dt-bindings: phy: add realtek,otto-serdes PHY binding Markus Stockhausen
2024-10-07 18:17 ` Rob Herring (Arm)
2024-10-07 19:26 ` Krzysztof Kozlowski
2024-10-08 5:38 ` AW: " markus.stockhausen
2024-10-08 6:17 ` Krzysztof Kozlowski
2024-10-08 6:56 ` AW: " markus.stockhausen
2024-10-08 8:32 ` Krzysztof Kozlowski
2024-10-08 9:27 ` markus.stockhausen [this message]
2024-10-16 15:30 ` markus.stockhausen
2024-10-17 6:15 ` Krzysztof Kozlowski
2024-10-07 19:30 ` Rob Herring
2024-10-08 12:27 ` AW: " markus.stockhausen
2024-10-08 7:04 ` Krzysztof Kozlowski
2024-10-08 7:06 ` Krzysztof Kozlowski
2024-10-07 16:36 ` [PATCH v2 2/3] phy: Realtek Otto SerDes driver Markus Stockhausen
2024-10-07 19:32 ` Krzysztof Kozlowski
2024-10-07 16:36 ` [PATCH v2 3/3] phy: Integrate Realtek Otto SerDes driver into build system Markus Stockhausen
2024-10-07 19:27 ` Krzysztof Kozlowski
2024-10-08 6:38 ` kernel test robot
2024-10-08 7:20 ` kernel test robot
2024-10-08 8:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001401db1964$44f0b010$ced21030$@gmx.de' \
--to=markus.stockhausen@gmx.de \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-phy@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).